From patchwork Tue Sep 28 17:11:11 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 66007 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 682C1B7126 for ; Wed, 29 Sep 2010 03:11:25 +1000 (EST) Received: (qmail 14329 invoked by alias); 28 Sep 2010 17:11:23 -0000 Received: (qmail 14317 invoked by uid 22791); 28 Sep 2010 17:11:22 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, TW_ZJ, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Sep 2010 17:11:16 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 5CDF43F7; Tue, 28 Sep 2010 19:11:14 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id i6e7wONTP1Ja; Tue, 28 Sep 2010 19:11:12 +0200 (CEST) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 41A833F5; Tue, 28 Sep 2010 19:11:12 +0200 (CEST) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.4+Sun/8.14.4/Submit) id o8SHBBKA015192; Tue, 28 Sep 2010 19:11:11 +0200 (MEST) From: Rainer Orth To: Uros Bizjak Cc: gcc-patches@gcc.gnu.org, Chris Quenelle , Nathan Sidwell Subject: Re: Allow Solaris 2/x86 ABI to match recent Studio compiler (PR target/44452) References: Date: Tue, 28 Sep 2010 19:11:11 +0200 In-Reply-To: (Uros Bizjak's message of "Tue, 28 Sep 2010 17:20:49 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Uros Bizjak writes: > Generic x86 part is OK. Thanks. Unfortunately, I hadn't noticed that the approval didn't apply to the vx-common.h part and checked in the patch. I hope that won't cause any trouble. >> 2010-09-26  Rainer Orth   >> >>        gcc/testsuite: >>        PR target/44452 >>        * gcc.target/i386/abi-2.c: XFAIL on i?86-*-solaris2* && ilp32. >>        * gcc.target/i386/pr22076.c: Likewise. > > Just skip pr22076.c on solaris targets, no need for so many complications. > > OK with this change. Fine with me. Here's what I've checked into the 4.4 and 4.5 branches after testing with runtest and DEJAGNU pointing to a site.exp that exercised both 32 and 64-bit multilibs to make sure only the 32-bit test is skipped. Thanks. Rainer 2010-09-26 Rainer Orth PR target/44452 * gcc.target/i386/abi-2.c: XFAIL on i?86-*-solaris2* && ilp32. * gcc.target/i386/pr22076.c: Skip on i?86-solaris2* && ilp32. diff -r ce8a598bd7f1 gcc/testsuite/gcc.target/i386/abi-2.c --- a/gcc/testsuite/gcc.target/i386/abi-2.c Tue Sep 28 18:35:47 2010 +0200 +++ b/gcc/testsuite/gcc.target/i386/abi-2.c Tue Sep 28 18:49:28 2010 +0200 @@ -6,4 +6,5 @@ typedef long long __m256i __attribute__ ((__vector_size__ (32))); __m256i foo (void) { return (__m256i){ 1, 2, 3, 4 }; } -/* { dg-final { scan-assembler-times "ymm0" 1 } } */ +/* Fails on 32-bit Solaris 2/x86: PR target/44452 */ +/* { dg-final { scan-assembler-times "ymm0" 1 { xfail { i?86-*-solaris2* && ilp32 } } } } */ diff -r ce8a598bd7f1 gcc/testsuite/gcc.target/i386/pr22076.c --- a/gcc/testsuite/gcc.target/i386/pr22076.c Tue Sep 28 18:35:47 2010 +0200 +++ b/gcc/testsuite/gcc.target/i386/pr22076.c Tue Sep 28 18:49:28 2010 +0200 @@ -1,4 +1,5 @@ -/* { dg-do compile } */ +/* Fails on 32-bit Solaris 2/x86: PR target/44452 */ +/* { dg-do compile { target { ! { i?86-*-solaris2* && ilp32 } } } } */ /* { dg-options "-O2 -fomit-frame-pointer -flax-vector-conversions -mmmx" } */ #include