diff mbox

[testsuite,c++] Use signed char in g++.dg/template/char1.C

Message ID ydd7hdylcfd.fsf@manam.CeBiTec.Uni-Bielefeld.DE
State New
Headers show

Commit Message

Rainer Orth Jan. 21, 2011, 11:32 a.m. UTC
The g++.dg/template/char1.C test FAILs on mips-sgi-irix6.5 on mainline:

FAIL: g++.dg/template/char1.C  (test for warnings, line 4)

This happens because the test assumes that char is signed, but on IRIX,
it is unsigned.  Fixed thus, tested with the appropriate runtest
invocations on mips-sgi-irix6.5 and i386-pc-solaris2.11.

Ok for mainline, though I suppose this is obvious.

Thanks.
	Rainer


2011-01-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* g++.dg/template/char1.C: Use signed char.

Comments

Richard Biener Jan. 21, 2011, 11:34 a.m. UTC | #1
On Fri, Jan 21, 2011 at 12:32 PM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
> The g++.dg/template/char1.C test FAILs on mips-sgi-irix6.5 on mainline:
>
> FAIL: g++.dg/template/char1.C  (test for warnings, line 4)
>
> This happens because the test assumes that char is signed, but on IRIX,
> it is unsigned.  Fixed thus, tested with the appropriate runtest
> invocations on mips-sgi-irix6.5 and i386-pc-solaris2.11.
>
> Ok for mainline, though I suppose this is obvious.

Ok.

Thanks,
Richard.

> Thanks.
>        Rainer
>
>
> 2011-01-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>        * g++.dg/template/char1.C: Use signed char.
>
> Index: gcc/testsuite/g++.dg/template/char1.C
> ===================================================================
> --- gcc/testsuite/g++.dg/template/char1.C       (revision 169081)
> +++ gcc/testsuite/g++.dg/template/char1.C       (working copy)
> @@ -1,4 +1,4 @@
>  template <class CharType, CharType line_terminator = 0>
>  class String {};
>
> -String<char, 255> s;           // { dg-warning "overflow" }
> +String<signed char, 255> s;            // { dg-warning "overflow" }
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
diff mbox

Patch

Index: gcc/testsuite/g++.dg/template/char1.C
===================================================================
--- gcc/testsuite/g++.dg/template/char1.C	(revision 169081)
+++ gcc/testsuite/g++.dg/template/char1.C	(working copy)
@@ -1,4 +1,4 @@ 
 template <class CharType, CharType line_terminator = 0>
 class String {};
 
-String<char, 255> s;		// { dg-warning "overflow" }
+String<signed char, 255> s;		// { dg-warning "overflow" }