From patchwork Fri Feb 24 15:57:06 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 142929 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 5D7FFB6EEA for ; Sat, 25 Feb 2012 02:57:33 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1330703854; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:From:To:Subject:Date:Message-ID:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=ZSOQF9VSWZY/6ovGRyBUZ47WVVU=; b=ZzwEfm/rCQQejua h/gpJ0SjkxfhInFDVolvw5a6IVaL18yLsPo+BuQgKpmk/FHHpALfFoMZIRil3JHw qii7XCPtG/BCrIAlnArDSX2VcJLt8arfjHsc2BkMzdIxF8H2XjsUxI1NV5yjes2w uJsI1T3UYe58AfIi60lvEs8XOTE8= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:From:To:Subject:Date:Message-ID:User-Agent:MIME-Version:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=oij4G8XW+anLfvyZopHU3MYgdq4uiwSuReY5quQ6OGNWCj3ZUVJfeLhnk4M5tP Nh5fye4g6nIvFm2kIpCfUaH8wmhDsyOmULsos+Za3nEn5QkgwO9YRKr56QKxtJK5 wvK4jCyGGYe8kqht953NZJ6ljyXvpDhEDYEAfPSRdDsng=; Received: (qmail 24900 invoked by alias); 24 Feb 2012 15:57:28 -0000 Received: (qmail 24881 invoked by uid 22791); 24 Feb 2012 15:57:26 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Feb 2012 15:57:10 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 6CBB48D3 for ; Fri, 24 Feb 2012 16:57:09 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5VBCQ3dj+TUH for ; Fri, 24 Feb 2012 16:57:07 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 192408D2 for ; Fri, 24 Feb 2012 16:57:07 +0100 (CET) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.5+Sun/8.14.5/Submit) id q1OFv6eG017009; Fri, 24 Feb 2012 16:57:06 +0100 (MET) From: Rainer Orth To: gcc-patches@gcc.gnu.org Subject: [testsuite] Skip gcc.target/mips/interrupt_handler-[23].c on IRIX (PR target/50580) Date: Fri, 24 Feb 2012 16:57:06 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Looking closer into the gcc.target/mips/interrupt_handler-[23].c failures FAIL: gcc.target/mips/interrupt_handler-2.c scan-assembler \\t\\\\.cfi_restore 64\\n FAIL: gcc.target/mips/interrupt_handler-2.c scan-assembler \\t\\\\.cfi_restore 65\\n and many more for interrupt_handler-3.c, I now understand what's going on: .cfi* directives are only emitted if dwarf2cfi.c (dwarf2out_do_cfi_asm) returns true, but if MIPS_DEBUGGING_INFO is defined (as is the case in iris6.h), it returns false. Thus, the tests are meaningless since even the scan-assembler-not tests only succeed because no .cfi* directives whatsoever are present in the assembler output. XFAILing them with dg-xfail-if doesn't work: XPASS: gcc.target/mips/interrupt_handler-2.c (test for excess errors) FAIL: gcc.target/mips/interrupt_handler-2.c scan-assembler \t\\.cfi_restore 64\n FAIL: gcc.target/mips/interrupt_handler-2.c scan-assembler \t\\.cfi_restore 65\n and adding xfail's to each and every dg-final seems pointless, especially given that the scan-assembler-not tests only pass by accident. I therefore just skip the tests on IRIX. Tested with the appropriate runtest invocation on mips-sgi-irix6.5, installed on mainline. Rainer 2012-02-24 Rainer Orth PR target/50580 * gcc.target/mips/interrupt_handler-2.c: Skip on mips-sgi-irix6*. * gcc.target/mips/interrupt_handler-3.c: Likewise. # HG changeset patch # Parent 5002952adc32431a8c1084a301aa929640d70870 [testsuite] Skip gcc.target/mips/interrupt_handler-[23].c on IRIX (PR target/50580) diff --git a/gcc/testsuite/gcc.target/mips/interrupt_handler-2.c b/gcc/testsuite/gcc.target/mips/interrupt_handler-2.c --- a/gcc/testsuite/gcc.target/mips/interrupt_handler-2.c +++ b/gcc/testsuite/gcc.target/mips/interrupt_handler-2.c @@ -4,6 +4,7 @@ /* { dg-final { scan-assembler "\t\\\.cfi_restore 65\n" } } */ /* { dg-final { scan-assembler-not "\\\.cfi_def_cfa( |\t)" } } */ /* { dg-final { scan-assembler-not "\\\.cfi_def_cfa_register( |\t)" } } */ +/* { dg-skip-if "PR target/50580" { mips-sgi-irix6* } } */ extern void f (void); diff --git a/gcc/testsuite/gcc.target/mips/interrupt_handler-3.c b/gcc/testsuite/gcc.target/mips/interrupt_handler-3.c --- a/gcc/testsuite/gcc.target/mips/interrupt_handler-3.c +++ b/gcc/testsuite/gcc.target/mips/interrupt_handler-3.c @@ -23,6 +23,7 @@ /* { dg-final { scan-assembler "\t\\\.cfi_def_cfa_offset 0\n" } } */ /* { dg-final { scan-assembler-not "\\\.cfi_def_cfa( |\t)" } } */ /* { dg-final { scan-assembler-not "\\\.cfi_def_cfa_register( |\t)" } } */ +/* { dg-skip-if "PR target/50580" { mips-sgi-irix6* } } */ extern void f (void);