| Message ID | ydd4k952osx.fsf@CeBiTec.Uni-Bielefeld.DE |
|---|---|
| State | New |
| Headers | show |
| Series | testsuite: i386: Fix gcc.target/i386/avx512fp16-trunchf.c on Solaris [PR102835] | expand |
I think this can be put in as an obvious fix. Thanks for the patch. Rainer Orth <ro@cebitec.uni-bielefeld.de> 于2021年10月25日周一 下午9:53写道： > > The gcc.target/i386/avx512fp16-trunchf.c test FAILs on 32-bit Solaris/x86: > > FAIL: gcc.target/i386/avx512fp16-trunchf.c scan-assembler-times vcvttsh2si[ \\\\t]+[^{\\n]*(?:%xmm[0-9]|\\\\(%esp\\\\))+, %eax(?:\\n|[ \\\\t]+#) 3 > FAIL: gcc.target/i386/avx512fp16-trunchf.c scan-assembler-times vcvttsh2usi[ \\\\t]+[^{\\n]*(?:%xmm[0-9]|\\\\(%esp\\\\))+, %eax(?:\\n|[ \\\\t]+#) 2 > > This happens because Solaris defaults to -fno-omit-frame-pointer, so it > uses %ebp instead of the expected %esp. As Hongyu Wang suggested in the > PR, this can be fixed by accepting both forms, which this patch does. > > Tested on i386-pc-solaris2.11 and x86_64-pc-linux-gnu. > > Ok for master? > > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University > > > 2021-10-20 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> > > gcc/testsuite: > * gcc.target/i386/avx512fp16-trunchf.c: Allow for %esp instead of > %ebp. >
# HG changeset patch # Parent 42f3c920a9840cff9344293def88b179095d62bd testsuite: i386: Fix gcc.target/i386/avx512fp16-trunchf.c on Solaris [PR102835] diff --git a/gcc/testsuite/gcc.target/i386/avx512fp16-trunchf.c b/gcc/testsuite/gcc.target/i386/avx512fp16-trunchf.c --- a/gcc/testsuite/gcc.target/i386/avx512fp16-trunchf.c +++ b/gcc/testsuite/gcc.target/i386/avx512fp16-trunchf.c @@ -1,7 +1,7 @@ /* { dg-do compile } */ /* { dg-options "-O2 -mavx512fp16" } */ -/* { dg-final { scan-assembler-times "vcvttsh2si\[ \\t\]+\[^\{\n\]*(?:%xmm\[0-9\]|\\(%esp\\))+, %eax(?:\n|\[ \\t\]+#)" 3 } } */ -/* { dg-final { scan-assembler-times "vcvttsh2usi\[ \\t\]+\[^\{\n\]*(?:%xmm\[0-9\]|\\(%esp\\))+, %eax(?:\n|\[ \\t\]+#)" 2 } } */ +/* { dg-final { scan-assembler-times "vcvttsh2si\[ \\t\]+\[^\{\n\]*(?:%xmm\[0-9\]|\\(%e\[bs\]p\\))+, %eax(?:\n|\[ \\t\]+#)" 3 } } */ +/* { dg-final { scan-assembler-times "vcvttsh2usi\[ \\t\]+\[^\{\n\]*(?:%xmm\[0-9\]|\\(%e\[bs\]p\\))+, %eax(?:\n|\[ \\t\]+#)" 2 } } */ /* { dg-final { scan-assembler-times "vcvttsh2si\[ \\t\]+\[^\{\n\]*%xmm\[0-9\]+, %rax(?:\n|\[ \\t\]+#)" 1 { target { ! ia32 } } } } */ /* { dg-final { scan-assembler-times "vcvttsh2usi\[ \\t\]+\[^\{\n\]*%xmm\[0-9\]+, %rax(?:\n|\[ \\t\]+#)" 1 { target { ! ia32 } } } } */ /* { dg-final { scan-assembler "xorl\[ \\t\]+%edx, %edx" { target ia32 } } } */
The gcc.target/i386/avx512fp16-trunchf.c test FAILs on 32-bit Solaris/x86: FAIL: gcc.target/i386/avx512fp16-trunchf.c scan-assembler-times vcvttsh2si[ \\\\t]+[^{\\n]*(?:%xmm[0-9]|\\\\(%esp\\\\))+, %eax(?:\\n|[ \\\\t]+#) 3 FAIL: gcc.target/i386/avx512fp16-trunchf.c scan-assembler-times vcvttsh2usi[ \\\\t]+[^{\\n]*(?:%xmm[0-9]|\\\\(%esp\\\\))+, %eax(?:\\n|[ \\\\t]+#) 2 This happens because Solaris defaults to -fno-omit-frame-pointer, so it uses %ebp instead of the expected %esp. As Hongyu Wang suggested in the PR, this can be fixed by accepting both forms, which this patch does. Tested on i386-pc-solaris2.11 and x86_64-pc-linux-gnu. Ok for master? Rainer