| Message ID | trinity-89336fcc-9c0b-4a96-b6ed-d254a11cc5bb-1700686952233@3c-app-gmx-bs17 |
|---|---|
| State | New |
| Headers | show |
| Series | [testsuite,fortran] fix invalid testcases (missing MOLD argument to NULL) | expand |
Hello, Le 22/11/2023 à 22:02, Harald Anlauf a écrit : > Dear all, > > testcases assumed_rank_8.f90 and assumed_rank_10.f90 are invalid: > NULL() is passed without MOLD to an assumed-rank dummy argument. > > This is detected by NAG, but not yet by gfortran (see pr104819). > gfortran even ignores the MOLD argument; the dump-tree is identical > if MOLD is there or not. > > Now these testcases are { dg-do run }. Therefore I would like to > fix these testcases, independent of the work on fixing pr104819. > > Comments? > Makes sense; OK from my point of view. Mikael
From cbb0c61f9d6f06667666a33da6e6ce3213a92248 Mon Sep 17 00:00:00 2001 From: Harald Anlauf <anlauf@gmx.de> Date: Wed, 22 Nov 2023 21:45:46 +0100 Subject: [PATCH] testsuite: fortran: fix invalid testcases (missing MOLD argument to NULL) The Fortran standard requires that NULL() passed to an assumed-rank dummy argument has a MOLD argument. gcc/testsuite/ChangeLog: PR fortran/104819 * gfortran.dg/assumed_rank_10.f90: Add MOLD argument to NULL(). * gfortran.dg/assumed_rank_8.f90: Likewise. --- gcc/testsuite/gfortran.dg/assumed_rank_10.f90 | 6 +++--- gcc/testsuite/gfortran.dg/assumed_rank_8.f90 | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gcc/testsuite/gfortran.dg/assumed_rank_10.f90 b/gcc/testsuite/gfortran.dg/assumed_rank_10.f90 index 6a3cc94483e..f22d43ab955 100644 --- a/gcc/testsuite/gfortran.dg/assumed_rank_10.f90 +++ b/gcc/testsuite/gfortran.dg/assumed_rank_10.f90 @@ -50,9 +50,9 @@ program test is_present = .false. - call fpa(null(), null()) ! No copy back - call fpi(null(), null()) ! No copy back - call fno(null(), null()) ! No copy back + call fpa(null(iip), null(jjp)) ! No copy back + call fpi(null(iip), null(jjp)) ! No copy back + call fno(null(iip), null(jjp)) ! No copy back call fno() ! No copy back diff --git a/gcc/testsuite/gfortran.dg/assumed_rank_8.f90 b/gcc/testsuite/gfortran.dg/assumed_rank_8.f90 index 5873296a7a5..34ff42c0be2 100644 --- a/gcc/testsuite/gfortran.dg/assumed_rank_8.f90 +++ b/gcc/testsuite/gfortran.dg/assumed_rank_8.f90 @@ -22,13 +22,13 @@ program main call f (ii) call f (489) call f () - call f (null()) + call f (null(kk)) call f (kk) if (j /= 2) STOP 1 j = 0 nullify (ll) - call g (null()) + call g (null(ll)) call g (ll) call g (ii) if (j /= 1) STOP 2 -- 2.35.3
Dear all, testcases assumed_rank_8.f90 and assumed_rank_10.f90 are invalid: NULL() is passed without MOLD to an assumed-rank dummy argument. This is detected by NAG, but not yet by gfortran (see pr104819). gfortran even ignores the MOLD argument; the dump-tree is identical if MOLD is there or not. Now these testcases are { dg-do run }. Therefore I would like to fix these testcases, independent of the work on fixing pr104819. Comments? Thanks, Harald