From patchwork Wed Mar 22 18:30:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Anlauf X-Patchwork-Id: 1759965 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=JK4Gbx1/; dkim-atps=neutral Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PhcVL58z9z247d for ; Thu, 23 Mar 2023 05:30:46 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D6B4385843D for ; Wed, 22 Mar 2023 18:30:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D6B4385843D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1679509844; bh=1gCHz41ZPkldF/bnn5uxp5mEegPan/hLaRx5oDZ14dA=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=JK4Gbx1/nIs711mEabt7lV2Ua3LaSlADuTcFVL+KxR0zhsavSKI2wgaQEt81DFQH/ 88K8wMzP0b2koS9xN4PlOG6cD0/3w6RbB4OhJ36dx4+CUy5eqOWZ32kMWEWtUzIkUN EUNUuwuRatKqWBFSsGRMK/1NyYRLFlPEzZOyGlbY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id A6CEE3858436; Wed, 22 Mar 2023 18:30:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A6CEE3858436 X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [93.207.81.6] ([93.207.81.6]) by web-mail.gmx.net (3c-app-gmx-bap55.server.lan [172.19.172.125]) (via HTTP); Wed, 22 Mar 2023 19:30:23 +0100 MIME-Version: 1.0 Message-ID: To: fortran , gcc-patches Subject: [PATCH, committed] Fortran: improve checking of FINAL subroutine arguments [PR104572] Date: Wed, 22 Mar 2023 19:30:23 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:k4k7zSxG4zlbkbhNgbAyjNeWvmmHHEIQS9vYeWDIA6PWxBxssHBICL3sONsxaZJz5x6L3 IuCRkIgDAeLv0KT+eOSH9/TEHkPX6/YeeLy/kCxhs3acGlix82EYwp9JjZwGjjHPmci/hl+hbInr 4Fd5ZBTgj8Gt2Sow1d9j5asif2ajLPF6SJJW6h5WXFrfmirK4LarQhp5t+kplCIwx25KVArPJLUE MZ4DoyZOTkbDmrGRk60qaF7i2yEUlkKBhMvrnTRNoHq9nzefkk8TYOi8E9M3IdI/hJ5stIzU0rG8 ek= UI-OutboundReport: notjunk:1;M01:P0:TKA8CtEdHus=;gRPGkTtVZjdYh1zA8vXMHDpC+L0 sfcKCXetb1OY4EBERJDb/PBqjB6ceRDulRqVTEaWyGKsKizixnk4whHg+jCxmvM8DsW6eyG6Q Dl6LKYkC3h7zLk/KdKWtmFqHV6c2eN7nKq5iVkStdWU6B/ORS8Zxq7CrjlDdGX9bzqp8v7xhQ Sfj2U6mGsffW6kAV+YcoqbIVqKVUMlKwQ8fkvQkc5j9bTn6BRUIjLOwL5rrHU4xYWVWWFY4xP WJ6HgGyhymXARdXYqOxFGR6bUBcJOSWMRkQS91R077VQIB2ZZvOJ+YwPrRE9Gm57SJPcisz0+ 4s6eYMWxHRYMZWBbgV9jrHB+uw/oTjA5eZd/h4Wd5sSVGLI5EtOinc3VSYWfh4zUWN0KS0UCx jf61bdWK5EybuYwREMqu7zkxdvZc791iOItx+KD6t1k6in8eDehuA3l2q3Xb9sp7iK7XmFSst 8m/mZgJiojAsb5NcfwfJ/3B588AnwoAzUZsY2TewjIv+yMtiJBPksfAbgBiWhcRcT8vMLgEgQ fZxT0iAo/AWNXaJeK85tCzvj1FJ2NVZrbmKlsbUyNR49Z+jm3hFP9mdLv2dqWVas+20X9H2zs wC+KL0dereke0SyxhcrL//XlvQM4/wOycF2OIT+0D719DnfVQiUeUGw20E4tMymt1qPD7sK5T jfu5ayoRv3Zo3N9SgzctMVeog6fDWzVsoO3cyjOH1NGy5gODIQC5MkoxODB6moxRJmHoo8C3l NANJc04tXSY31YGgabokDf72dTbqq/92e+LPWzcgL0uzJDgYrfAfaml0RdKZVXWda3oSlQ1aI KvzB8seNL5Sgez60X0iTPG9V2E+fmSeWK9HiItzAs2Xig= X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harald Anlauf via Gcc-patches From: Harald Anlauf Reply-To: Harald Anlauf Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Dear all, I've committed the attached simple patch after discussion with Steve (see PR). We need to reject alternate return arguments of FINAL subroutines. Regtested on x86_64-pc-linux-gnu. Thanks, Harald From 3e791f45ded89626bc1f9f8013728f6e035801b2 Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Wed, 22 Mar 2023 19:20:41 +0100 Subject: [PATCH] Fortran: improve checking of FINAL subroutine arguments [PR104572] gcc/fortran/ChangeLog: PR fortran/104572 * resolve.cc (gfc_resolve_finalizers): Argument of a FINAL subroutine cannot be an alternate return. gcc/testsuite/ChangeLog: PR fortran/104572 * gfortran.dg/pr104572.f90: New test. Co-authored-by: Steven G. Kargl --- gcc/fortran/resolve.cc | 7 +++++++ gcc/testsuite/gfortran.dg/pr104572.f90 | 14 ++++++++++++++ 2 files changed, 21 insertions(+) create mode 100644 gcc/testsuite/gfortran.dg/pr104572.f90 diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc index 1a03e458d99..f6ec76acb0b 100644 --- a/gcc/fortran/resolve.cc +++ b/gcc/fortran/resolve.cc @@ -13986,6 +13986,13 @@ gfc_resolve_finalizers (gfc_symbol* derived, bool *finalizable) } arg = dummy_args->sym; + if (!arg) + { + gfc_error ("Argument of FINAL procedure at %L must be of type %qs", + &list->proc_sym->declared_at, derived->name); + goto error; + } + if (arg->as && arg->as->type == AS_ASSUMED_RANK && ((list != derived->f2k_derived->finalizers) || list->next)) { diff --git a/gcc/testsuite/gfortran.dg/pr104572.f90 b/gcc/testsuite/gfortran.dg/pr104572.f90 new file mode 100644 index 00000000000..59fd688d798 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr104572.f90 @@ -0,0 +1,14 @@ +! { dg-do compile } +! { dg-additional-options "-w" } +! PR fortran/104572 - ICE in gfc_resolve_finalizers +! Contributed by G. Steinmetz + +module m + type t + contains + final :: s + end type +contains + subroutine s(*) ! { dg-error "Argument of FINAL procedure" } + end +end -- 2.35.3