From patchwork Mon Aug 24 21:08:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Anlauf X-Patchwork-Id: 1350684 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=UJthkOu4; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bb4VZ3vwQz9sR4 for ; Tue, 25 Aug 2020 07:08:53 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D77903860C37; Mon, 24 Aug 2020 21:08:48 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by sourceware.org (Postfix) with ESMTPS id 724A7385DC39; Mon, 24 Aug 2020 21:08:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 724A7385DC39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=anlauf@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598303320; bh=i72uBygJI1vpbByBN8zGd4LfmHoPh/I5E4gfViZyfSI=; h=X-UI-Sender-Class:From:To:Subject:Date; b=UJthkOu4j6lsdDrm9UvlnZOKEbd6w+CqEfo6QOUiu+vXTv4sxXpVdGUvAYJE5ibIj KZMYgK0ZYN43Dz2Q03HRduZPF3aBPfNterPQ3ohKxNHDrtbkIWiyebgGMB2J8eLFUb F8eYK8yM3PnPzr7S0tXuCBmNVICK8SKtjDhnZQeo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [93.207.83.79] ([93.207.83.79]) by web-mail.gmx.net (3c-app-gmx-bap04.server.lan [172.19.172.74]) (via HTTP); Mon, 24 Aug 2020 23:08:40 +0200 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: fortran , gcc-patches Subject: [PATCH] PR fortran/96711 - ICE on NINT() Function Date: Mon, 24 Aug 2020 23:08:40 +0200 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:IAWexZ8RikeG0bNPCuLqinOf8zRuT1RfOmIcyS+bh+eXGYc+10diAKgDLyTeO7fARClvY GrSuK0PXyFDx1y9MxuXZ0+I3R7ILI5shj8NMqcK1gyeirkb+lna/nSCq0r8QCOOOUIXh7Rb9xcHw kVze9NWo4PdQiYaqTdwYcdeOldxetAqGLdkM1rlWjyxSdsXDXYW/5bwIfigga8jXXC+kiQggVj6+ wmyVQCQRkY2m5TVu6DVPLRlCak1GyJyqlcMUGqwbBQT4TCBXFdZM5wnpn8zeOl2GoO6MiyBSxDjS po= X-UI-Out-Filterresults: notjunk:1;V03:K0:aPI+E+Tsyok=:Wur/+h+T3ut7qk9/1aFCEZ WlsVcj53lezM86wrACSIL9Ng8XCai3F3fleF/5/Fl1/qV/Z2Oi8gmX9y3UwUetFtypMOUmUtR wsXX1ntwYDDbKC3tzau/IX0DfXFbHAwcJCzWuLpVGWn/nGKnPe35+nEYitmLz8vhZueMwMcQb Cps25TtyxU1nls79hdyWghMs/KTmmrHJIPCNmBZGMdUafuruLkaHROnLLC318nAkiMYKheT+i JJyqgvfydkMlLjzOq00UQm+lixvQxHZuNjLo9KJzMgyFXYXDk9QV0UwWE+WvuD4c7lVkIRKFa q1EMmUtTmzxxKrchWy+XuBLzzsEifVjIqRz95n5/eGMGd01u6eY/DBsEDfuwFtVmFuKCeCWx9 ekRGsQGQhxfnU4cuJriUsZh6ClOngLCV8YiOm8ttfj/mzTr3jHWTAEbb5qzL4hKdrABdGTmIm EdtCjSQr3BtSvKVh12c2h+8tz+u4xkBF7fEQlEuiOJbLhZMbA+B0ktZu0neJr9LyBP53pnWAc KLo6OmpUwPdWDSuRV57QlCeJHFHAH1BwWjOKyKT1l4ws/jXxT50aypCP1QA8DOOsD2FQv42wj 42u31InTvTLcYxOpc8uRPBX1wlMgRf/r2u3tJxyE0as5cs4HPojKGAJ9J6dcaTW3gYEB1v3aB fsk1viLDgMZtTO5fkNPZyy2BtAAce0Eys6I5kMjiGgZ2MJA== X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" When rounding a real to integer(16) an ICE happened due to an unhandled case in build_round_expr. The attached patch add a special case for this. I had to change a fold_convert to a convert (which seems to be frontend specific stuff), otherwise I would get errors from the generated GIMPLE. Does anybody know if this could produce problems elsewhere? I'm open to other / better solutions. Anyway, the patch does regtest cleanly on x86_64-pc-linux-gnu. OK for master? Thanks, Harald PR fortran/96711 - ICE with NINT() for integer(16) result When rounding a real to the nearest integer, temporarily convert the real argument to a longer real kind when the result is of type/kind integer(16). gcc/fortran/ChangeLog: * trans-intrinsic.c (build_round_expr): Use temporary with appropriate kind for conversion before rounding to nearest integer when the result precision is 128 bits. gcc/testsuite/ChangeLog: * gfortran.dg/pr96711.f90: New test. diff --git a/gcc/fortran/trans-intrinsic.c b/gcc/fortran/trans-intrinsic.c index 2483f016d8e..32fe9886c57 100644 --- a/gcc/fortran/trans-intrinsic.c +++ b/gcc/fortran/trans-intrinsic.c @@ -395,11 +395,24 @@ build_round_expr (tree arg, tree restype) fn = builtin_decl_for_precision (BUILT_IN_LROUND, argprec); else if (resprec <= LONG_LONG_TYPE_SIZE) fn = builtin_decl_for_precision (BUILT_IN_LLROUND, argprec); + else if (resprec >= argprec && resprec == 128) + { + /* Search for a real kind suitable as temporary for conversion. */ + int kind = -1; + for (int i = 0; kind < 0 && gfc_real_kinds[i].kind != 0; i++) + if (gfc_real_kinds[i].mode_precision >= resprec) + kind = gfc_real_kinds[i].kind; + if (kind < 0) + gfc_internal_error ("Could not find real kind with at least %d bits", + resprec); + arg = fold_convert (gfc_float128_type_node, arg); + fn = gfc_builtin_decl_for_float_kind (BUILT_IN_ROUND, kind); + } else gcc_unreachable (); - return fold_convert (restype, build_call_expr_loc (input_location, - fn, 1, arg)); + return convert (restype, build_call_expr_loc (input_location, + fn, 1, arg)); } diff --git a/gcc/testsuite/gfortran.dg/pr96711.f90 b/gcc/testsuite/gfortran.dg/pr96711.f90 new file mode 100644 index 00000000000..c6534713b52 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr96711.f90 @@ -0,0 +1,18 @@ +! { dg-do compile } +! { dg-require-effective-target fortran_integer_16 } +! { dg-require-effective-target fortran_real_16 } +! +! PR fortran/96711 - ICE on NINT() Function + +program p + implicit none + integer(16) :: m + real(8) :: x + real(16) :: y + x = 2 / epsilon (x) + y = 2 / epsilon (y) + m = nint (x, kind(m)) + print *, m + m = nint (y, kind(m)) + print *, m +end program