From patchwork Mon Apr 22 09:38:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 1926099 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=lj6Igj2G; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VNKvS1rLTz1yZP for ; Mon, 22 Apr 2024 19:39:00 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8B234384AB51 for ; Mon, 22 Apr 2024 09:38:58 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id 681403858D38 for ; Mon, 22 Apr 2024 09:38:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 681403858D38 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 681403858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::32a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713778714; cv=none; b=MgdX47P8A33LzcnLdDJG/LRb/buMFZsZjW70iqBEZvf7xg4P0VY5cUkagDba4ygJV6ECWJHVccVTmsXGs7XG3vUUiMd9MiKigCJlvxC9ySrP07BsSLrHTjd8u+6uuvD0tpS+jd6Wn3yAA+9G2DW4i5IGIs9PkqXpScon4qBpLTE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713778714; c=relaxed/simple; bh=7SHpslhqI7gN5DqsKl46U1G07wxgq5p2ddCffVKTqTo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UKjTeBHqof1rj4EAdHRcR/un4YfPY0FGnwsvPddMZaTxVtOY9P+26/Fkbzq+N5maATbvWJAaEn7CYRgAsy8n9U09EWT6gwWRhjJ+lzbvJmK5rpSAgdzLgqIkyO4NHYtdGqkFXqiZmuL93z1XoDccxoXdn4arvHJZeVyda9L42iY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ot1-x32a.google.com with SMTP id 46e09a7af769-6ea1f98f3b9so1878781a34.1 for ; Mon, 22 Apr 2024 02:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713778704; x=1714383504; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=by1swqtr35qRFXU0R2YeZimSrKgOftgF98OLhZ8Bzzw=; b=lj6Igj2GcQqm6pNjjyb56WZgQynDz9ctJe7TpYYLOJTc7ldk6550uyXOUM1p9KQj8A TtNoO3PRKBYYQBdKWf1XnbqtOa8+Fia+JBqlFJ+n7B1H3fddDHtTK3xWsq4fKhtIQ03K SSLheZgLjnhqSXLRu1VzGrBjh/Un5bEunb9kmXhZmZvcYSslluCKFImMwmBkugQ5hobW ObjLVwJ3NV7r1fukAfTnUH7f4gP26avD7XFRqr1ICWqItgpVsaHvVBCSzrJ8SdgAC8AW YkbzHbU/36Z5LhnHB3sY59ejIqwC2GEsD5vWKWavt713DIgTfrEQ/QXZ3d1FlNNXHQiw 4ePA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713778704; x=1714383504; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=by1swqtr35qRFXU0R2YeZimSrKgOftgF98OLhZ8Bzzw=; b=idwTonLNTy5rWQj8W16S5tjJRORphRpZTvEzvfFxrJ6rLDt0y9i9d30MWv2s9tYMOi aOtKAJwEP466T6TJnoR6Akz+CN0N5PbO5GWVYbwz2yiewD/8y7YZzEsCl08VFPVfIr/2 vXERGeE0kFT+qq51o4T1Ccet7o5bZSrARCg+OMUMmYxBmyftow2R7pEtXSLtnYEy5r7w piBnpCKysco4REtOdRYKPy/8UYnu9XhnHzILaE0+2+wCDDS9IH6RF2R9DFOJpTEFjB2D nfHaPx0ES/+bdhrpG+vQYWaVjS+ZHxKHIM4bhCCUBP2XcP8UmCeFCH5sfBjGPUSlQWuL XbnA== X-Gm-Message-State: AOJu0Yxu2Tkdm712G+NK5+T6+PN9wRwqimF7q0q7sqXa/BFntia/WWGs 1Pp6zKP7htY61uW9D+2szhsxTSEFLsjxulemTsLmzMM03Pu6b6Q11AbPe3Gnl9/K8frhMBXKOzh X3A== X-Google-Smtp-Source: AGHT+IGM1RqPY9m6u2FnGM4G2rMlhTQt8X483h3dO2rq3X6iXUUpq0Q9PCK7yg7CF2RKiSCROiTlEQ== X-Received: by 2002:a9d:7a8e:0:b0:6eb:7a3a:1218 with SMTP id l14-20020a9d7a8e000000b006eb7a3a1218mr11836498otn.29.1713778704488; Mon, 22 Apr 2024 02:38:24 -0700 (PDT) Received: from free.home ([2804:7f1:218b:5e2:c43b:e0c4:71a:241b]) by smtp.gmail.com with ESMTPSA id x3-20020a634a03000000b005dc3fc53f19sm7174187pga.7.2024.04.22.02.38.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 02:38:23 -0700 (PDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 43M9cDaq019935 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 22 Apr 2024 06:38:13 -0300 From: Alexandre Oliva To: gcc-patches@gcc.gnu.org Cc: Rainer Orth , Mike Stump , David Edelsohn , Segher Boessenkool , Kewen Lin Subject: [PATCH v2] add explicit ABI and align options to pr88233.c Organization: Free thinker, does not speak for AdaCore References: Date: Mon, 22 Apr 2024 06:38:13 -0300 In-Reply-To: (Alexandre Oliva's message of "Wed, 10 Mar 2021 08:00:59 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Ping? https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566530.html (modified version follows) We've observed failures of this test on powerpc configurations that default to different calling conventions and alignment requirements. Both settings are needed for the original expectations to be met. The test was later modified to have different expectations for big and little endian code generation. This patch restores the original codegen expectations, that, with the explicit options, don't vary any more. Regstrapped on x86_64-linux-gnu and ppc64el-linux-gnu. Also tested with gcc-13 on ppc64-vx7r2 and ppc-vx7r2. Ok to install? for gcc/testsuite/ChangeLog * gcc.target/powerpc/pr88233.c: Make some alignment strictness and calling conventions assumptions explicit. Restore uniform codegen expectations --- gcc/testsuite/gcc.target/powerpc/pr88233.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/gcc/testsuite/gcc.target/powerpc/pr88233.c b/gcc/testsuite/gcc.target/powerpc/pr88233.c index 27c73717a3f79..46a3ebfa28775 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr88233.c +++ b/gcc/testsuite/gcc.target/powerpc/pr88233.c @@ -1,5 +1,5 @@ /* { dg-require-effective-target lp64 } */ -/* { dg-options "-O2 -mdejagnu-cpu=power8" } */ +/* { dg-options "-O2 -mdejagnu-cpu=power8 -mno-strict-align -fpcc-struct-return" } */ typedef struct { double a[2]; } A; A @@ -9,6 +9,5 @@ foo (const A *a) } /* { dg-final { scan-assembler-not {\mmtvsr} } } */ -/* { dg-final { scan-assembler-times {\mlxvd2x\M} 1 { target { be } } } } */ -/* { dg-final { scan-assembler-times {\mstxvd2x\M} 1 { target { be } } } } */ -/* { dg-final { scan-assembler-times {\mlfd\M} 2 { target { le } } } } */ +/* { dg-final { scan-assembler-times {\mlxvd2x\M} 1 } } */ +/* { dg-final { scan-assembler-times {\mstxvd2x\M} 1 } } */