From patchwork Tue Dec 12 01:31:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 1874839 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=b8XQHUoW; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Sq1LL4yxqz20Gd for ; Tue, 12 Dec 2023 12:31:53 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BD0D938582AC for ; Tue, 12 Dec 2023 01:31:50 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id D288C3858C5F for ; Tue, 12 Dec 2023 01:31:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D288C3858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D288C3858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::230 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702344698; cv=none; b=l2ZpozYeNA7iCxKVF8sHR0rcNUS5yNNTYpV8RTrP9cKSJD/qYcACyBqLpiR/A7M8yZaFE2mhMJOFmAp6N0vkPdRGVWkxRK2LjqZJZ/MJ+Wf/awRbG7BS9cIT4Q8iU37hrzJ1//Q4z80/hWEohxcVF7KLyHq5JrNwyphOiq0RCnA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702344698; c=relaxed/simple; bh=m3VWn+yPNF/l1pEdIZDHdvRvX+nbwjQjE18Y9Pfjl3I=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=oKrtG3joq/WKjyHRZC2RSsZm7aUL7ATA6+nLjscAOXklRFsu8xQY2oInh9rRy+o9JvhZ4U5QBBzqU1faP5tI4JXLFz8+O2qic7qYrkmzN0vWCClm1VJnjlRUwmmtoy9R6b/W6rJ8eEvZm0GLvUTUfzmGE6sNbPC2OtfRmFunqHA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x230.google.com with SMTP id 5614622812f47-3ba00fe4e98so1776356b6e.2 for ; Mon, 11 Dec 2023 17:31:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1702344696; x=1702949496; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=75KcTjP8Wvc3ZEPTmP8wSehD7ueADqu3J2SWcObNxBw=; b=b8XQHUoWOF71TzV8cTnIaRA++/pZ1XGyinFS2CPot9nz1ZiAy5PmOpVoUljNZRcN5h XVCEvSsQDhl/uhkQQD1Aq4g3tm3sFCDDw1luFvMAdIrNnYn96+xPC5wREC27gBgcL3Is xgSm+fSOiRpki/aWgJkQG2fsy+wgiUpxXP580wVrlyuxMeeLvq5IVeQLXauGhLNocWF6 YN8aoR+IPXW2j+EdeXyIF1v0T6uYiRC87ncyH0x3D8qIt84CmP9S85ryVuaklkiqpoo+ AAfQWfoDf0+a0MLWeQ5mjfPzt3BoD+5YeN/GMxEX0pJ6oyCdPMrB/iCFfN/KOOx7GW8x /etw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702344696; x=1702949496; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=75KcTjP8Wvc3ZEPTmP8wSehD7ueADqu3J2SWcObNxBw=; b=JfecYmIoFqjiRKw0tZAdPx8RbtIeiMYs0logkPlLDO2+7vklOHJcl5LImQuVGNd4XD CFaaPgYVFpQELS+uf+0cnxRF/+uNnc9L9tr5BlHRzdqI/0ZimiWR70ccaZ87rq1mkWW5 rPYUW9LZNG2f6B4fJXh/sy66X6Yz1+mkLsSl9qrVVsfjJHxBf3pEE5FfIwy6TFNLEPOS 4Ynxi+73WB82Q8n/F1rlR2wv2Y5SmgLKb4chtKn4Z79LoQh/L0asqCNlhE0aVSbqpaxR hI7qeDEQbLE820OTmlYk+UGs2rPMxKcd0tjrdH7JQ35NhEdDgZVec6XNvc8QJgspLLge xBqA== X-Gm-Message-State: AOJu0YxbWSlcIWsCBI4FabXv41UiuqlxXksj5aEmOitI8Om7tmkmU/X2 MI9pEi8tC0/t095CbjqWZv6L+w== X-Google-Smtp-Source: AGHT+IFnk8Ir65iVrE16f4LEUvrgsfdx7ARsx70Xkj7L9zCAAUKL3omDku52oJdsjtezew5BYC0GAw== X-Received: by 2002:a05:6808:3022:b0:3b8:b3c2:797f with SMTP id ay34-20020a056808302200b003b8b3c2797fmr5870853oib.20.1702344696040; Mon, 11 Dec 2023 17:31:36 -0800 (PST) Received: from free.home ([2804:14c:4d1:44a5:f4d9:b7a4:4fb8:376f]) by smtp.gmail.com with ESMTPSA id jf18-20020a170903269200b001d087d2c42fsm7297904plb.24.2023.12.11.17.31.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 17:31:35 -0800 (PST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 3BC1VOQN396812 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 11 Dec 2023 22:31:25 -0300 From: Alexandre Oliva To: Joseph Myers Cc: Subject: [PATCH] multiflags: fix doc warning properly Organization: Free thinker, does not speak for AdaCore References: <6211faad-6c32-e92c-9de4-f476243e8ffa@codesourcery.com> Date: Mon, 11 Dec 2023 22:31:24 -0300 In-Reply-To: <6211faad-6c32-e92c-9de4-f476243e8ffa@codesourcery.com> (Joseph Myers's message of "Mon, 11 Dec 2023 20:56:24 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org On Dec 11, 2023, Joseph Myers wrote: > On Fri, 8 Dec 2023, Alexandre Oliva wrote: >> @@ -20589,7 +20589,7 @@ allocation before or after interprocedural optimization. >> This option enables multilib-aware @code{TFLAGS} to be used to build >> target libraries with options different from those the compiler is >> configured to use by default, through the use of specs (@xref{Spec >> -Files}) set up by compiler internals, by the target, or by builders at >> +Files}.) set up by compiler internals, by the target, or by builders at > The proper change in this context is to use @pxref instead of @xref. Oooh, nice! Thank you! Here's a presumably proper fix on top of the earlier one, then. Tested on x86_64-linux-gnu. Ok to install? Rather than a dubious fix for a dubious warning, namely adding a period after a parenthesized @xref because the warning demands it, use @pxref that is meant for exactly this case. Thanks to Joseph Myers for introducing me to it. for gcc/ChangeLog * doc/invoke.texi (multiflags): Drop extraneous period, use @pxref instead. --- gcc/doc/invoke.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 7d15cf94821e3..ce4bb025d5144 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -20588,8 +20588,8 @@ allocation before or after interprocedural optimization. @item -fmultiflags This option enables multilib-aware @code{TFLAGS} to be used to build target libraries with options different from those the compiler is -configured to use by default, through the use of specs (@xref{Spec -Files}.) set up by compiler internals, by the target, or by builders at +configured to use by default, through the use of specs (@pxref{Spec +Files}) set up by compiler internals, by the target, or by builders at configure time. Like @code{TFLAGS}, this allows the target libraries to be built for