diff mbox series

libstdc++: testsuite: require cmath for exp simd

Message ID orr13iefxh.fsf@lxoliva.fsfla.org
State New
Headers show
Series libstdc++: testsuite: require cmath for exp simd | expand

Commit Message

Alexandre Oliva June 21, 2022, 5:36 a.m. UTC 
simd_math.h assumes declarations for many C99 functions to be present,
that libstdc++ doesn't add to target systems that don't have them in
the C library.

Add the C99 math requirement to tests for simd features, so that they
don't fail because of limitations of the target C library.

Regstrapped on x86_64-linux-gnu, also tested with a cross to
aarch64-rtems6.  Ok to install?


for  libstdc++-v3/ChangeLog

	* testsuite/experimental/simd/standard_abi_usable.cc: Require
	cmath support.
	* testsuite/experimental/simd/standard_abi_usable_2.cc:
	Likewise.
---
 .../experimental/simd/standard_abi_usable.cc       |    1 +
 .../experimental/simd/standard_abi_usable_2.cc     |    1 +
 2 files changed, 2 insertions(+)

Comments

Alexandre Oliva June 27, 2022, 10:20 a.m. UTC | #1 
On Jun 21, 2022, Alexandre Oliva <oliva@adacore.com> wrote:

> 	* testsuite/experimental/simd/standard_abi_usable.cc: Require
> 	cmath support.
> 	* testsuite/experimental/simd/standard_abi_usable_2.cc:
> 	Likewise.

Ping?

https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596920.html
Jonathan Wakely June 27, 2022, 11:02 a.m. UTC | #2 
On Tue, 21 Jun 2022 at 06:38, Alexandre Oliva via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
>
> simd_math.h assumes declarations for many C99 functions to be present,
> that libstdc++ doesn't add to target systems that don't have them in
> the C library.
>
> Add the C99 math requirement to tests for simd features, so that they
> don't fail because of limitations of the target C library.
>
> Regstrapped on x86_64-linux-gnu, also tested with a cross to
> aarch64-rtems6.  Ok to install?

OK
diff mbox series

Patch

diff --git a/libstdc++-v3/testsuite/experimental/simd/standard_abi_usable.cc b/libstdc++-v3/testsuite/experimental/simd/standard_abi_usable.cc
index 4d7e6726951fe..1b686d9ca095b 100644
--- a/libstdc++-v3/testsuite/experimental/simd/standard_abi_usable.cc
+++ b/libstdc++-v3/testsuite/experimental/simd/standard_abi_usable.cc
@@ -1,5 +1,6 @@ 
 // { dg-options "-std=c++17 -fno-fast-math" }
 // { dg-do compile { target c++17 } }
+// { dg-require-cmath "" }
 
 // Copyright (C) 2020-2022 Free Software Foundation, Inc.
 //
diff --git a/libstdc++-v3/testsuite/experimental/simd/standard_abi_usable_2.cc b/libstdc++-v3/testsuite/experimental/simd/standard_abi_usable_2.cc
index a609adaf000b3..a0203d0b4238d 100644
--- a/libstdc++-v3/testsuite/experimental/simd/standard_abi_usable_2.cc
+++ b/libstdc++-v3/testsuite/experimental/simd/standard_abi_usable_2.cc
@@ -1,4 +1,5 @@ 
 // { dg-options "-std=c++17 -ffast-math" }
 // { dg-do compile }
+// { dg-require-cmath "" }
 
 #include "standard_abi_usable.cc"