From patchwork Wed Mar 24 06:55:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 1457691 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F4zWj1KDWz9sWF for ; Wed, 24 Mar 2021 17:55:13 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C59A7385040A; Wed, 24 Mar 2021 06:55:10 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id 71E35385BF9E for ; Wed, 24 Mar 2021 06:55:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 71E35385BF9E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oliva@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4DC2C116D49; Wed, 24 Mar 2021 02:55:09 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id BN-op-Rwj211; Wed, 24 Mar 2021 02:55:09 -0400 (EDT) Received: from free.home (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 16534116D3E; Wed, 24 Mar 2021 02:55:08 -0400 (EDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 12O6t29Z523828 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Mar 2021 03:55:02 -0300 From: Alexandre Oliva To: gcc-patches@gcc.gnu.org Subject: require et feature pie for PIE tests Organization: Free thinker, does not speak for AdaCore Date: Wed, 24 Mar 2021 03:55:02 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jan Hubicka Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Both of these tests fail on platforms that reject -fPIC/-fPIE altogether. Other tests that perform PIE compilation or linking require the pie feature, whether for -fpie/-fPIE compilation or for -pie linking. This patch annotates both tests with the required target feature. Regstrapped on x86_64-linux-gnu and cross-tested for x86_64-vx7r2 along with other patches, mostly for the testsuite. Ok to install? for gcc/testsuite/ChangeLog * gcc.target/i386/pr97313.c: Require effective target feature pie. * g++.target/i386/pr94185.C: Likewise. --- gcc/testsuite/g++.target/i386/pr94185.C | 1 + gcc/testsuite/gcc.target/i386/pr97313.c | 1 + 2 files changed, 2 insertions(+) diff --git a/gcc/testsuite/g++.target/i386/pr94185.C b/gcc/testsuite/g++.target/i386/pr94185.C index 2b3f7a1d676bd..ed3998010ae39 100644 --- a/gcc/testsuite/g++.target/i386/pr94185.C +++ b/gcc/testsuite/g++.target/i386/pr94185.C @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-options "-O2 -fPIE -fstack-protector-strong" } */ +/* { dg-require-effective-target pie } */ struct a { int b; diff --git a/gcc/testsuite/gcc.target/i386/pr97313.c b/gcc/testsuite/gcc.target/i386/pr97313.c index ef93cf1cca8f4..711766b413211 100644 --- a/gcc/testsuite/gcc.target/i386/pr97313.c +++ b/gcc/testsuite/gcc.target/i386/pr97313.c @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-options "-O2 -fPIE" } */ +/* { dg-require-effective-target pie } */ typedef struct { int unspecified : 1;