| Message ID | orjzfg4ayu.fsf_-_@lxoliva.fsfla.org |
|---|---|
| State | New |
| Headers | show |
| Series | testsuite: a few more hostedlib adjustments | expand |
On Sep 12, 2024, at 6:08 PM, Alexandre Oliva <oliva@adacore.com> wrote: > > On Sep 12, 2024, Mike Stump <mikestump@comcast.net> wrote: > >> On Sep 3, 2024, at 11:44 PM, Alexandre Oliva <oliva@adacore.com> wrote: >>> >>> Here's an updated and refreshed version that gets trunk built with >>> --disable-hosted-libstdcxx on x86_64-linux-gnu to not get any spurious >>> fails during in-tree testing. Also bootstrapped on hosted >>> x86_64-linux-gnu. Ok to install? > >> Ok. > > Thanks. There's more! Yeah, the hard issues are resolved, so follow on patches like this are now obvious. They follow the usual and standard practices now. Ok. So, my take, the people doing normal work, they are most likely to not understand or know when to do these sorts of changes. So, we should expect them to punt to a hosted person to find, discover and fix the fallout. Kinda like canadian cross work, or int16 work. Just a fair warning that you will be more an expert than most for these sort of issues. :-)
On Sep 13, 2024, Mike Stump <mikestump@comcast.net> wrote: > Yeah, the hard issues are resolved, so follow on patches like this are > now obvious. They follow the usual and standard practices now. Thanks. > So, we should expect them to punt to a hosted person to find, discover > and fix the fallout. Kinda like canadian cross work, or int16 > work. Just a fair warning that you will be more an expert than most > for these sort of issues. :-) Yeah, I sort of expected something like that. I'm still trying to decide whether to automated testing to catch regressions in this configuration, or existing ones will be able to catch them from now on. Presumably there are still arch-specific tests that will have to be covered as well, so it would be good if other platforms' automated testers were to cover them as well.
diff --git a/gcc/testsuite/g++.dg/coroutines/pr108620.C b/gcc/testsuite/g++.dg/coroutines/pr108620.C index e8016b9f8a233..22bf0c18bac45 100644 --- a/gcc/testsuite/g++.dg/coroutines/pr108620.C +++ b/gcc/testsuite/g++.dg/coroutines/pr108620.C @@ -1,3 +1,5 @@ +// { dg-skip-if "requires hosted libstdc++ for iostream" { ! hostedlib } } + // https://gcc.gnu.org/PR108620 #include <iostream> #include <memory> diff --git a/gcc/testsuite/g++.dg/ext/pragma-unroll-lambda-lto.C b/gcc/testsuite/g++.dg/ext/pragma-unroll-lambda-lto.C index 144c4c3269249..64cdf90f34d33 100644 --- a/gcc/testsuite/g++.dg/ext/pragma-unroll-lambda-lto.C +++ b/gcc/testsuite/g++.dg/ext/pragma-unroll-lambda-lto.C @@ -1,5 +1,6 @@ // { dg-do link { target c++11 } } // { dg-options "-O2 -flto -fdump-rtl-loop2_unroll" } +// { dg-skip-if "requires hosted libstdc++ for cstdlib rand" { ! hostedlib } } #include <cstdlib> diff --git a/gcc/testsuite/g++.dg/other/profile1.C b/gcc/testsuite/g++.dg/other/profile1.C index a4bf6b3d0fea7..99844373189e0 100644 --- a/gcc/testsuite/g++.dg/other/profile1.C +++ b/gcc/testsuite/g++.dg/other/profile1.C @@ -2,6 +2,7 @@ // { dg-do run } // { dg-require-profiling "" } // { dg-options "-fnon-call-exceptions -fprofile-arcs" } +// { dg-skip-if "requires hosted libstdc++ for string" { ! hostedlib } } #include <string>