From patchwork Fri Aug 21 07:57:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 509398 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 9E49B1402AC for ; Fri, 21 Aug 2015 17:57:54 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=yZCHCqH+; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; q=dns; s=default; b=IcrZO/xOOcpLDo4P H9ybqeIwSGnSCSrGraUMmGvGb38kykxDZ2nB27f72nGJQrunQyKzYKm0vXPGgDya l5cA26ltWmwbFrceHu7MICfuQDMR7BYnqgWkdEhkpa05fnjoD2bprL9bu2J7THD0 JLkaK1f3YtYesGChW4mprkNMcQQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=default; bh=qSH4rEv7uUPfZ7TOfEA/nB 740Us=; b=yZCHCqH+xAcAXyAY8xPfOVoigi3A1Nuq/wZ87MshwrwlGWI1ZdO0IZ 4oku7RK6v0yESuOQp+gSa8CY7d4NmMuuXwupD0zCgq5VlKf0R40bm5qbBfuhohCm QKGB0xWr6uw89xnP79d4e0CzNK55HmAPaee/zOitIr/5Mz59Eq+N4= Received: (qmail 33488 invoked by alias); 21 Aug 2015 07:57:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 32834 invoked by uid 89); 21 Aug 2015 07:57:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 21 Aug 2015 07:57:37 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 0A7BF91EA9; Fri, 21 Aug 2015 07:57:36 +0000 (UTC) Received: from freie.home (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7L7vWjg024415 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 21 Aug 2015 03:57:35 -0400 Received: from livre.home (livre.home [172.31.160.2]) by freie.home (8.14.8/8.14.8) with ESMTP id t7L7vJUh020806; Fri, 21 Aug 2015 04:57:19 -0300 From: Alexandre Oliva To: Andreas Schwab Cc: Christophe Lyon , GCC Patches , Patrick Marlier , Jeff Law , James Greenhalgh , "H.J. Lu" , Segher Boessenkool , Richard Biener , David Edelsohn , Eric Botcazou Subject: Re: [PR64164] drop copyrename, integrate into expand References: <20150723203112.GB27818@gate.crashing.org> <20150810082355.GA31149@arm.com> <55C8BFC3.3030603@redhat.com> Date: Fri, 21 Aug 2015 04:57:19 -0300 In-Reply-To: (Alexandre Oliva's message of "Wed, 19 Aug 2015 21:00:49 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 On Aug 19, 2015, Alexandre Oliva wrote: > I have verified in the expand dumps that both the gimple and the rtl > representation in the relevant parts of the code are identical, except > for the presence of debug stmts and insns. While comparing the dumps, I noticed -fdump-unnumbered-links no longer worked like it did back when I introduced it, with the very purpose of making it easier to compare dumps with and without debug insns. When the insn_uid was moved out of the u[] array, the indices that print-rtl tested to tell whether to omit the ids of the prev and next insns got off by one. This patch updates the test to match the current indices. Bootstrapping on ia64-linux-gnu. Ok to install? fix -fdump-unnumbered-links From: Alexandre Oliva for gcc/ChangeLog * print-rtl.c (print_rtx): Check the correct range for flag_dump_unnumbered_links to behave as documented. --- gcc/print-rtl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/print-rtl.c b/gcc/print-rtl.c index aacadbb..b541d83 100644 --- a/gcc/print-rtl.c +++ b/gcc/print-rtl.c @@ -550,7 +550,7 @@ print_rtx (const_rtx in_rtx) } if (flag_dump_unnumbered - || (flag_dump_unnumbered_links && (i == 1 || i == 2) + || (flag_dump_unnumbered_links && i <= 1 && (INSN_P (in_rtx) || NOTE_P (in_rtx) || LABEL_P (in_rtx) || BARRIER_P (in_rtx)))) fputs (" #", outfile);