From patchwork Thu Dec 21 06:08:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 1878880 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=Ag4tmgDF; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Swg4V6tFNz1ydg for ; Thu, 21 Dec 2023 17:09:30 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 043393861871 for ; Thu, 21 Dec 2023 06:09:29 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 886DF3858404 for ; Thu, 21 Dec 2023 06:09:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 886DF3858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 886DF3858404 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::630 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703138958; cv=none; b=ty7PEGbHOTw1TMaMmLBFL3f6sLWUE1e2A080kZ1/wiJ018kxf/m6AK8m7AcJZGTbEtt7Zp9IJG6YqlRvmhsuHbSBgDtXd6De703BfCUv0+X0riVmscd3mJ83/2l51jwwoRFp6+Q1zMPoT9RP6AjcEvUA//cfauiENWx3dd4jHOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703138958; c=relaxed/simple; bh=GCqCRhTuahklm+tYv+t5h9/EzQGC0Uw77rIFli4hNb0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=SLLwdbevHIcltVMPtr6BNs0a8oyu4MPKFTatXNbzzWyAmQa/Y1YHm7Nz29++sG4fZph0Vid6e6Soe5GseT8ZR4I24Vt4aabI3NJKwhv6nxBY1PH1qFLiBa/k3BlFj82pYnzrIkqTmNEaF/yWtJmZZEujkIVg/ybDTP8/J6c2aFw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1d3536cd414so3885015ad.2 for ; Wed, 20 Dec 2023 22:09:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1703138954; x=1703743754; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:organization:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=vHgxeJtNECMvkNzpBkcnrQke0grf1CvQ2/+XorW+6CM=; b=Ag4tmgDF5ErCc3OgJx0JBJy6dmqphDaMrrFcw7KJzfSeZ5YEKIE539KsI42VZaYugD puw+t4uuEkD+n+aZtia+U6Ghq6tp4S2b0WYNDT62I7lUVFFpdw01Sm7WpujjjVvtz/XG wldbPtWHZ5XXuFF9hLpzwmZCsSZSWY2agQ+Y50l1+TeHmkkyQQSJbWdpD2Rq1kRXhAYc 8ScK/VSUiZ3LdXVj2RZsn+ZPjR/muywIcRMR/LxQE410JpdZfVRKBy49kVD/ievtDkt3 N02bc0q5ilWjhtFxykZckhbAmOXptSDaQSzdj5nQ8TwthQiwr+xEymKjhSllSZ0WzaLX sRgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703138954; x=1703743754; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:organization:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vHgxeJtNECMvkNzpBkcnrQke0grf1CvQ2/+XorW+6CM=; b=pzYHTEs54ug+oRYHEpv63U9otYtnjmA+wsy2BBuxQ9yaqRlOEPmqn6RKaLBG3Kr8EA uPoGnpKpiu80x3LL/8lyukSIYdNGEwDT2nyym/B7Ic3wLEZFQiUBoZ+nVaLzVqAaV2no 4gDrxaVEz6VIk7eOaCVfV2c2imxjgdjVpLevkRx/g7Zbb9SPrQRNeXNsSUCQuX99dies 8VJ/sgrzNK7W/INqkx8rENdT41ENGzjwHEH8O44djrWgBqXIEb/TzMIr9Gkj2cuGTPfe LuAVpwdXC5RSDp3adUcvS0kWZZ1j7xJXyUwtOjJwXczRnUWYQrLliILLRM+Q+j3PYRHx u1xA== X-Gm-Message-State: AOJu0YwFrzpX0KGgDJzN1Ej8MpBeR3NA3B2ldTNUhYFlG7rB3+FjTXXB gDVG2vVl4OIL1k5M0XKGdYDsiw== X-Google-Smtp-Source: AGHT+IFGCorReX80RbS3eX+ikxpqcLkTGAWBZYUWAXkvkkjol+3YHf+8Py38c8RkyWjiLfav6lXs8g== X-Received: by 2002:a17:902:ce90:b0:1d3:df15:e032 with SMTP id f16-20020a170902ce9000b001d3df15e032mr4105978plg.21.1703138954640; Wed, 20 Dec 2023 22:09:14 -0800 (PST) Received: from free.home ([2804:7f1:2080:e946:8ecf:6d68:6986:b9a]) by smtp.gmail.com with ESMTPSA id iw17-20020a170903045100b001d3b7c5776asm739705plb.160.2023.12.20.22.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 22:09:13 -0800 (PST) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 3BL68wvY735533 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 21 Dec 2023 03:09:01 -0300 From: Alexandre Oliva To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: [PATCH 2/2 FYI] -finline-stringops: drop obsolete comment [PR112778] Organization: Free thinker, does not speak for AdaCore References: Date: Thu, 21 Dec 2023 03:08:56 -0300 In-Reply-To: (Richard Biener's message of "Mon, 11 Dec 2023 08:36:42 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org On Dec 11, 2023, Richard Biener wrote: > On Sat, Dec 9, 2023 at 8:05 AM Alexandre Oliva wrote: >> PR target/112778 >> * builtins.cc (can_store_by_multiple_pieces): New. >> (try_store_by_multiple_pieces): Call it. >> +/* Check that store_by_pieces allows BITS + LEN (so that we don't >> + expand something too unreasonably long), and every power of 2 in >> + BITS. It is assumed that LEN has already been tested by >> + itself. */ >> +static bool >> +can_store_by_multiple_pieces (unsigned HOST_WIDE_INT bits, When fixing the PR, I failed to remove the comment that raised the very concern that the PR confirmed, and that the earlier patch for the PR fixed. I'm checking this in as obvious. for gcc/ChangeLog PR target/112778 * builtins.cc (try_store_by_multiple_pieces): Drop obsolete comment. --- gcc/builtins.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gcc/builtins.cc b/gcc/builtins.cc index 0f64feeedbad6..125ea158ebfad 100644 --- a/gcc/builtins.cc +++ b/gcc/builtins.cc @@ -4491,10 +4491,6 @@ try_store_by_multiple_pieces (rtx to, rtx len, unsigned int ctz_len, if (max_len >> max_bits > min_len >> max_bits) tst_bits = max_bits; } - /* ??? Do we have to check that all powers of two lengths from - max_bits down to ctz_len pass can_store_by_pieces? As in, could - it possibly be that xlenest passes while smaller power-of-two - sizes don't? */ by_pieces_constfn constfun; void *constfundata;