From patchwork Sat Jul 21 10:25:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 172420 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 659402C0126 for ; Sat, 21 Jul 2012 20:25:37 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1343471138; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Received:From:To:Cc:Subject:References:Date: In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=MJSD3q07Exsp2VT49PwM 0cx2ox4=; b=I6Vy09NU9ynItJTmXNjS6/fRn3jLdO7j5p2EFeYvCI/IQexvB9a/ Kl29dJTYwren3KLLmv2b/Bn0/n/2Q8Y1brlkTrhoor3D4bBoZn6RcLXSlpqEFwIG xvlaoX/xgyS7DZuotfs6eZ/Zh3ou/pwexrHe+rZJ4aASLJVYWPuqZhg= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Received:From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Nl4zbLpyZVptsLgA2qh00L+7MUvgsbHkOmXlCX2ymB61BKbibUaLFxJBd98hfF BEvw7GOlNBV6l789CMe2RVNflMuzXDREXJAuQZdcu21vCOkwcYLYJ++P6YBxb+XQ lg6LN/4oGSuIdP96hTew9VyDtG9K+dDv2n6v/FWkG7oTc=; Received: (qmail 16629 invoked by alias); 21 Jul 2012 10:25:35 -0000 Received: (qmail 16608 invoked by uid 22791); 21 Jul 2012 10:25:34 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, SPF_HELO_PASS, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 21 Jul 2012 10:25:13 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6LAPCmB016196 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 21 Jul 2012 06:25:13 -0400 Received: from freie (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6LAPABO024773 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 21 Jul 2012 06:25:11 -0400 Received: from livre.localdomain (livre-to-gw.oliva.athome.lsd.ic.unicamp.br [172.31.160.19]) by freie (8.14.5/8.14.5) with ESMTP id q6LAP9U5005996; Sat, 21 Jul 2012 07:25:09 -0300 Received: from livre.localdomain (aoliva@localhost.localdomain [127.0.0.1]) by livre.localdomain (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id q6LAP600031541; Sat, 21 Jul 2012 07:25:06 -0300 Received: (from aoliva@localhost) by livre.localdomain (8.14.3/8.14.3/Submit) id q6LAP59r031539; Sat, 21 Jul 2012 07:25:05 -0300 From: Alexandre Oliva To: Richard Henderson Cc: GCC Patches Subject: Re: [PR52983] eliminate autoinc from debug_insn locs References: <5004737E.4000003@redhat.com> <5005DE7D.9070102@redhat.com> Date: Sat, 21 Jul 2012 07:25:05 -0300 In-Reply-To: <5005DE7D.9070102@redhat.com> (Richard Henderson's message of "Tue, 17 Jul 2012 14:51:57 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Jul 17, 2012, Richard Henderson wrote: > On 07/17/2012 02:36 PM, Alexandre Oliva wrote: >> http://gcc.gnu.org/ml/gcc-patches/2012-05/msg00300.html > ... except that post has patch 1 repeated as patch 3. > The actual patch 3 is missing. > That said, the first two patches are ok. Thanks. > Please repost #3. Sorry, I'd reposted it on Jul 2nd and forgot about the mistake in the earlier posting whose URL I sent you. Here's the 3rd patch again. for gcc/ChangeLog from Alexandre Oliva PR debug/52983 * valtrack.c (dead_debug_insert_temp): Use cleanup_auto_inc_dec. Index: gcc/valtrack.c =================================================================== --- gcc/valtrack.c.orig 2012-05-03 15:44:47.934692987 -0300 +++ gcc/valtrack.c 2012-05-03 15:44:52.540628548 -0300 @@ -385,7 +385,7 @@ dead_debug_insert_temp (struct dead_debu breg = NULL; /* Cool, it's the same REG, we can use SRC. */ else if (dest == reg) - breg = copy_rtx (src); + breg = cleanup_auto_inc_dec (src, VOIDmode); else if (REG_P (dest)) { /* Hmm... Something's fishy, we should be setting REG here. */ @@ -394,7 +394,8 @@ dead_debug_insert_temp (struct dead_debu /* Ok, it's the same (hardware) REG, but with a different mode, so SUBREG it. */ else - breg = lowpart_subreg (GET_MODE (reg), copy_rtx (src), + breg = lowpart_subreg (GET_MODE (reg), + cleanup_auto_inc_dec (src, VOIDmode), GET_MODE (dest)); } else if (GET_CODE (dest) == SUBREG) @@ -415,7 +416,8 @@ dead_debug_insert_temp (struct dead_debu breg = NULL; /* Yay, we can use SRC, just adjust its mode. */ else - breg = lowpart_subreg (GET_MODE (reg), copy_rtx (src), + breg = lowpart_subreg (GET_MODE (reg), + cleanup_auto_inc_dec (src, VOIDmode), GET_MODE (dest)); } /* Oh well, we're out of luck. */