From patchwork Tue Jul 23 02:32:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 1963518 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=MW0VsUM7; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WSh68654rz1yYm for ; Tue, 23 Jul 2024 12:33:36 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 95CE1386075E for ; Tue, 23 Jul 2024 02:33:34 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 913553858403 for ; Tue, 23 Jul 2024 02:33:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 913553858403 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 913553858403 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::629 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721701998; cv=none; b=lkY+nNllOaeNVEJTcBO6T7b0bUCQEONufWDGlWMXtxf0AT+OW0kp90gkYLVBrYqFHbsZ1RZCvoTq/jpPe82EmDO42o4BRsz474SWeNOBfNoVdhI1iBYy6dVgxHA/GWmLnzEeOoVA7e6FMZo3tNIyqptyI1geE2nQvzoPT/KJ/0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721701998; c=relaxed/simple; bh=czgITNRpwq6zsglBsaQkMn+/bSO5YMelcP9k5N0CUy0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=jJ3sYo2FF4FIWG9m6K+qPPSDAJ163NP06wu/e+ZId0qYw9ZnMQuISAlC6FVnhtHk+1YC8WpvcSTQ9em5FCwxGyoEcp2+wciSaXXXDWxXxqoZq1K5WZWnmp7eAj+XHKIUOtjtXnKPifS+AV2YrxQi6XC+E66snyzCZCM1ZMLokCY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1fc566ac769so1899155ad.1 for ; Mon, 22 Jul 2024 19:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1721701995; x=1722306795; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:date:organization:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=8eIiySuVxylfDU/MMn6Q9K/dBnfbt6iTyXCEYvvNf70=; b=MW0VsUM7ZfkOycUIJB4MtnGgHHwtCmNoxV0t/sTHWgA67I2D0UpH19Trk6MvgCR/F3 ILUz8arpJlHrAqE5SnrvRBHRcpmCYXXGRPri8nE39nAZKFwjTxb/1nH8HA/UeVhEtKEg k6e7VFxPoNZIVQBRERtzTXneZBZkUWsb9a/fNAA8M5/Bcvo/A8PQmNLRW3UPpjZ0Vaip H58dF9605vuRg011KMPZraOqDqBfKoymSFEXi3jf+MTSCEZn9ZerSUl0MOTFsMJ0sEFo xXRlYm/891R3ZCQd1S6cgoUP3e8BJQoZ+lEznwun472z0xhsccKvFHzaPzzdNmwd+nFY Oehg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721701995; x=1722306795; h=mime-version:user-agent:message-id:date:organization:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8eIiySuVxylfDU/MMn6Q9K/dBnfbt6iTyXCEYvvNf70=; b=sls9UijLAjfKl9BUFI5BiV5TWAgaODA//V1wHg7UKVtyA0WVLUHoLqim3h4xLN6gVJ 1iOFqFdetmEWUXexOabegh2p3NJ2hrPj5vUvFsK6GqtlmxipDU8QvhLLQ0LqrJ9O/A0v o3t66TaBNxjOGSAmqAkDojCxGiSWQTHkwN5vRIOEp8uLLgsz5vstxlUjjgF4LRDKOhVj EV8ppoRJzzavLdj68C0MRnaUSOzsY+oqb2DIRDTRy9dCfmqNBLv+M5L0i7ckCTKpTtWe EcwLQuot36lMwe9i8oBumtUVjICn/4UZhFsMTyy3m4GEtzqegzFI8Mx2Z2sCjBnQeXZf ZmMQ== X-Gm-Message-State: AOJu0YxmZfdHJO5G9S55rCE7iNBHA9BqttSlUtj5mj7wWqsXPM0BUtTx He3ujbKMNRlvBpJF81cJPrf1muZ5Q3sTbTUKB0hNCk2LyAB2naNPv5sehCOVtNGeB0BLsWsPlsh nWA== X-Google-Smtp-Source: AGHT+IFYQzF4cQ8PGd1mBJ4EQCgY+KNT8EOrGsfl+yfbCmGBG7dTWElw4dTHzVQ8D+3zyudD+3oA3A== X-Received: by 2002:a17:902:e54f:b0:1fb:5c3d:b8ea with SMTP id d9443c01a7336-1fd745210fdmr65444055ad.13.1721701995145; Mon, 22 Jul 2024 19:33:15 -0700 (PDT) Received: from free.home ([2804:7f1:218a:fb51:97a8:e640:3221:cc12]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fd80f388ebsm50623475ad.88.2024.07.22.19.33.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 19:33:14 -0700 (PDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 46N2WurN537325 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 22 Jul 2024 23:33:01 -0300 From: Alexandre Oliva To: gcc-patches@gcc.gnu.org Cc: Kewen Lin , Xionghu Luo Subject: [PATCH FYI] [powerpc] [testsuite] reorder dg directives [PR106069] Organization: Free thinker, does not speak for AdaCore Date: Mon, 22 Jul 2024 23:32:56 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org The dg-do directive appears after dg-require-effective-target in g++.target/powerpc/pr106069.C. That doesn't work the way that was presumably intended. Both of these directives set dg-do-what, but dg-do does so fully and unconditionally, overriding any decisions recorded there by earlier directives. Reorder the directives more canonically, so that both take effect. Tested with gcc-13 targeting ppc64-vx7r2 on altivec-less hardware. I'm installing it as obvious, and backporting to the branches that have the inconsistent testcase. for gcc/testsuite/ChangeLog PR target/106069 * g++.target/powerpc/pr106069.C: Reorder dg directives. --- gcc/testsuite/g++.target/powerpc/pr106069.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/g++.target/powerpc/pr106069.C b/gcc/testsuite/g++.target/powerpc/pr106069.C index 537207d2fe838..826379a4479a8 100644 --- a/gcc/testsuite/g++.target/powerpc/pr106069.C +++ b/gcc/testsuite/g++.target/powerpc/pr106069.C @@ -1,6 +1,6 @@ +/* { dg-do run } */ /* { dg-options "-O -fno-tree-forwprop -maltivec" } */ /* { dg-require-effective-target vmx_hw } */ -/* { dg-do run } */ typedef __attribute__ ((altivec (vector__))) unsigned native_simd_type;