From patchwork Sun Nov 5 18:46:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 1859583 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SNk3g3pvzz1yQL for ; Mon, 6 Nov 2023 05:46:55 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 952A73856961 for ; Sun, 5 Nov 2023 18:46:53 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 555843856DDC for ; Sun, 5 Nov 2023 18:46:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 555843856DDC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 555843856DDC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699210003; cv=none; b=QevBcMCgU1yY0VBjISYe5dk7lcfEFWDaj0DusZSuDprJlJ+1wShfUf0LY9jdVbKKgL9MKfoRqkFVnCqGZXbSt69EeQeWgEYBmhiSDEuS9VXzHErKoQzakMnr1gxL+aNPEU/HfD+11He7AYPK3EKr8hMCn0RI+WRWFmW45u9GIpg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699210003; c=relaxed/simple; bh=uaTo/AvwLzbmBYtyTmy6hqI/VOXIzKPDqR3Vs0yXMPA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Y5fCfQBRPaIWZf5u55QXdcbkWzjd83jTEKuRSW4/1BbEbGIdnuzjDEpvT22gvevifh4LlTLlzmtJAvYULhXFSvSRP981ddPWGf5n4whFyByesFvg7S2Ik3hU0Ot55BvPwQ+GDW8M7rj5x+SmOy2Sgbku8dd5s6Rof0NMrzeRmGk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C077AC15; Sun, 5 Nov 2023 10:47:25 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7D86A3F703; Sun, 5 Nov 2023 10:46:41 -0800 (PST) From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, jlaw@ventanamicro.com, richard.sandiford@arm.com Cc: jlaw@ventanamicro.com Subject: [PATCH 02/12] mode-switching: Add note problem References: Date: Sun, 05 Nov 2023 18:46:40 +0000 In-Reply-To: (Richard Sandiford's message of "Sun, 05 Nov 2023 18:45:29 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Spam-Status: No, score=-23.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org optimize_mode_switching uses REG_DEAD notes to track register liveness, but it failed to tell DF to calculate up-to-date notes. Noticed by inspection. I don't have a testcase that fails because of this. gcc/ * mode-switching.cc (optimize_mode_switching): Call df_note_add_problem. --- I was tempted to apply this as obvious, but wasn't sure if I was missing something. gcc/mode-switching.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/mode-switching.cc b/gcc/mode-switching.cc index c3e4d24de9b..8577069bde1 100644 --- a/gcc/mode-switching.cc +++ b/gcc/mode-switching.cc @@ -541,6 +541,7 @@ optimize_mode_switching (void) pre_exit = create_pre_exit (n_entities, entity_map, num_modes); } + df_note_add_problem (); df_analyze (); /* Create the bitmap vectors. */