From patchwork Thu Dec 21 10:21:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 1878991 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SwmgQ6V2Qz1ySd for ; Thu, 21 Dec 2023 21:21:38 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EB59A3858412 for ; Thu, 21 Dec 2023 10:21:36 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 1B2343858D35 for ; Thu, 21 Dec 2023 10:21:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B2343858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1B2343858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703154086; cv=none; b=fsTI2U8W7f1JsUZEjrYr7DGQC3fg7jS8JaE9u7qirjyUu/i5SViFx+SyBT660V4yp8U68ILH6plqlCmWUxXnAjjpj1xf5sLkJ6mZ6j57IaaXTFuu0Q5HDohk3V1k0M4DvRjye7PgMQNjz4RlW6xHDr+SPdzDacrI5heR7nsFWbs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703154086; c=relaxed/simple; bh=yIxh2jSDfrXl+HlcqZJB3KqvzbIj6ym4QX5S+Tm3zFg=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=f2inBaxrOhXfXSM9irl/Frb66U0iKqHzwzITQ9FXCVVAer9V0aXCS+j5gFpVU7Yf3Ar4dWjFkxjgfCNdHqMabVWhq0bzvMeyJoo/qopDJ8Kwc0rUm8LcD8tZ2o4teRzMM8r98H1+DJ6Zchj7hRaHNuc0tk8NAZ6iXCXccGUZ5ZQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 85EAB2F4 for ; Thu, 21 Dec 2023 02:22:09 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 566243F5A1 for ; Thu, 21 Dec 2023 02:21:24 -0800 (PST) From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: [pushed] aarch64: Fix cut-&-pasto in early RA pass [PR112948] Date: Thu, 21 Dec 2023 10:21:23 +0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Spam-Status: No, score=-21.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org As the PR notes, there was a cut-&-pasto in find_strided_accesses. I've not been able to find a testcase that shows the problem. Tested on aarch64-linux-gnu & pushed. Richard gcc/ PR target/112948 * config/aarch64/aarch64-early-ra.cc (find_strided_accesses): Fix cut-&-pasto. --- gcc/config/aarch64/aarch64-early-ra.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/config/aarch64/aarch64-early-ra.cc b/gcc/config/aarch64/aarch64-early-ra.cc index 484db94513d..24415bd829c 100644 --- a/gcc/config/aarch64/aarch64-early-ra.cc +++ b/gcc/config/aarch64/aarch64-early-ra.cc @@ -2072,8 +2072,8 @@ early_ra::find_strided_accesses () if (group1->strided_polarity) group2->strided_polarity = group1->strided_polarity * pref; - else if (group1->strided_polarity) - group2->strided_polarity = group1->strided_polarity * pref; + else if (group2->strided_polarity) + group1->strided_polarity = group2->strided_polarity * pref; else { group1->strided_polarity = 1;