From patchwork Thu Apr 8 14:08:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 1463827 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=NpnHTKsm; dkim-atps=neutral Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FGNQT6bHsz9sWX for ; Fri, 9 Apr 2021 00:08:17 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A6FB53945C08; Thu, 8 Apr 2021 14:08:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A6FB53945C08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1617890894; bh=n1rnZFaMOb6JmSH/5h3Y7W7zH+tfuC8kszqnUdEXag4=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=NpnHTKsm2SVrwjkrwY2av3dFITZMpq7fIQSaFz5N9AGYmKcXZKY9BGaSCK3pDemiR 5CeldOriqZ1oLKwd7BDL/CpAVdrMmQO6pc0iFLVbuWB5AX/OV4Q70oylYaYgd0wbYg +A8cX8AQ+0CzJSKmw0CUhdMudazxGsVcipUfSHA0= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id E5AF3394443F for ; Thu, 8 Apr 2021 14:08:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E5AF3394443F Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A423CD6E for ; Thu, 8 Apr 2021 07:08:11 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.126]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C5333F694 for ; Thu, 8 Apr 2021 07:08:11 -0700 (PDT) To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: [PATCH] testsuite: Add -mbig-endian stdint.h requirement Date: Thu, 08 Apr 2021 15:08:10 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Sandiford via Gcc-patches From: Richard Sandiford Reply-To: Richard Sandiford Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Some AArch64 tests force -mbig-endian and indirectly include stdint.h. However, not all OSes support both endiannesses, leading to: FAIL: gcc.target/aarch64/advsimd-intrinsics/bf16_get-be.c -O0 (test for excess errors) UNRESOLVED: gcc.target/aarch64/advsimd-intrinsics/bf16_get-be.c -O1 check-function-bodies test_vget_high_bf16 UNRESOLVED: gcc.target/aarch64/advsimd-intrinsics/bf16_get-be.c -O1 check-function-bodies test_vget_low_bf16 etc. This patch adds an (admittedly special-purpose) target selector for this. Tested on aarch64-linux-gnu. It doesn't really count as AArch64-specific so: OK to install? Richard gcc/ * doc/sourcebuild.texi (stdint_types_mbig_endian): Document. gcc/testsuite/ * lib/target-supports.exp (check_effective_target_stdint_types_mbig_endian): New proc. * gcc.target/aarch64/advsimd-intrinsics/bf16_get-be.c: Require stdint_types_mbig_endian. * gcc.target/aarch64/advsimd-intrinsics/bfdot-2.c: Likewise. * gcc.target/aarch64/advsimd-intrinsics/vdot-3-2.c: Likewise. --- gcc/doc/sourcebuild.texi | 4 ++++ .../aarch64/advsimd-intrinsics/bf16_get-be.c | 1 + .../gcc.target/aarch64/advsimd-intrinsics/bfdot-2.c | 1 + .../gcc.target/aarch64/advsimd-intrinsics/vdot-3-2.c | 1 + gcc/testsuite/lib/target-supports.exp | 12 ++++++++++++ 5 files changed, 19 insertions(+) diff --git a/gcc/doc/sourcebuild.texi b/gcc/doc/sourcebuild.texi index 0104916e660..b0001247795 100644 --- a/gcc/doc/sourcebuild.texi +++ b/gcc/doc/sourcebuild.texi @@ -2447,6 +2447,10 @@ Target has the basic signed and unsigned C types in @code{stdint.h}. This will be obsolete when GCC ensures a working @code{stdint.h} for all targets. +@item stdint_types_mbig_endian +Target accepts the option @option{-mbig-endian} and @code{stdint.h} +can be included without error when @option{-mbig-endian} is passed. + @item stpcpy Target provides @code{stpcpy} function. diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bf16_get-be.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bf16_get-be.c index bd9bb110974..cd27098e63e 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bf16_get-be.c +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bf16_get-be.c @@ -1,4 +1,5 @@ /* { dg-do assemble { target { aarch64*-*-* } } } */ +/* { dg-require-effective-target stdint_types_mbig_endian } */ /* { dg-require-effective-target arm_v8_2a_bf16_neon_ok } */ /* { dg-add-options arm_v8_2a_bf16_neon } */ /* { dg-additional-options "-mbig-endian -save-temps" } */ diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfdot-2.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfdot-2.c index 58bdee5ac9d..ae0a953f7b4 100755 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfdot-2.c +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfdot-2.c @@ -1,4 +1,5 @@ /* { dg-do assemble { target { aarch64*-*-* } } } */ +/* { dg-require-effective-target stdint_types_mbig_endian } */ /* { dg-require-effective-target arm_v8_2a_bf16_neon_ok } */ /* { dg-add-options arm_v8_2a_bf16_neon } */ /* { dg-additional-options "-mbig-endian --save-temps" } */ diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vdot-3-2.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vdot-3-2.c index 96bca2356e4..61c7c51f5ec 100755 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vdot-3-2.c +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vdot-3-2.c @@ -1,4 +1,5 @@ /* { dg-do assemble { target { aarch64*-*-* } } } */ +/* { dg-require-effective-target stdint_types_mbig_endian } */ /* { dg-require-effective-target arm_v8_2a_i8mm_ok } */ /* { dg-add-options arm_v8_2a_i8mm } */ /* { dg-additional-options "-mbig-endian -save-temps" } */ diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 1230d194215..ad323107f2e 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -8254,6 +8254,18 @@ proc check_effective_target_stdint_types { } { }] } +# Like check_effective_target_stdint_types, but test what happens when +# -mbig-endian is passed. This test only makes sense on targets that +# support -mbig-endian; it will fail elsewhere. + +proc check_effective_target_stdint_types_mbig_endian { } { + return [check_no_compiler_messages stdint_types_mbig_endian assembly { + #include + int8_t a; int16_t b; int32_t c; int64_t d; + uint8_t e; uint16_t f; uint32_t g; uint64_t h; + } "-mbig-endian"] +} + # Return 1 if target has the basic signed and unsigned types in # , 0 otherwise. This is for tests that GCC's notions of # these types agree with those in the header, as some systems have