From patchwork Fri Sep 28 17:42:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 187846 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 392AB2C00C2 for ; Sat, 29 Sep 2012 03:43:10 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1349458991; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:From:To:Subject:Date:Message-ID:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=4LUV41cBB0yx6/qipDVYQKC9eN0=; b=az8yLHNSm1AAKFE ThTeFDBmSeLb/3X9KDl3wnfkJB+T4TC1+3HcnPRxmCa82IBiDfDmWNw7Kv8SjudQ Gx8fSEzyghlYPNpTpT1TCbVWimqpX1PBdxiUuDArmq1afHaSH8fVhNbYU1M5zW5h 6H/i8L4Lx0sgqm7kAgmlT5Tvox5A= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:Received:Received:Received:From:To:Subject:Date:Message-ID:User-Agent:MIME-Version:Content-Type:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=UtNijyF6Ywh2jauxaFqL2Vwi12KGkPtuwNKdYpoaOQZoj6uLDDHYiQ1iEQx3Lx kNMOudopgDlsIiLRMBzxJKHq6HkExu4diyiejA3bubk5+jiOY6LqU4NGsr/RdmK2 nDTRtmcAqj0G1U8xZ4DmN3Jc6VBOO1Uo87CladQsTNStI=; Received: (qmail 10664 invoked by alias); 28 Sep 2012 17:43:07 -0000 Received: (qmail 10656 invoked by uid 22791); 28 Sep 2012 17:43:06 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from mail-pa0-f47.google.com (HELO mail-pa0-f47.google.com) (209.85.220.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Sep 2012 17:43:01 +0000 Received: by padfa11 with SMTP id fa11so2570485pad.20 for ; Fri, 28 Sep 2012 10:43:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type:x-gm-message-state; bh=SihPXqLZ3QAfVdhoJMy1/bFAA9mfipQ0GrgE9+elZHI=; b=d4rsqj+tsDO5bJlRb+HtKVIuDOpt+B30lgY6p5xKPLXjYp1W63Qv7614TcyI6cOM99 0pQH6dtdvS575cth3kT/JG1li64HJD9JgAQyGdpoxIk5xPKKZir9CftBC1Xl6rnPdm2F iJmU6KzrsqBm4U6XJ2w56hNpb/pXK/Jqd6/iA7PO0jY0hlluAWGpjQFDXjpCco/i3m3R eJpXLqis5TEMpA3zkWT0/+KPdY4RIZywH/Y4e48tZLIEqpHDsYWUKWE8UzfoJWgZY6r/ kg7tWsbvAjVNNJNtjis9x7rIkbeqPvDKMApFXZ0+VbpdlpYPDaJInHxMZ7LM2fmzzmQk MwSA== Received: by 10.66.85.233 with SMTP id k9mr18858656paz.73.1348854180527; Fri, 28 Sep 2012 10:43:00 -0700 (PDT) Received: by 10.66.85.233 with SMTP id k9mr18858643paz.73.1348854180414; Fri, 28 Sep 2012 10:43:00 -0700 (PDT) Received: from coign.google.com ([2620:0:1000:147c:224:d7ff:fe8f:f634]) by mx.google.com with ESMTPS id wl4sm5908627pbc.17.2012.09.28.10.42.59 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 28 Sep 2012 10:42:59 -0700 (PDT) From: Ian Lance Taylor To: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: libgo patch committed: runtime.Caller should succeed without debug info Date: Fri, 28 Sep 2012 10:42:58 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-Gm-Message-State: ALoCoQlUDUQkgpbM+Hg7CV8gBQunBlad9kVpUYEM8BFUc0hA+TWdU+ovjwc/Nf158k0raPXlKnxT34qkyz1vv9BwMuoBhnjVn8NjtVCA5LN67ZaiESdQhm0XIxcV6G28Vxkjd0xd3Vm1Z3IhgoJ6vkQttM9AQkacyqHZmrMJb9RG9YLYNBh9MNxMbpyIGN6JqL+CvDfn2pTz X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Further testing uncovered a small bug in the change to use the libbacktrace library. The runtime.Caller function should succeed if we get the PC, even if we don't have any debug info. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r dff305030965 libgo/runtime/go-caller.c --- a/libgo/runtime/go-caller.c Fri Sep 28 07:26:19 2012 -0700 +++ b/libgo/runtime/go-caller.c Fri Sep 28 08:49:33 2012 -0700 @@ -172,7 +172,8 @@ if (n < 1) return ret; ret.pc = pc; - ret.ok = __go_file_line (pc, &fn, &ret.file, &ret.line); + __go_file_line (pc, &fn, &ret.file, &ret.line); + ret.ok = 1; return ret; }