| Message ID | fa5ee1a7-e65f-42de-9718-ee5fdb7be7e4@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | rs6000, built-in cleanup patch series | expand |
Hi, on 2024/4/20 05:16, Carl Love wrote: > > rs6000, Remove __builtin_vsx_cmple* builtins > > The built-ins __builtin_vsx_cmple_u16qi, __builtin_vsx_cmple_u2di, > __builtin_vsx_cmple_u4si and __builtin_vsx_cmple_u8hi should take > unsigned arguments and return an unsigned result. The current definitions > take signed arguments and return signed results which is incorrect. > > The signed and unsigned versions of __builtin_vsx_cmple* are not > documented in extend.texi. Also there are no test cases for the > built-ins. > > Users can use the existing vec_cmple as PVIPR defines instead of > __builtin_vsx_cmple_u16qi, __builtin_vsx_cmple_u2di, > __builtin_vsx_cmple_u4si and __builtin_vsx_cmple_u8hi, > __builtin_vsx_cmple_16qi, __builtin_vsx_cmple_2di, > __builtin_vsx_cmple_4si and __builtin_vsx_cmple_8hi, > __builtin_altivec_cmple_1ti, __builtin_altivec_cmple_u1ti. > > Hence these built-ins are redundant and are removed by this patch. OK for trunk, thanks. BR, Kewen > > gcc/ChangeLog: > * config/rs6000/rs6000-builtin.cc (RS6000_BIF_CMPLE_16QI, > RS6000_BIF_CMPLE_U16QI, RS6000_BIF_CMPLE_8HI, > RS6000_BIF_CMPLE_U8HI, RS6000_BIF_CMPLE_4SI, RS6000_BIF_CMPLE_U4SI, > RS6000_BIF_CMPLE_2DI, RS6000_BIF_CMPLE_U2DI, RS6000_BIF_CMPLE_1TI, > RS6000_BIF_CMPLE_U1TI): Remove case statements. > config/rs6000/rs6000-builtins.def (__builtin_vsx_cmple_16qi, > __builtin_vsx_cmple_2di, __builtin_vsx_cmple_4si, > __builtin_vsx_cmple_8hi, __builtin_vsx_cmple_u16qi, > __builtin_vsx_cmple_u2di, __builtin_vsx_cmple_u4si, > __builtin_vsx_cmple_u8hi): Remove buit-in definitions. > --- > gcc/config/rs6000/rs6000-builtin.cc | 13 ------------ > gcc/config/rs6000/rs6000-builtins.def | 30 --------------------------- > 2 files changed, 43 deletions(-) > > diff --git a/gcc/config/rs6000/rs6000-builtin.cc b/gcc/config/rs6000/rs6000-builtin.cc > index 320affd79e3..ac9f16fe51a 100644 > --- a/gcc/config/rs6000/rs6000-builtin.cc > +++ b/gcc/config/rs6000/rs6000-builtin.cc > @@ -2027,19 +2027,6 @@ rs6000_gimple_fold_builtin (gimple_stmt_iterator *gsi) > fold_compare_helper (gsi, GT_EXPR, stmt); > return true; > > - case RS6000_BIF_CMPLE_16QI: > - case RS6000_BIF_CMPLE_U16QI: > - case RS6000_BIF_CMPLE_8HI: > - case RS6000_BIF_CMPLE_U8HI: > - case RS6000_BIF_CMPLE_4SI: > - case RS6000_BIF_CMPLE_U4SI: > - case RS6000_BIF_CMPLE_2DI: > - case RS6000_BIF_CMPLE_U2DI: > - case RS6000_BIF_CMPLE_1TI: > - case RS6000_BIF_CMPLE_U1TI: > - fold_compare_helper (gsi, LE_EXPR, stmt); > - return true; > - > /* flavors of vec_splat_[us]{8,16,32}. */ > case RS6000_BIF_VSPLTISB: > case RS6000_BIF_VSPLTISH: > diff --git a/gcc/config/rs6000/rs6000-builtins.def b/gcc/config/rs6000/rs6000-builtins.def > index 3bc7fed6956..7c36976a089 100644 > --- a/gcc/config/rs6000/rs6000-builtins.def > +++ b/gcc/config/rs6000/rs6000-builtins.def > @@ -1337,30 +1337,6 @@ > const vss __builtin_vsx_cmpge_u8hi (vus, vus); > CMPGE_U8HI vector_nltuv8hi {} > > - const vsc __builtin_vsx_cmple_16qi (vsc, vsc); > - CMPLE_16QI vector_ngtv16qi {} > - > - const vsll __builtin_vsx_cmple_2di (vsll, vsll); > - CMPLE_2DI vector_ngtv2di {} > - > - const vsi __builtin_vsx_cmple_4si (vsi, vsi); > - CMPLE_4SI vector_ngtv4si {} > - > - const vss __builtin_vsx_cmple_8hi (vss, vss); > - CMPLE_8HI vector_ngtv8hi {} > - > - const vsc __builtin_vsx_cmple_u16qi (vsc, vsc); > - CMPLE_U16QI vector_ngtuv16qi {} > - > - const vsll __builtin_vsx_cmple_u2di (vsll, vsll); > - CMPLE_U2DI vector_ngtuv2di {} > - > - const vsi __builtin_vsx_cmple_u4si (vsi, vsi); > - CMPLE_U4SI vector_ngtuv4si {} > - > - const vss __builtin_vsx_cmple_u8hi (vss, vss); > - CMPLE_U8HI vector_ngtuv8hi {} > - > const vd __builtin_vsx_concat_2df (double, double); > CONCAT_2DF vsx_concat_v2df {} > > @@ -3117,12 +3093,6 @@ > const vbq __builtin_altivec_cmpge_u1ti (vuq, vuq); > CMPGE_U1TI vector_nltuv1ti {} > > - const vbq __builtin_altivec_cmple_1ti (vsq, vsq); > - CMPLE_1TI vector_ngtv1ti {} > - > - const vbq __builtin_altivec_cmple_u1ti (vuq, vuq); > - CMPLE_U1TI vector_ngtuv1ti {} > - > const unsigned long long __builtin_altivec_cntmbb (vuc, const int<1>); > VCNTMBB vec_cntmb_v16qi {} >
diff --git a/gcc/config/rs6000/rs6000-builtin.cc b/gcc/config/rs6000/rs6000-builtin.cc index 320affd79e3..ac9f16fe51a 100644 --- a/gcc/config/rs6000/rs6000-builtin.cc +++ b/gcc/config/rs6000/rs6000-builtin.cc @@ -2027,19 +2027,6 @@ rs6000_gimple_fold_builtin (gimple_stmt_iterator *gsi) fold_compare_helper (gsi, GT_EXPR, stmt); return true; - case RS6000_BIF_CMPLE_16QI: - case RS6000_BIF_CMPLE_U16QI: - case RS6000_BIF_CMPLE_8HI: - case RS6000_BIF_CMPLE_U8HI: - case RS6000_BIF_CMPLE_4SI: - case RS6000_BIF_CMPLE_U4SI: - case RS6000_BIF_CMPLE_2DI: - case RS6000_BIF_CMPLE_U2DI: - case RS6000_BIF_CMPLE_1TI: - case RS6000_BIF_CMPLE_U1TI: - fold_compare_helper (gsi, LE_EXPR, stmt); - return true; - /* flavors of vec_splat_[us]{8,16,32}. */ case RS6000_BIF_VSPLTISB: case RS6000_BIF_VSPLTISH: diff --git a/gcc/config/rs6000/rs6000-builtins.def b/gcc/config/rs6000/rs6000-builtins.def index 3bc7fed6956..7c36976a089 100644 --- a/gcc/config/rs6000/rs6000-builtins.def +++ b/gcc/config/rs6000/rs6000-builtins.def @@ -1337,30 +1337,6 @@ const vss __builtin_vsx_cmpge_u8hi (vus, vus); CMPGE_U8HI vector_nltuv8hi {} - const vsc __builtin_vsx_cmple_16qi (vsc, vsc); - CMPLE_16QI vector_ngtv16qi {} - - const vsll __builtin_vsx_cmple_2di (vsll, vsll); - CMPLE_2DI vector_ngtv2di {} - - const vsi __builtin_vsx_cmple_4si (vsi, vsi); - CMPLE_4SI vector_ngtv4si {} - - const vss __builtin_vsx_cmple_8hi (vss, vss); - CMPLE_8HI vector_ngtv8hi {} - - const vsc __builtin_vsx_cmple_u16qi (vsc, vsc); - CMPLE_U16QI vector_ngtuv16qi {} - - const vsll __builtin_vsx_cmple_u2di (vsll, vsll); - CMPLE_U2DI vector_ngtuv2di {} - - const vsi __builtin_vsx_cmple_u4si (vsi, vsi); - CMPLE_U4SI vector_ngtuv4si {} - - const vss __builtin_vsx_cmple_u8hi (vss, vss); - CMPLE_U8HI vector_ngtuv8hi {} - const vd __builtin_vsx_concat_2df (double, double); CONCAT_2DF vsx_concat_v2df {} @@ -3117,12 +3093,6 @@ const vbq __builtin_altivec_cmpge_u1ti (vuq, vuq); CMPGE_U1TI vector_nltuv1ti {} - const vbq __builtin_altivec_cmple_1ti (vsq, vsq); - CMPLE_1TI vector_ngtv1ti {} - - const vbq __builtin_altivec_cmple_u1ti (vuq, vuq); - CMPLE_U1TI vector_ngtuv1ti {} - const unsigned long long __builtin_altivec_cntmbb (vuc, const int<1>); VCNTMBB vec_cntmb_v16qi {}