From patchwork Thu Jul 16 06:51:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kewen.Lin" X-Patchwork-Id: 1330030 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=C7vbY1H8; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4B6lKR1PLdz9s1x for ; Thu, 16 Jul 2020 16:51:37 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B7974383F86F; Thu, 16 Jul 2020 06:51:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B7974383F86F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1594882294; bh=2vtTwkRpy9NFQ6TkjYyDQh0F83RuSg4jN/aa5FDxYsU=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=C7vbY1H80xhsWrbwTNwFp2HqzJ3cIHFb79TUrBC7eTOiyjiPTu/NBFUpY6X/dc+mK MOs+1eaQdfWGcALknFK+4MixcNCRVb7tw4+bReZ0UB5+luP1iq5VGW2jVebbKTT8nJ SpXURB97jUS+DdEZO3cYMb34XhnabRtUdQKg0tHQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id D98643857C48 for ; Thu, 16 Jul 2020 06:51:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D98643857C48 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06G6WhVY170761; Thu, 16 Jul 2020 02:51:31 -0400 Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com with ESMTP id 32a45b67w3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Jul 2020 02:51:31 -0400 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 06G6lgj1028495; Thu, 16 Jul 2020 06:51:29 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma06fra.de.ibm.com with ESMTP id 328rbqsf9g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Jul 2020 06:51:29 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 06G6pQ4T55050344 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Jul 2020 06:51:26 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0CE18A4053; Thu, 16 Jul 2020 06:51:26 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CFB3AA404D; Thu, 16 Jul 2020 06:51:24 +0000 (GMT) Received: from KewenLins-MacBook-Pro.local (unknown [9.200.39.79]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 16 Jul 2020 06:51:24 +0000 (GMT) To: GCC Patches Subject: [PATCH] testsuite/rs6000: Add option to ignore vect cost model Message-ID: Date: Thu, 16 Jul 2020 14:51:23 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-16_01:2020-07-15, 2020-07-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 impostorscore=0 mlxscore=0 bulkscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007160047 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Kewen.Lin via Gcc-patches" From: "Kewen.Lin" Reply-To: "Kewen.Lin" Cc: Bill Schmidt , Segher Boessenkool Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Hi, In my testing with cost tweaking for vector with length, I found two cases below didn't get the expected output. Since the expected instructions reply on the vectorization occurrence, we don't expect vectorization gets disabled by cost model. To make it not fragile, the fix is to force it without vect cost model. Is it ok for trunk? BR, Kewen --- gcc/testsuite/ChangeLog: * gcc.target/powerpc/conv-vectorize-1.c: Add option -fno-vect-cost-model. * gcc.target/powerpc/conv-vectorize-2.c: Likewise. ------ diff --git a/gcc/testsuite/gcc.target/powerpc/conv-vectorize-1.c b/gcc/testsuite/gcc.target/powerpc/conv-vectorize-1.c index d96db146864..8b8c88befd5 100644 --- a/gcc/testsuite/gcc.target/powerpc/conv-vectorize-1.c +++ b/gcc/testsuite/gcc.target/powerpc/conv-vectorize-1.c @@ -1,5 +1,5 @@ /* { dg-require-effective-target powerpc_vsx_ok } */ -/* { dg-options "-O2 -ftree-vectorize -mvsx" } */ +/* { dg-options "-O2 -ftree-vectorize -mvsx -fno-vect-cost-model" } */ /* Test vectorizer can exploit vector conversion instructions to convert unsigned/signed long long to float. */ diff --git a/gcc/testsuite/gcc.target/powerpc/conv-vectorize-2.c b/gcc/testsuite/gcc.target/powerpc/conv-vectorize-2.c index 5dd5deabdd3..06ae4e2d5ce 100644 --- a/gcc/testsuite/gcc.target/powerpc/conv-vectorize-2.c +++ b/gcc/testsuite/gcc.target/powerpc/conv-vectorize-2.c @@ -1,5 +1,5 @@ /* { dg-require-effective-target powerpc_vsx_ok } */ -/* { dg-options "-O2 -ftree-vectorize -mvsx" } */ +/* { dg-options "-O2 -ftree-vectorize -mvsx -fno-vect-cost-model" } */ /* Test vectorizer can exploit vector conversion instructions to convert float to unsigned/signed long long. */