From patchwork Thu Aug 3 15:05:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 1816512 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=CAZN75y8; dkim-atps=neutral Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RGsbr57Ywz1yZl for ; Fri, 4 Aug 2023 01:05:44 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 89C703858035 for ; Thu, 3 Aug 2023 15:05:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 89C703858035 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1691075142; bh=ClMCaNJYX+BTv84YhT9fFigEofUHx9W8e41tEcwjC/A=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=CAZN75y8t4hyJ20cAcEyKIQI5N2JpGErA7N8p+CeCtIjCRhqo0zbSDtW3N3zLiEq6 2tvjhl4exBFOzIsfBVh3kmObHj+M4g59ac4iEz5sdXY6DomwkxZ4BXKCw5KQwBArrq IjBLKB0SJ93y4Lt+fWuQ/ka3/PNjKcJoJnOFpmI4= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by sourceware.org (Postfix) with ESMTPS id 782E43858C27 for ; Thu, 3 Aug 2023 15:05:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 782E43858C27 Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-790930d78e8so35169439f.1 for ; Thu, 03 Aug 2023 08:05:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691075112; x=1691679912; h=to:subject:from:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ClMCaNJYX+BTv84YhT9fFigEofUHx9W8e41tEcwjC/A=; b=UtGPlFVKaXoLsZ1H3p7FKeDxTInxiZdQE/NtdSJjBBX4yZdNFAGF5LR+6DUxai6s5M e9rdKxb9Ps3KGiM8T8ygsFlL6VDw0jcY2wuerJp539luPZXCvqvcjQOW1SNJMWHpSMZZ bBomBlRrpwz2KwpXhgrZWxadBH0m0Siutcg4IoLZvOoyes6jqUHmK7BqpHJWGnGRS7VN T1sjb0SMe1ohAhYiOK1JvnKMnOtk6YhKYp3ZXekUtEu1lIw7DNP/fOOgcwfs8RQhdZpE ctJkdtrqpZv271va55qavGJQB1o/r/AWzQuGFaSmIdVS2NFR9FzKvhk/asbr8LRDt78F 3WJw== X-Gm-Message-State: ABy/qLbKqfd9Sot3f+TKiat2BqTuegdmZ0Cm+2T45xmUpbIW6nseEpO6 Wxyvss+qXpb8LgbtFZ2Q9F3F1f3wExK7rQ== X-Google-Smtp-Source: APBJJlHg1zn6jmI/Ag/G1eDzoCHO2DvzPjqJ6u9HmkrqIIsMV1ohy3IBhi6n4Q3sSr2g/YYc4sDQ7w== X-Received: by 2002:a05:6e02:1085:b0:348:d383:d8ee with SMTP id r5-20020a056e02108500b00348d383d8eemr15195444ilj.31.1691075112056; Thu, 03 Aug 2023 08:05:12 -0700 (PDT) Received: from [172.31.1.103] ([172.58.35.95]) by smtp.gmail.com with ESMTPSA id m8-20020a924a08000000b00348c7617795sm33937ilf.49.2023.08.03.08.05.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Aug 2023 08:05:11 -0700 (PDT) Message-ID: Date: Thu, 3 Aug 2023 09:05:09 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US Subject: [committed][RISC-V] Remove errant hunk of code To: "gcc-patches@gcc.gnu.org" X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jeff Law via Gcc-patches From: Jeff Law Reply-To: Jeff Law Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" I'm using this hunk locally to more thoroughly exercise the zicond paths due to inaccuracies elsewhere in the costing model. It was never supposed to be part of the costing commit though. And as we've seen it's causing problems with the vector bits. While my testing isn't complete, this hunk was never supposed to be pushed and it's causing problems. So I'm just ripping it out. There's a bigger TODO in this space WRT a top-to-bottom evaluation of the costing on RISC-V. I'm still formulating what that evaluation is going to look like, so don't hold your breath waiting on it. Pushed to the trunk. commit d61efa3cd3378be38738bfb5139925d1505c1325 Author: Jeff Law Date: Thu Aug 3 10:57:23 2023 -0400 [committed][RISC-V] Remove errant hunk of code I'm using this hunk locally to more thoroughly exercise the zicond paths due to inaccuracies elsewhere in the costing model. It was never supposed to be part of the costing commit though. And as we've seen it's causing problems with the vector bits. While my testing isn't complete, this hunk was never supposed to be pushed and it's causing problems. So I'm just ripping it out. There's a bigger TODO in this space WRT a top-to-bottom evaluation of the costing on RISC-V. I'm still formulating what that evaluation is going to look like, so don't hold your breath waiting on it. Pushed to the trunk. gcc/ * config/riscv/riscv.cc (riscv_rtx_costs): Remove errant hunk from recent commit. diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index 9e75450aa97..d8fab68dbb4 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -2913,16 +2913,6 @@ riscv_rtx_costs (rtx x, machine_mode mode, int outer_code, int opno ATTRIBUTE_UN } return false; - case SET: - /* A simple SET with a register destination takes its cost solely from - the SET_SRC operand. */ - if (outer_code == INSN && REG_P (SET_DEST (x))) - { - *total = riscv_rtx_costs (SET_SRC (x), mode, SET, opno, total, speed); - return true; - } - return false; - default: return false; }