From patchwork Fri Oct 14 17:04:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Stubbs X-Patchwork-Id: 1690094 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Mpt671xC8z1yqk for ; Sat, 15 Oct 2022 04:04:31 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3133D3857405 for ; Fri, 14 Oct 2022 17:04:29 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 758C83858D38 for ; Fri, 14 Oct 2022 17:04:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 758C83858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.95,184,1661846400"; d="scan'208";a="87540523" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 14 Oct 2022 09:04:14 -0800 IronPort-SDR: rZz40vDIwD2DSXYm7pPq2XcK/AXneLqSHgC31UQ2f4jfqpiVIwJvimi1vI0Dh5jAdsBkMMT5a4 Q86ZMHNQBAan9kxnPzcJrp43WL/qes7AaiPiCXBZc43rgHgEjjpHvC2EWkb9QNdahFKJ4qCCa6 0l3tZLLLeKbg11uI2KNaP32MJSR+WYDMC6rFlKw1aFG79wRv2rxPgl0pkLWX2b1F9e7MoMDPA4 +D9/xXzi4/azIdHNUgw1AoHvPRRKO7JSuj/uJ76tiJraxRqx5jU6Yk7XAv2Yccq6WqEPQ4Z2XO ZE0= Message-ID: Date: Fri, 14 Oct 2022 18:04:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Content-Language: en-GB To: "gcc-patches@gcc.gnu.org" , Jakub Jelinek From: Andrew Stubbs Subject: [PATCH] libgomp: fix hang on fatal error X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" This patch fixes a problem in which fatal errors inside mutex-locked regions (i.e. basically anything in the plugin) will cause it to hang up trying to take the lock to clean everything up. Using abort() instead of exit(1) bypasses the atexit handlers and solves the problem. OK for mainline? Andrew libgomp: fix hang on fatal error Don't try to clean up if a fatal error occurs in libgomp. Typically the cleanup is not reentrant so we end up hung on a lock. libgomp/ChangeLog: * error.c (gomp_vfatal): Use abort instead of exit. diff --git a/libgomp/error.c b/libgomp/error.c index 50ed85eedb1..25548c14a82 100644 --- a/libgomp/error.c +++ b/libgomp/error.c @@ -77,7 +77,7 @@ void gomp_vfatal (const char *fmt, va_list list) { gomp_verror (fmt, list); - exit (EXIT_FAILURE); + abort (); } void