From patchwork Wed Mar 21 19:19:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Sidwell X-Patchwork-Id: 889032 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-475194-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="SQto224E"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40603n6Nxlz9s0t for ; Thu, 22 Mar 2018 06:19:32 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=cGvXP/830Sx9mAs0FOBBWoQDy4cUkOmB9JcuJJ/uNtwbUmHVBa y6qOqfYtfQRSin+RRVY2pM9oXKzWzoxMWrTeNGG8pIrGX4QaqynjiEWe7cnkHPwk mxxInFHElki3YlZGhXcMM0B5NM+71ctvsWBE20cNkq//jvNoa6/GBZcdA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=n2iyu/QYhVr0NAUECgrVM6J268M=; b=SQto224E29p4mvYsQj36 AgaSGU+Xf4uhYjxqd1ehq9jR8uew+upGPV7OPch+lI1iAI6geUT29Zk/KpW5fz/o ifBHdKAF62VnrNswky+qjYP4mlTt+P95RpZB3K9EDUpH+TImWCPOzekANStrEGtw w42zI+mo2ucz3lXa/FzA1LY= Received: (qmail 81327 invoked by alias); 21 Mar 2018 19:19:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 81318 invoked by uid 89); 21 Mar 2018 19:19:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=concerning, H*r:180 X-HELO: mail-yw0-f172.google.com Received: from mail-yw0-f172.google.com (HELO mail-yw0-f172.google.com) (209.85.161.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Mar 2018 19:19:23 +0000 Received: by mail-yw0-f172.google.com with SMTP id x20so1050643ywg.5 for ; Wed, 21 Mar 2018 12:19:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-language; bh=e/u0xqVbW0QWxKc5KLcAhBT3aTIzche/E4kkhmtzq1E=; b=rezyUmulyXBKmIC0hG5nZxOg2BPHbOtItk2WjG0vfd+agGavZOWTQayBDEK34C0ymn CcMxOAO7buJHD8k8qQrqEQAwCzZekFKW1Z11bOcSPO3hzu6Z/cR729o5IV4Yrmp7UxfI XgttlaQXXwaJLaj6YlBzSSmNVb8UZMB0lHI5y7XXa4lVr4tuaR2S8Dcp96Ad1bggItyE SXMog7KlaLXPPz79We1p4/Wu+0e4t6rgXUnGO5s+n4S2qSue5bpsVzVXptImWE9LSGlB EWVMmfVNVqu/kSZ/f49TWpgsJhFDIPxDorEjagOFRdMNPGoQVce99+PivWKWE0TgaN/C 0CCA== X-Gm-Message-State: AElRT7Gyq4NrHtLE1cbyQZ3r3mFRwd6bBHLWy1MP6aLU+Ob+j4GFbp/c 4IxfdpEa81QAqix6rMbcGNM= X-Google-Smtp-Source: AG47ELt1sqHNKntpWtONFIf0yMjIsaglMMdw8juQ2mHgdgtXxOWo7u+443EMtjP6NZo9MJ4zVHrfhg== X-Received: by 10.129.76.72 with SMTP id z69mr9677078ywa.235.1521659961509; Wed, 21 Mar 2018 12:19:21 -0700 (PDT) Received: from ?IPv6:2620:10d:c0a1:1102:495f:7267:5ff:a250? ([2620:10d:c091:180::1:fd79]) by smtp.googlemail.com with ESMTPSA id z20sm1871326ywj.68.2018.03.21.12.19.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Mar 2018 12:19:20 -0700 (PDT) To: GCC Patches From: Nathan Sidwell Subject: [PR c++/85008] ICE looking for clone Message-ID: Date: Wed, 21 Mar 2018 15:19:18 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 This ICE turned out to be a latent bug exposed by moving the member fns onto the FIELDS list. We should be using DECL_CLONED_FUNCTION_P not DECL_CLONED_FUNCTION. Grepping showed another place (doing a similar linkage check) affected too. nathan 2018-03-21 Nathan Sidwell PR c++/85008 * tree.c (decl_linkage): Use DECL_CLONED_FUNCTION_P. * decl2.c (vague_linkage_p): Likewise. PR c++/85008 * g++.dg/pr85008.C: New. Index: cp/decl2.c =================================================================== --- cp/decl2.c (revision 258722) +++ cp/decl2.c (working copy) @@ -1940,7 +1940,7 @@ vague_linkage_p (tree decl) if ((DECL_MAYBE_IN_CHARGE_DESTRUCTOR_P (decl) || DECL_MAYBE_IN_CHARGE_CONSTRUCTOR_P (decl)) && DECL_CHAIN (decl) - && DECL_CLONED_FUNCTION (DECL_CHAIN (decl))) + && DECL_CLONED_FUNCTION_P (DECL_CHAIN (decl))) return vague_linkage_p (DECL_CHAIN (decl)); gcc_checking_assert (!DECL_COMDAT (decl)); Index: cp/tree.c =================================================================== --- cp/tree.c (revision 258722) +++ cp/tree.c (working copy) @@ -5022,7 +5022,7 @@ decl_linkage (tree decl) if ((DECL_MAYBE_IN_CHARGE_DESTRUCTOR_P (decl) || DECL_MAYBE_IN_CHARGE_CONSTRUCTOR_P (decl)) && DECL_CHAIN (decl) - && DECL_CLONED_FUNCTION (DECL_CHAIN (decl))) + && DECL_CLONED_FUNCTION_P (DECL_CHAIN (decl))) return decl_linkage (DECL_CHAIN (decl)); if (TREE_CODE (decl) == NAMESPACE_DECL) Index: testsuite/g++.dg/pr85008.C =================================================================== --- testsuite/g++.dg/pr85008.C (revision 0) +++ testsuite/g++.dg/pr85008.C (working copy) @@ -0,0 +1,8 @@ +// PR c++/85008 ICE concerning dtor clones + +void a() { + struct b { + ~b(); + int r [!!&b::~b]; // { dg-error "address of " } + }; +}