diff mbox

Fix bfin port WRT fallthru warnings

Message ID c3bf3e7f-193d-1146-294d-961a820a4e65@redhat.com
State New
Headers show

Commit Message

Jeff Law Oct. 28, 2016, 3:22 p.m. UTC 
These were pretty obvious when looking at the code.  Verified the bfin 
ports from config-list.mk will build with a trunk compiler.

Installing on the trunk.  Now onward to the target independent bits 
(which are few).

Jeff
commit 71012b1c342ab2b69494429ec2d60d94248acea5
Author: law <law@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Fri Oct 28 15:22:28 2016 +0000

    	* config/bfin/bfin.c (bfin_legitimate_address_p): Add missing
    	fallthru comment.
    	* config/bfin/bfin.h (TARGET_CPU_CPP_BUILTINS): Likewise.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@241651 138bc75d-0d04-0410-961f-82ee72b054a4
diff mbox

Patch

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index cfd0929..3f2ea4d 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@ 
+2016-10-28  Jeff Law  <law@redhat.com>
+
+	* config/bfin/bfin.c (bfin_legitimate_address_p): Add missing
+	fallthru comment.
+	* config/bfin/bfin.h (TARGET_CPU_CPP_BUILTINS): Likewise.
+
 2016-10-28  Segher Boessenkool  <segher@kernel.crashing.org>
 
 	PR rtl-optimization/78029
diff --git a/gcc/config/bfin/bfin.c b/gcc/config/bfin/bfin.c
index 9b81868..2dfd038 100644
--- a/gcc/config/bfin/bfin.c
+++ b/gcc/config/bfin/bfin.c
@@ -2718,6 +2718,7 @@  bfin_legitimate_address_p (machine_mode mode, rtx x, bool strict)
 	&& REG_P (XEXP (x, 0))
 	&& bfin_valid_reg_p (REGNO (XEXP (x, 0)), strict, mode, POST_INC))
       return true;
+    break;
   case PRE_DEC:
     if (LEGITIMATE_MODE_FOR_AUTOINC_P (mode)
 	&& XEXP (x, 0) == stack_pointer_rtx
diff --git a/gcc/config/bfin/bfin.h b/gcc/config/bfin/bfin.h
index a85c8c4..b5f1544 100644
--- a/gcc/config/bfin/bfin.h
+++ b/gcc/config/bfin/bfin.h
@@ -110,30 +110,35 @@ 
 	  break;				\
 	case BFIN_CPU_BF542M:			\
 	  builtin_define ("__ADSPBF542M__");	\
+	  /* FALLTHRU */			\
 	case BFIN_CPU_BF542:			\
 	  builtin_define ("__ADSPBF542__");	\
 	  builtin_define ("__ADSPBF54x__");	\
 	  break;				\
 	case BFIN_CPU_BF544M:			\
 	  builtin_define ("__ADSPBF544M__");	\
+	  /* FALLTHRU */			\
 	case BFIN_CPU_BF544:			\
 	  builtin_define ("__ADSPBF544__");	\
 	  builtin_define ("__ADSPBF54x__");	\
 	  break;				\
 	case BFIN_CPU_BF547M:			\
 	  builtin_define ("__ADSPBF547M__");	\
+	  /* FALLTHRU */			\
 	case BFIN_CPU_BF547:			\
 	  builtin_define ("__ADSPBF547__");	\
 	  builtin_define ("__ADSPBF54x__");	\
 	  break;				\
 	case BFIN_CPU_BF548M:			\
 	  builtin_define ("__ADSPBF548M__");	\
+	  /* FALLTHRU */			\
 	case BFIN_CPU_BF548:			\
 	  builtin_define ("__ADSPBF548__");	\
 	  builtin_define ("__ADSPBF54x__");	\
 	  break;				\
 	case BFIN_CPU_BF549M:			\
 	  builtin_define ("__ADSPBF549M__");	\
+	  /* FALLTHRU */			\
 	case BFIN_CPU_BF549:			\
 	  builtin_define ("__ADSPBF549__");	\
 	  builtin_define ("__ADSPBF54x__");	\