From patchwork Wed Jun 2 07:43:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Kewen.Lin" X-Patchwork-Id: 1486490 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=f8/yoAm1; dkim-atps=neutral Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Fw1KN11yVz9sT6 for ; Wed, 2 Jun 2021 17:45:28 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 46A4C386EC78 for ; Wed, 2 Jun 2021 07:45:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 46A4C386EC78 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1622619925; bh=mbmGKw4QR3kLv+CaTIKzAJ9KfrCyd21b1X1UAsu6aJA=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=f8/yoAm1QLTQNvVjOvXeZ+SvCPe9HvHSHt7LLpSL6siOcyxKIS/0I5uqfaGlrTAFS pS6mzOkwJetURFqya9IlSQ69WC3tRJGmMGTfCIrK4PcxztEESU54/ZaibbQKaUs4Ok sjUuYE2HZY6EVoJ+Bi8QwFfpKCi+mWaxoNkubK6w= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 00CA13835437 for ; Wed, 2 Jun 2021 07:43:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 00CA13835437 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1527WxNc178104; Wed, 2 Jun 2021 03:43:55 -0400 Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 38x565s6cd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Jun 2021 03:43:55 -0400 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1527hFZ1016414; Wed, 2 Jun 2021 07:43:53 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma05fra.de.ibm.com with ESMTP id 38ud87s6qd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Jun 2021 07:43:52 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1527hoLj28180762 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 2 Jun 2021 07:43:50 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8D9B65204E; Wed, 2 Jun 2021 07:43:50 +0000 (GMT) Received: from kewenlins-mbp.cn.ibm.com (unknown [9.200.146.52]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 3188652051; Wed, 2 Jun 2021 07:43:48 +0000 (GMT) Subject: [PATCH 02/11 v2] arc: Remove define_insn_and_split *bbit_di To: Claudiu Zissulescu References: <239dc6f5de19c088ab44c102d0cc4f8b53de1d12.1622179420.git.linkw@linux.ibm.com> Message-ID: Date: Wed, 2 Jun 2021 15:43:47 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: cP2MZws6bY-UUWMuZhEgT-zRyfMFvHBq X-Proofpoint-GUID: cP2MZws6bY-UUWMuZhEgT-zRyfMFvHBq X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-06-02_02:2021-06-01, 2021-06-02 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106020048 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_ASCII_DIVIDERS, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Kewen.Lin via Gcc-patches" From: "Kewen.Lin" Reply-To: "Kewen.Lin" Cc: "gnu@amylaar.uk" , "gcc-patches@gcc.gnu.org" Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Hi Claudiu, on 2021/6/2 下午3:12, Claudiu Zissulescu wrote: > Hi Kewen, > > Maybe it is best just to remove the pattern entirely, I couldn't exercise it myself. I was secretly hopping someone could do it. > Please can you submit a patch which removes it if it is not too much trouble? > The patch v2 has been attached which removes define_insn_and_split "*bbit_di" as you suggested. Does it look good to you? BR, Kewen ----- gcc/ChangeLog: * config/arc/arc.md (*bbit_di): Remove. diff --git a/gcc/config/arc/arc.md b/gcc/config/arc/arc.md index b6f2d8e28be..a67bb581003 100644 --- a/gcc/config/arc/arc.md +++ b/gcc/config/arc/arc.md @@ -5016,34 +5016,6 @@ (define_insn "*bbit" (if_then_else (match_test "get_attr_length (insn) == 6") (const_string "true") (const_string "false")))]) -; ??? When testing a bit from a DImode register, combine creates a -; zero_extract in DImode. This goes via an AND with a DImode constant, -; so can only be observed on 64 bit hosts. -(define_insn_and_split "*bbit_di" - [(set (pc) - (if_then_else - (match_operator 3 "equality_comparison_operator" - [(zero_extract:DI (match_operand:SI 1 "register_operand" "Rcqq,c") - (const_int 1) - (match_operand 2 "immediate_operand" "L,L")) - (const_int 0)]) - (label_ref (match_operand 0 "" "")) - (pc))) - (clobber (reg:CC_ZN CC_REG))] - "!CROSSING_JUMP_P (insn)" - "#" - "" - [(parallel - [(set (pc) (if_then_else (match_dup 3) (label_ref (match_dup 0)) (pc))) - (clobber (reg:CC_ZN CC_REG))])] -{ - rtx xtr; - - xtr = gen_rtx_ZERO_EXTRACT (SImode, operands[1], const1_rtx, operands[2]); - operands[3] = gen_rtx_fmt_ee (GET_CODE (operands[3]), GET_MODE (operands[3]), - xtr, const0_rtx); -}) - ;; ------------------------------------------------------------------- ;; Hardware loop ;; -------------------------------------------------------------------