From patchwork Tue Jul 13 11:06:07 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 58765 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id B2077B6F1A for ; Tue, 13 Jul 2010 21:06:20 +1000 (EST) Received: (qmail 16245 invoked by alias); 13 Jul 2010 11:06:18 -0000 Received: (qmail 16234 invoked by uid 22791); 13 Jul 2010 11:06:17 -0000 X-SWARE-Spam-Status: No, hits=-3.4 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Jul 2010 11:06:10 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2]) by mx2.suse.de (Postfix) with ESMTP id 130C94844E for ; Tue, 13 Jul 2010 13:06:08 +0200 (CEST) Date: Tue, 13 Jul 2010 13:06:07 +0200 (CEST) From: Richard Guenther To: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix PR44911 Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This fixes multi-line output from dumping MEM_REF and also crashes from endless recursions of TYPE_DECLs without a name. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. 2010-07-13 Richard Guenther PR middle-end/44911 * tree-pretty-print.c (dump_generic_node): Use TDF_SLIM for MEM_REF pointer type dumping. Avoid recursing for TYPE_DECLs without name. Index: gcc/tree-pretty-print.c =================================================================== --- gcc/tree-pretty-print.c (revision 162126) +++ gcc/tree-pretty-print.c (working copy) @@ -828,7 +828,7 @@ dump_generic_node (pretty_printer *buffe pp_string (buffer, "MEM["); pp_string (buffer, "("); dump_generic_node (buffer, TREE_TYPE (TREE_OPERAND (node, 1)), - spc, flags, false); + spc, flags | TDF_SLIM, false); pp_string (buffer, ")"); dump_generic_node (buffer, TREE_OPERAND (node, 0), spc, flags, false); @@ -1113,7 +1113,7 @@ dump_generic_node (pretty_printer *buffe } if (DECL_NAME (node)) dump_decl_name (buffer, node, flags); - else + else if (TYPE_NAME (TREE_TYPE (node)) != node) { if ((TREE_CODE (TREE_TYPE (node)) == RECORD_TYPE || TREE_CODE (TREE_TYPE (node)) == UNION_TYPE) @@ -1132,6 +1132,8 @@ dump_generic_node (pretty_printer *buffe dump_generic_node (buffer, TREE_TYPE (node), spc, flags, false); } } + else + pp_string (buffer, ""); break; case VAR_DECL: