From patchwork Tue Nov 5 10:50:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Glisse X-Patchwork-Id: 288470 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BEFE42C00A0 for ; Tue, 5 Nov 2013 21:50:43 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:in-reply-to:message-id:references :mime-version:content-type; q=dns; s=default; b=wuW5p+bX/xkuBjN1 yPqcrniz1QztCXMKRfRiSx7LF+1rsfoMjlfGQz/NQbK7eKnvuVWnXm5lawqPb6+E gBvPFmbUm5IX946e7LTsJF47tjA0X+6mb7bITRxPR5lPqlvHkoyYkJDnzOTwgojV KJVKNA5QIN7Bd1Ej6516E05Zv7I= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:in-reply-to:message-id:references :mime-version:content-type; s=default; bh=Aa2XpbrnCjmE+aa+mlLagG EnIeI=; b=kJwz+KDnjSZAVMfZ3WwVkxdUZf02BsH8kENRNhRk87XQ/Meh33KC/t KSp5JnKm1ANlCPclMQUMkSvksS+XDIbIST4DS4wVbrgsVWpjENonDD7lwwAcbybq cXArkPpyEdn3mcO3YOOU+N4UTPmtVsdKipvLtahAeTyHIXikj+1sE= Received: (qmail 8330 invoked by alias); 5 Nov 2013 10:50:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 8320 invoked by uid 89); 5 Nov 2013 10:50:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_50, RDNS_NONE, URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail3-relais-sop.national.inria.fr Received: from Unknown (HELO mail3-relais-sop.national.inria.fr) (192.134.164.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 05 Nov 2013 10:50:28 +0000 Received: from stedding.saclay.inria.fr ([193.55.250.194]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES128-SHA; 05 Nov 2013 11:50:18 +0100 Received: from glisse (helo=localhost) by stedding.saclay.inria.fr with local-esmtp (Exim 4.80) (envelope-from ) id 1VdeDC-00083K-Fd; Tue, 05 Nov 2013 11:50:18 +0100 Date: Tue, 5 Nov 2013 11:50:18 +0100 (CET) From: Marc Glisse To: Richard Biener cc: Jeff Law , GCC Patches Subject: Re: Aliasing: look through pointer's def stmt In-Reply-To: <82139bc1-0f67-4ea2-9cb0-77f1499b118b@email.android.com> Message-ID: References: <82139bc1-0f67-4ea2-9cb0-77f1499b118b@email.android.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 On Mon, 4 Nov 2013, Richard Biener wrote: > Marc Glisse wrote: >> On Mon, 4 Nov 2013, Richard Biener wrote: >> >>> Well, host_integer_p (, 0) looks correct to me. But ... >> >> Ok, I'll put it back. Er, actually host_integerp(, 0) can't work, because arithmetic on pointers is done with unsigned integers and for x86_64 it would return false for (size_t)-4. So it would need to be host_integerp(, 1) instead. I still test TREE_CODE == INTEGER_CST in the current patch, let me know if you want host_integerp(, 1). >>>> Index: gcc/tree-ssa-alias.h >>>> =================================================================== >>>> --- gcc/tree-ssa-alias.h (revision 204267) >>>> +++ gcc/tree-ssa-alias.h (working copy) >>>> @@ -139,30 +139,30 @@ extern void pt_solution_set_var (struct >>>> >>>> extern void dump_pta_stats (FILE *); >>>> >>>> extern GTY(()) struct pt_solution ipa_escaped_pt; >>>> >>>> /* Return true, if the two ranges [POS1, SIZE1] and [POS2, SIZE2] >>>> overlap. SIZE1 and/or SIZE2 can be (unsigned)-1 in which case >> the >>>> range is open-ended. Otherwise return false. */ >>>> >>>> static inline bool >>>> -ranges_overlap_p (unsigned HOST_WIDE_INT pos1, >>>> - unsigned HOST_WIDE_INT size1, >>>> - unsigned HOST_WIDE_INT pos2, >>>> - unsigned HOST_WIDE_INT size2) >>>> +ranges_overlap_p (HOST_WIDE_INT pos1, >>>> + HOST_WIDE_INT size1, >>>> + HOST_WIDE_INT pos2, >>>> + HOST_WIDE_INT size2) >>> >>> I think size[12] should still be unsigned (we don't allow negative >>> sizes but only the special value -1U which we special-case only to >>> avoid pos + size to wrap) >> >> But all we do with size[12] is compare it to -1 and perform arithmetic >> with pos[12]. At least for the second one, we need to cast size to a >> signed type so the comparisons make sense (unless we decide to use a >> double_int there). So I thought I would do the cast in the argument. >> Otherwise, I'll start the function with: >> HOST_WIDE_INT ssize1 = (HOST_WIDE_INT)size1; >> and replace size1 with ssize1 through the function. >> >> Is the reason of keeping size[12] unsigned for documentation? Or am I >> missing a reason why I may be breaking things? > > It is mostly documentation indeed. Ok, then here it is (bootstrap+testsuite on x86_64-unknown-linux-gnu). 2013-11-05 Marc Glisse gcc/ * tree-ssa-alias.h (ranges_overlap_p): Handle negative offsets. * tree-ssa-alias.c (ao_ref_init_from_ptr_and_size): Likewise. gcc/testsuite/ * gcc.dg/tree-ssa/alias-26.c: New file. Index: gcc/testsuite/gcc.dg/tree-ssa/alias-26.c =================================================================== --- gcc/testsuite/gcc.dg/tree-ssa/alias-26.c (revision 0) +++ gcc/testsuite/gcc.dg/tree-ssa/alias-26.c (working copy) @@ -0,0 +1,13 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-tree-optimized" } */ + +void f (const char *c, int *i) +{ + *i = 42; + __builtin_memcpy (i - 1, c, sizeof (int)); + if (*i != 42) __builtin_abort(); +} + +/* { dg-final { scan-tree-dump-not "abort" "optimized" } } */ +/* { dg-final { cleanup-tree-dump "optimized" } } */ + Property changes on: gcc/testsuite/gcc.dg/tree-ssa/alias-26.c ___________________________________________________________________ Added: svn:keywords ## -0,0 +1 ## +Author Date Id Revision URL \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Index: gcc/tree-ssa-alias.c =================================================================== --- gcc/tree-ssa-alias.c (revision 204381) +++ gcc/tree-ssa-alias.c (working copy) @@ -552,42 +552,42 @@ ao_ref_base_alias_set (ao_ref *ref) alias_set_type ao_ref_alias_set (ao_ref *ref) { if (ref->ref_alias_set != -1) return ref->ref_alias_set; ref->ref_alias_set = get_alias_set (ref->ref); return ref->ref_alias_set; } /* Init an alias-oracle reference representation from a gimple pointer - PTR and a gimple size SIZE in bytes. If SIZE is NULL_TREE the the + PTR and a gimple size SIZE in bytes. If SIZE is NULL_TREE then the size is assumed to be unknown. The access is assumed to be only to or after of the pointer target, not before it. */ void ao_ref_init_from_ptr_and_size (ao_ref *ref, tree ptr, tree size) { HOST_WIDE_INT t1, t2, extra_offset = 0; ref->ref = NULL_TREE; if (TREE_CODE (ptr) == SSA_NAME) { gimple stmt = SSA_NAME_DEF_STMT (ptr); if (gimple_assign_single_p (stmt) && gimple_assign_rhs_code (stmt) == ADDR_EXPR) ptr = gimple_assign_rhs1 (stmt); else if (is_gimple_assign (stmt) && gimple_assign_rhs_code (stmt) == POINTER_PLUS_EXPR - && host_integerp (gimple_assign_rhs2 (stmt), 0) - && (t1 = int_cst_value (gimple_assign_rhs2 (stmt))) >= 0) + && TREE_CODE (gimple_assign_rhs2 (stmt)) == INTEGER_CST) { ptr = gimple_assign_rhs1 (stmt); - extra_offset = BITS_PER_UNIT * t1; + extra_offset = BITS_PER_UNIT + * int_cst_value (gimple_assign_rhs2 (stmt)); } } if (TREE_CODE (ptr) == ADDR_EXPR) ref->base = get_ref_base_and_extent (TREE_OPERAND (ptr, 0), &ref->offset, &t1, &t2); else { ref->base = build2 (MEM_REF, char_type_node, ptr, null_pointer_node); Index: gcc/tree-ssa-alias.h =================================================================== --- gcc/tree-ssa-alias.h (revision 204381) +++ gcc/tree-ssa-alias.h (working copy) @@ -139,30 +139,30 @@ extern void pt_solution_set_var (struct extern void dump_pta_stats (FILE *); extern GTY(()) struct pt_solution ipa_escaped_pt; /* Return true, if the two ranges [POS1, SIZE1] and [POS2, SIZE2] overlap. SIZE1 and/or SIZE2 can be (unsigned)-1 in which case the range is open-ended. Otherwise return false. */ static inline bool -ranges_overlap_p (unsigned HOST_WIDE_INT pos1, +ranges_overlap_p (HOST_WIDE_INT pos1, unsigned HOST_WIDE_INT size1, - unsigned HOST_WIDE_INT pos2, + HOST_WIDE_INT pos2, unsigned HOST_WIDE_INT size2) { if (pos1 >= pos2 && (size2 == (unsigned HOST_WIDE_INT)-1 - || pos1 < (pos2 + size2))) + || pos1 < (pos2 + (HOST_WIDE_INT) size2))) return true; if (pos2 >= pos1 && (size1 == (unsigned HOST_WIDE_INT)-1 - || pos2 < (pos1 + size1))) + || pos2 < (pos1 + (HOST_WIDE_INT) size1))) return true; return false; } #endif /* TREE_SSA_ALIAS_H */