From patchwork Thu Sep 5 07:30:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 1981116 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DSPzh6P3; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WzrdN5Zb3z1yXY for ; Thu, 5 Sep 2024 17:31:20 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9A384386480F for ; Thu, 5 Sep 2024 07:31:18 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id DE1BE384F4B9 for ; Thu, 5 Sep 2024 07:30:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE1BE384F4B9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DE1BE384F4B9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1725521460; cv=none; b=fScmtkORhqY1eHN98/par11tIPfUOVqF2MhOjkLjEdSJMQf9BPuSRduQSWHhCGRhMiIiyONObl6MYtoe20/vbotrpuCSD19pbvLgs9kltbwf6BH2IKs+0GtQHAQpYsKZk30XSvxQaRoaRVNeddaH0rJYNN6kF+k+dm5KPw2JXls= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1725521460; c=relaxed/simple; bh=uptQ5Tf0TxB0E/OBN78oY3fr+m1ZJZCHMgSH9ehxrpU=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ekas2+csDMq5LDeSXo2WkZzCY1hnuKkngTmCeozv+uspt7rxUVO/hBLzmm7KGMrUw9/ddA8R+YDNe/QOgMw3pYs0vnPyjOWnK/iWTa2U0ssFOpULTF0qj2wip7arAdjhw11Ca4MGSmN3I+gPMb+4JvUZ4X4kevDlA/23/qSptLM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725521458; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=57PAmfiXAqwogDY6t8PM5WhmVek6d1Uz8mv5Oak9nek=; b=DSPzh6P3iyRl17REQqaue3eolTkcakwY1vzSoh/Y6p29fjzfHueIDRFUZ+3V4JJrwN80eK qssL5aGO/epl88pPn5HdG9EC5Z3ZKgXJqr9KReH7TeqrtqenquH2TCzOHBRfPsaDBzbm0C bkl1uTxMy0cbiru1EE0tEUYUYsZBhZM= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-674-ABSiR9zwO4Ws0KtM_ACeLg-1; Thu, 05 Sep 2024 03:30:55 -0400 X-MC-Unique: ABSiR9zwO4Ws0KtM_ACeLg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 69D1C1944AA5 for ; Thu, 5 Sep 2024 07:30:54 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.29]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DDB0E195608A; Thu, 5 Sep 2024 07:30:53 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 4857Upoj1837248 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 5 Sep 2024 09:30:51 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 4857UpSt1837247; Thu, 5 Sep 2024 09:30:51 +0200 Date: Thu, 5 Sep 2024 09:30:50 +0200 From: Jakub Jelinek To: Andrew MacLeod , Aldy Hernandez Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] vrp: Fix up diagnostics wording Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Hi! I've noticed non-standard wording of this diagnostics when looking at a miscompilation with --param=vrp-block-limit=0. Diagnostics generally shouldn't start with uppercase letter (unless the upper case would appear also in the middle of a sentence) and shouldn't be separate sentences with dot as separator, ; is IMHO more frequently used. Ok for trunk? 2024-09-05 Jakub Jelinek * tree-vrp.cc (pass_vrp::execute): Start diagnostics with lowercase u rather than capital U, use semicolon instead of dot. Jakub --- gcc/tree-vrp.cc.jj 2024-07-01 11:28:23.489227914 +0200 +++ gcc/tree-vrp.cc 2024-09-04 21:26:35.693634896 +0200 @@ -1337,7 +1337,7 @@ public: { use_fvrp = true; warning (OPT_Wdisabled_optimization, - "Using fast VRP algorithm. %d basic blocks" + "using fast VRP algorithm; %d basic blocks" " exceeds %<--param=vrp-block-limit=%d%> limit", n_basic_blocks_for_fn (fun), param_vrp_block_limit);