From patchwork Mon Jun 19 18:59:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 777944 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ws0fM2d0dz9s71 for ; Tue, 20 Jun 2017 05:00:10 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="evvojz0x"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; q=dns; s=default; b=X6M eHn+zGohlBENO/Ve5Vede5SfinYB8gTg7D/e84Au2kkzDC6hfKEvvIGTbE2qUjAe LNsaqiM05A6VADTiSNpAnQNeDqBiOEUvcbJJYVc0S+U4E3nxK5zyweOvDJ1XLp98 gHRVo+zKj7lCBS9YXdYBMqpurpAKIh8/g5j+9OPo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; s=default; bh=H10BImQq/ PSF8Rv3XlQuwG6q7tA=; b=evvojz0xw3bAUZoJT5rRCB/PE243f6KM7jqaRbYBK /ySYSN98jaU0aQdujzzYINhCvrnUJoJ/sgwT0pixce1PavGTkhAeoQRLATslJ2kM +YutyQ+Mr/EzF4+DEW2e74C4A9idoHMzHDI4mFVgzxIJ7bRtTn/O14tn5VCBAzwR 0c= Received: (qmail 46801 invoked by alias); 19 Jun 2017 18:59:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 46786 invoked by uid 89); 19 Jun 2017 18:59:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=03, 0.3, ble X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr50078.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.107.5.78) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Jun 2017 18:59:44 +0000 Received: from VI1PR0802MB2621.eurprd08.prod.outlook.com (10.175.20.147) by AM4PR08MB2658.eurprd08.prod.outlook.com (10.171.190.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.14; Mon, 19 Jun 2017 18:59:46 +0000 Received: from VI1PR0802MB2621.eurprd08.prod.outlook.com ([fe80::4434:9169:8398:f9dd]) by VI1PR0802MB2621.eurprd08.prod.outlook.com ([fe80::4434:9169:8398:f9dd%13]) with mapi id 15.01.1178.018; Mon, 19 Jun 2017 18:59:46 +0000 From: Wilco Dijkstra To: GCC Patches CC: nd , James Greenhalgh Subject: [PATCH][AArch64] Mark symbols as constant Date: Mon, 19 Jun 2017 18:59:46 +0000 Message-ID: authentication-results: arm.com; dkim=none (message not signed) header.d=none; arm.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR08MB2658; 7:PoLr1x9IoS5gf4xY2/EcMl8pQsgY3Ci7nxpFs99Si2Y0bE46+V3byhdaqtPHZc40IeMuk+JCDbV8o6o/tJ99HFUicyiPRNMQPFZucSGB+ldCM/QkZaevdHQFfwuPJTzBSUZQp7Kl+wmQ5O+n+00+fiQD9FOYhW/SVrlGHT3PO27CMtv/9s47GMfoc8UuM1h7toX5NkLFpwJG5mrmm0k2cDCiJ+eyGdqLFneQwvsNUG/WoxfBfllnLLjGTh4w6FCiyIqa6HmcLBdfP4UUH/Cu34QmvuylZBnA41DZc0mONhiG5eIzqN9RvQ4LVdeLKauBIZikqwNO6QnvbSzEjXPs6/2qtEk66EgiXwlqvZdfltNIIvrw3lT0nQVZsbgckXTubwg75iK7AAL+PAdRNifkk8zH1/czipJBV7B3qMdTISzQzlbycJdRD2j4GA9UDGvVM/BX0/+3gmYir1E3v4qXWGMhyYhkLiaFhj8UwZ9BCtsidkTDWq60225oijJ07MvJ7Yn3MqtnRO6qSdGL14PObOmwU/9AzFWdWOMcKZwWic91U4NHX/pq1b6jkOqZdREq03HOZ4l2KBn90ESJaoS7xa/VvH9HT+9XuKt/l/rVShK7MvWU1rqeojhSfS4V+suoUfhPhVcJAWIJkKsi4azVBkp7AORZ5DwEDi4mXBt7TOgEa/2D2XTAd03uZ5a0Q6AIPJMM1WN3Fx8GGPibTPU5CwJ6sSIQFFw7PYkQmUUQTzaRQkzhD68SJsNvTqbonuIJs08Fmq9W4K3rH8fVfngrTyij1zFg3V3VAgXD7j2Gtt0= x-ms-office365-filtering-correlation-id: dba7c9f5-60ba-4782-21ea-08d4b7455a5b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500041)(300135000095)(300000501041)(300135300095)(22001)(300000502041)(300135100095)(2017030254075)(48565401081)(300000503041)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504041)(300135200095)(300000505041)(300135600095)(300000506037)(300135500095); SRVR:AM4PR08MB2658; x-ms-traffictypediagnostic: AM4PR08MB2658: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR08MB2658; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR08MB2658; x-forefront-prvs: 0343AC1D30 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39450400003)(39840400002)(39400400002)(39410400002)(39860400002)(39850400002)(54534003)(377424004)(99286003)(4326008)(74316002)(54906002)(72206003)(14454004)(9686003)(33656002)(7696004)(478600001)(6436002)(5660300001)(102836003)(3280700002)(3660700001)(110136004)(55016002)(25786009)(305945005)(5250100002)(53936002)(6916009)(38730400002)(6506006)(2906002)(86362001)(575784001)(7736002)(81166006)(8676002)(189998001)(8936002)(2900100001)(50986999)(54356999); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR08MB2658; H:VI1PR0802MB2621.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2017 18:59:46.1380 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2658 Aarch64_legitimate_constant_p currently returns false for symbols, eventhough they are always valid constants. This means LOSYM isn't CSEd correctly. If we return true CSE works better, resulting in smaller/faster code (0.3% smaller code on SPEC2006). int x0 = 1, x1 = 2, x2 = 3; int f (int x, int y) { x += x1; if (x > 100) y += x2; x += x0; return x + y; } Before: adrp x3, .LANCHOR0 add x4, x3, :lo12:.LANCHOR0 ldr w2, [x3, #:lo12:.LANCHOR0] add w0, w0, w2 cmp w0, 100 ble .L5 ldr w2, [x4, 8] add w1, w1, w2 .L5: add x3, x3, :lo12:.LANCHOR0 ldr w2, [x3, 4] add w0, w0, w2 add w0, w0, w1 ret After: adrp x2, .LANCHOR0 add x3, x2, :lo12:.LANCHOR0 ldr w2, [x2, #:lo12:.LANCHOR0] add w0, w0, w2 cmp w0, 100 ble .L5 ldr w2, [x3, 8] add w1, w1, w2 .L5: ldr w2, [x3, 4] add w0, w0, w2 add w0, w0, w1 ret Passes regress and bootstrap, OK for commit? ChangeLog: 2017-06-19 Wilco Dijkstra * config/aarch64/aarch64.c (aarch64_legitimate_constant_p): Return true for symbols. diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 5ec6bbfcf484baa4005b8a88cb98d0d04f710877..4b7d961102e41ce927d89d458fc89ddfc2adcd6f 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -10111,6 +10111,9 @@ aarch64_legitimate_constant_p (machine_mode mode, rtx x) && aarch64_valid_symref (XEXP (x, 0), GET_MODE (XEXP (x, 0)))) return true; + if (SYMBOL_REF_P (x)) + return true; + return aarch64_constant_address_p (x); }