Message ID | VI1PR0802MB2621A0766927C50FBBE1FAE6831E0@VI1PR0802MB2621.eurprd08.prod.outlook.com |
---|---|
State | New |
Headers | show
Return-Path: <gcc-patches-return-452063-incoming=patchwork.ozlabs.org@gcc.gnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wC1D23H4tz9s85 for <incoming@patchwork.ozlabs.org>; Tue, 25 Apr 2017 21:28:01 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="sfpyFdsh"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; q=dns; s= default; b=SIKBM68FFDbdMG//KolAbCQZv4o1wvcJSPsM9kbMWMVv0w9uaP4DS Iw6oGcq34ImyaSK5aBuZNa0HBb2jW52tVqyPMdlzBO4lItn5Gt+j5kPfR6s9jq4G ucjxSbfGEtRofhASijVfp4CGALiXAqNmAJ+xbTs5gDLpG0QuSqOf/M= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s=default; bh=qMCz7UcEo3Uihb2gtFuctQTvn9w=; b=sfpyFdshgN7QbaCtk3L6CQAs9QE9 PmdVvXLt1KED9SLDdvGyCktbl/oclBiLsOP+Wj1MgsD0tt2QiH+BX/boPGxcNldn o/6aG87jx6lMscdi5oeH0tHe2FQBTlnrnYjO0K1cxGbcowazVAfdxz8qxg5FNciT VtqAXpolQMvb1yA= Received: (qmail 59896 invoked by alias); 25 Apr 2017 11:27:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: <gcc-patches.gcc.gnu.org> List-Unsubscribe: <mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org> List-Archive: <http://gcc.gnu.org/ml/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-help@gcc.gnu.org> Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 59876 invoked by uid 89); 25 Apr 2017 11:27:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:sk:EUR01-V, H*RU:sk:mail-ve, H*RU:sk:EUR01-V, HX-HELO:sk:EUR01-V X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0067.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Apr 2017 11:27:48 +0000 Received: from VI1PR0802MB2621.eurprd08.prod.outlook.com (10.175.20.147) by VI1PR0802MB2624.eurprd08.prod.outlook.com (10.175.20.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13; Tue, 25 Apr 2017 11:27:46 +0000 Received: from VI1PR0802MB2621.eurprd08.prod.outlook.com ([10.175.20.147]) by VI1PR0802MB2621.eurprd08.prod.outlook.com ([10.175.20.147]) with mapi id 15.01.1047.019; Tue, 25 Apr 2017 11:27:46 +0000 From: Wilco Dijkstra <Wilco.Dijkstra@arm.com> To: "Hurugalawadi, Naveen" <Naveen.Hurugalawadi@cavium.com>, "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org> CC: "Pinski, Andrew" <Andrew.Pinski@cavium.com>, "roland.illig@gmx.de" <roland.illig@gmx.de>, "joseph@codesourcery.com" <joseph@codesourcery.com>, "dmalcolm@redhat.com" <dmalcolm@redhat.com>, nd <nd@arm.com>, "James Greenhalgh" <James.Greenhalgh@arm.com>, Marcus Shawcroft <Marcus.Shawcroft@arm.com>, Richard Earnshaw <Richard.Earnshaw@arm.com>, "ramana.radhakrishnan@foss.arm.com" <ramana.radhakrishnan@foss.arm.com> Subject: Re: [PING][PATCH] Move the check for any_condjump_p from sched-deps to target macros Date: Tue, 25 Apr 2017 11:27:46 +0000 Message-ID: <VI1PR0802MB2621A0766927C50FBBE1FAE6831E0@VI1PR0802MB2621.eurprd08.prod.outlook.com> References: <CO2PR07MB2694EE4FE1416466745550BC83330@CO2PR07MB2694.namprd07.prod.outlook.com>, <CO2PR07MB2694D5ED2A06E8D85BD18789831E0@CO2PR07MB2694.namprd07.prod.outlook.com> In-Reply-To: <CO2PR07MB2694D5ED2A06E8D85BD18789831E0@CO2PR07MB2694.namprd07.prod.outlook.com> authentication-results: cavium.com; dkim=none (message not signed) header.d=none; cavium.com; dmarc=none action=none header.from=arm.com; x-microsoft-exchange-diagnostics: 1; VI1PR0802MB2624; 7:gF2lsc0eS4bPEf5BXEGyjyL7c6SXKZez2xn7fy9Y6ZYlY+dj2tZgd8Xvn2+3HZYTAWFCgjdWNkRbGO3BFDW2xP9gIMnneTtLPUDeQL4RpZapVwup9Gdb7TfCYJlX/Kxmjywk46drJHQVEh0cgv8P/jBGK6HM0icPEUQWXzFtbH/0oaEIG0e1p6ON0yXhBhZTkWTE3y5mU2rnuyYVILufENLR67NcbzxdhSNWb7sJnPNTyQY5PhiuT1Ihva1O6rtUE3M0ZMTSkQXyEmI/Fg6Q0g28VyhuOHNogiSHphl3xv8PhqRSS0ojS+NZe+aMZX9l9dBVxE18fAgId9FpX+WatQ== x-ms-office365-filtering-correlation-id: 2ce30b0b-cc1d-4914-4243-08d48bce193d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:VI1PR0802MB2624; nodisclaimer: True x-microsoft-antispam-prvs: <VI1PR0802MB2624FA918C4A34898FB8DAB5831E0@VI1PR0802MB2624.eurprd08.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(22074186197030)(183786458502308); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(6072148); SRVR:VI1PR0802MB2624; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0802MB2624; x-forefront-prvs: 0288CD37D9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39840400002)(39860400002)(39850400002)(39400400002)(39410400002)(39450400003)(3280700002)(189998001)(7696004)(66066001)(50986999)(76176999)(54356999)(6436002)(33656002)(77096006)(6506006)(3660700001)(2900100001)(8936002)(81166006)(7736002)(3846002)(6116002)(305945005)(102836003)(6246003)(122556002)(2501003)(74316002)(2950100002)(5660300001)(8676002)(2906002)(9686003)(86362001)(53936002)(99286003)(38730400002)(8666007)(229853002)(25786009)(4326008)(55016002)(54906002)(6306002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0802MB2624; H:VI1PR0802MB2621.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2017 11:27:46.3827 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2624 |
--- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -13972,6 +13972,15 @@ aarch_macro_fusion_pair_p (rtx_insn *prev, rtx_insn *curr) { enum attr_type prev_type = get_attr_type (prev); + unsigned int condreg1, condreg2; + rtx cc_reg_1; + aarch64_fixed_condition_code_regs (&condreg1, &condreg2); + cc_reg_1 = gen_rtx_REG (CCmode, condreg1); + if (!reg_referenced_p (cc_reg_1, PATTERN (curr)) + || !prev + || !modified_in_p (cc_reg_1, prev)) + return false; + The return false seems incorrect - it means a core can either have FUSE_CMP_BRANCH or FUSE_ALU_BRANCH but not both.
Hi Naveen, > https://gcc.gnu.org/ml/gcc-patches/2017-03/msg01368.html This looks good to me - I have just one comment: The way aarch_macro_fusion_pair_p works is to return true if fusion is possible but fallthrough if not so other, less likely, fusion candidates can still be tried. Wilco