From patchwork Mon Jul 29 16:49:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 1138526 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-505772-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="wll9frra"; dkim=pass (1024-bit key; unprotected) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="7jiHlIeM"; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="7jiHlIeM"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45y5JM5DDhz9s7T for ; Tue, 30 Jul 2019 02:49:37 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; q=dns; s=default; b=Shw Nw2yaqomHoTOK6pZI3bJzOusVIvkwgVjB6P1zNlkiPbcuCfF0q8evLOnI6gwvdmt RwYlKG4AjbapHoLrKvrnainwOKHwxy6Q230GObLBsjMe9kqZ/c/Mo0ArZTFg4eja +Wd8n3o+Y/9iQTGaFkgT2VuYOJBHJCMPVnFrKRWc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; s=default; bh=uaRcSoyEe pqm6jnICgiMBNhAU7E=; b=wll9frra3JjRoTM8POHbs6FESsPFnhIST0yptOsqU 5ed4b1sI8M+StEJ1rEsqzy66l/B/yLkwmwRm0WX2OrkF866sQ6p5TlFu0Lj5B8MZ SfIlCSuGRQgLRRoAT9Piu5/Qk8u6q5VZDCeRACJdneScIEO+v91d3nwtG3Af6/7l lY= Received: (qmail 68124 invoked by alias); 29 Jul 2019 16:49:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 68116 invoked by uid 89); 29 Jul 2019 16:49:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.1 spammy=06, 0.6 X-HELO: EUR02-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr20042.outbound.protection.outlook.com (HELO EUR02-VE1-obe.outbound.protection.outlook.com) (40.107.2.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Jul 2019 16:49:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z/Hz/Djzw62SeleRO72XYXo6z2Cj4JhChn3Yd30C/1U=; b=7jiHlIeMCE7WRw7HPXlAbcDR76zi0C5ZY3Ek2UcjScM7obbZxwG+lX5mtwNZ2RjPq2iU3HnmdwHpZ4neRQwKLy6p5/8UPqemWJ7mW0h7htbBv+ufo8a8ekgpe77L3n2zxHFwfTYDCyeNmHY3iYcVAVqvGkrC1f5G5Sgpa9y+GPc= Received: from VI1PR08CA0254.eurprd08.prod.outlook.com (2603:10a6:803:dc::27) by HE1PR0802MB2601.eurprd08.prod.outlook.com (2603:10a6:3:d8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.14; Mon, 29 Jul 2019 16:49:21 +0000 Received: from AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::200) by VI1PR08CA0254.outlook.office365.com (2603:10a6:803:dc::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2115.10 via Frontend Transport; Mon, 29 Jul 2019 16:49:21 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; gcc.gnu.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT017.mail.protection.outlook.com (10.152.16.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Mon, 29 Jul 2019 16:49:20 +0000 Received: ("Tessian outbound 578a71fe5eaa:v26"); Mon, 29 Jul 2019 16:49:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7079e5c127a88a9e X-CR-MTA-TID: 64aa7808 Received: from 0f894d3ed628.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.10.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id D84C2C5E-1178-40DC-9C66-E3D9AE9E6997.1; Mon, 29 Jul 2019 16:49:14 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2056.outbound.protection.outlook.com [104.47.10.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0f894d3ed628.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Mon, 29 Jul 2019 16:49:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RSUOyPUS5+5dTX+k9g47k+vEITJA5xRk4MjOGNrPp5B0Lq9/9OWw7rdFxyR7/16X6thV+jYdHCbv7Tx+zP/2lGTZMP4Mgpy4Wdivrl83eFs+d2nqDJf2P+W8Tu60uYdeCRP0cTHhVBIcGoLKQ0E9wU3dN9zmnSGz+90aMOca9Q2R61KCZZfXMWbrQ71K1MFBZo/Kmfdf9Y3qoB2x9k73NpdTlxc2r26Y2N8xG4KlsoeZULsGvDeGc0Ff6zvjFdAnZe4v0Ga3dfXRerRNbRMYaavGlKFPv/+CGgFQ6y6L2wEtrOxY0eqooKcHOMpIQJKhT1kDJgj6LscjAQ2bSUoMKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z/Hz/Djzw62SeleRO72XYXo6z2Cj4JhChn3Yd30C/1U=; b=fHerVPM/WWURS2QOiqURC3aJ31Efc0u6lWSq3hiAS59KaL4V6PsyO/MXHDx8FonR0EkhYSoyXqS+bEzgjejG03j1uZyAUaexol3t+GoxgXcYsPUZRaT+uqTrmYOVoyho4gbA6bgb13EMLYlb6NCZHlGNlmlGVB+eJGDxQSpeFb8O+o3urMq9Hr8yeVwRclkU6euqmEyxmlFCAFOR5XIuz+nCfrgTtmds/gHGyfy5T2X0PM8bsK5Ofc4Os4yo4IQxg/SaikeJwpT/3jvELjIAgA+OIT3+vZAPhYnOmNEpCvbrg66Xb+gO35kz+d4QdUZ4xFTEivnls8pexzhoAgIbXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z/Hz/Djzw62SeleRO72XYXo6z2Cj4JhChn3Yd30C/1U=; b=7jiHlIeMCE7WRw7HPXlAbcDR76zi0C5ZY3Ek2UcjScM7obbZxwG+lX5mtwNZ2RjPq2iU3HnmdwHpZ4neRQwKLy6p5/8UPqemWJ7mW0h7htbBv+ufo8a8ekgpe77L3n2zxHFwfTYDCyeNmHY3iYcVAVqvGkrC1f5G5Sgpa9y+GPc= Received: from VI1PR0801MB2127.eurprd08.prod.outlook.com (10.168.62.22) by VI1PR0801MB2079.eurprd08.prod.outlook.com (10.173.76.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.14; Mon, 29 Jul 2019 16:49:11 +0000 Received: from VI1PR0801MB2127.eurprd08.prod.outlook.com ([fe80::c048:47c4:9d:a454]) by VI1PR0801MB2127.eurprd08.prod.outlook.com ([fe80::c048:47c4:9d:a454%9]) with mapi id 15.20.2115.005; Mon, 29 Jul 2019 16:49:11 +0000 From: Wilco Dijkstra To: GCC Patches CC: nd , Richard Earnshaw , "Kyrylo Tkachov" Subject: [PATCH][ARM] Switch to default sched pressure algorithm Date: Mon, 29 Jul 2019 16:49:11 +0000 Message-ID: Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR0801MB2079; x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:6108;OLM:6108; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(346002)(39860400002)(376002)(396003)(366004)(136003)(199004)(189003)(54534003)(6916009)(71200400001)(8936002)(71190400001)(86362001)(81166006)(64756008)(26005)(478600001)(5660300002)(76116006)(66556008)(2906002)(25786009)(66476007)(476003)(55016002)(4326008)(6436002)(52536014)(8676002)(81156014)(66066001)(7736002)(33656002)(3846002)(74316002)(68736007)(53936002)(9686003)(305945005)(6116002)(54906003)(486006)(102836004)(99286004)(186003)(66946007)(316002)(6506007)(66446008)(256004)(7696005)(14444005)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0801MB2079; H:VI1PR0801MB2127.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: P9fL7mqpYufFitTEvkQLp0pMQZp9ckQmdvt7DtsoHzRHj8PAuFNwM+O8g4nlJU/3thfIbNy3a9UX68C9WjiJcVXDubLzJdxgF4btt3ThPQMrz2uQzIp6CYKlp9MejFhYmfZpTksgVfodlNBZvujmjksGrTt1vC+/3/d0uwhkdY5kJrBek8q7rco7r5KWSK2yzmVHaeDOoi8696RhnpcaJDus/U2IyVwRbOnhIvCahG97eBXmlLt0RF29VFsHNsajH6o2xyKZ60jT3nvce2ulpHy6fBZj40RqcNHNl674Oe/8wCpboplFQEsEj5GIQfhlCkX+XIn1H8pdUHM5upZaFqkMlCLR8HENa4pFgsJjLX3vDDECyNw++cOET26Gv+oL880sg+gL2QGrgrhx2/S63rkstfTgARcoAOt8jh+kxoU= MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ae7d788d-c414-450a-0d5c-08d71444ae8f Currently the Arm backend selects the alternative sched pressure algorithm. The issue is that this doesn't take register pressure into account, and so it causes significant additional spilling on Arm where there are only 14 allocatable registers. SPEC2006 shows significant codesize reduction with the default pressure algorithm, so switch back to that. PR77308 shows ~800 fewer instructions. SPECINT2006 is ~0.6% faster on Cortex-A57 together with the other DImode patches. Overall SPEC codesize is 1.1% smaller. Bootstrap & regress OK on arm-none-linux-gnueabihf --with-cpu=cortex-a57 ChangeLog: 2019-07-29 Wilco Dijkstra * config/arm/arm.c (arm_option_override): Don't override sched pressure algorithm. diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 81286cadf32f908e045d704128c5e06842e0cc92..628cf02f23fb29392a63d87f561c3ee2fb73a515 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -3575,11 +3575,6 @@ arm_option_override (void) if (use_neon_for_64bits == 1) prefer_neon_for_64bits = true; - /* Use the alternative scheduling-pressure algorithm by default. */ - maybe_set_param_value (PARAM_SCHED_PRESSURE_ALGORITHM, SCHED_PRESSURE_MODEL, - global_options.x_param_values, - global_options_set.x_param_values); - /* Look through ready list and all of queue for instructions relevant for L2 auto-prefetcher. */ int param_sched_autopref_queue_depth;