| Message ID | VI1PR0801MB2031461F4FC6FAF4C03E0C24FFC20@VI1PR0801MB2031.eurprd08.prod.outlook.com |
|---|---|
| State | New |
| Headers | show |
On 13/06/17 11:12, Tamar Christina wrote: > Hi All, > > This fixes the failing test gcc.target/arm/sdiv_costs_1.c by > requiring arm_arch_v8a_ok. > > > OK for trunk? > Ok. Thanks, Kyrill > gcc/testsuite/ > 2017-06-13 Tamar Christina <tamar.christina@arm.com> > > * gcc.target/arm/sdiv_costs_1.c: > Require arm_arch_v8a_ok and add march option. > > Thanks, > Tamar
On 13 June 2017 at 12:13, Kyrill Tkachov <kyrylo.tkachov@foss.arm.com> wrote: > > On 13/06/17 11:12, Tamar Christina wrote: >> >> Hi All, >> >> This fixes the failing test gcc.target/arm/sdiv_costs_1.c by >> requiring arm_arch_v8a_ok. >> >> >> OK for trunk? >> > > Ok. > Thanks, > Kyrill > > >> gcc/testsuite/ >> 2017-06-13 Tamar Christina <tamar.christina@arm.com> >> >> * gcc.target/arm/sdiv_costs_1.c: >> Require arm_arch_v8a_ok and add march option. >> Shouldn't you use add_options_for_arm_arch_v8a instead? >> Thanks, >> Tamar > >
> >> * gcc.target/arm/sdiv_costs_1.c: > >> Require arm_arch_v8a_ok and add march option. > >> > > Shouldn't you use > add_options_for_arm_arch_v8a instead? Done, committed as r249214. I don't quite understand the difference, but this test suite does quite counter intuitive things. > > >> Thanks, > >> Tamar > > > >
diff --git a/gcc/testsuite/gcc.target/arm/sdiv_costs_1.c b/gcc/testsuite/gcc.target/arm/sdiv_costs_1.c index 3920590dfcce975aaf7cbe7a4d056df203b7ca2e..9d094ac0c1d12193e8db82120d266bae5b5bf297 100644 --- a/gcc/testsuite/gcc.target/arm/sdiv_costs_1.c +++ b/gcc/testsuite/gcc.target/arm/sdiv_costs_1.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ -/* { dg-options "-O3" } */ -/* { dg-require-effective-target arm_v8_vfp_ok } */ +/* { dg-options "-O3 -march=armv8-a" } */ +/* { dg-require-effective-target arm_arch_v8a_ok } */ /* Both sdiv and udiv can be used here, so prefer udiv. */ int f1 (unsigned char *p)