From patchwork Mon May 14 11:33:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 158968 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 6C98CB703E for ; Mon, 14 May 2012 21:34:31 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1337600071; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Date: From:To:Subject:Message-ID:MIME-Version:Content-Type: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=rUlREK7rZ6jHCFqo3uJm tDV7dI8=; b=SRdlaDdzf1tkOpyDDVNOPJuAThgKvUg5E6qL/h4FyPEoso7q2Hy0 fzooMZtFL900Cjql3HXkiwiZUZWGqy77QbP33WMZMzO2yk7wfyNR15txMFtMeL1T UFDS1mdYXoCsD1OZ/aD+RJ3pWPNx3Rak/7yzZJyZV3iC8SIZavUKPgE= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=E4hkSjZxa4kqQcrHNnAJTVtDTCqWeEfCUoEkumQZLwy0lvU7i60Drxzpacrm69 iLrLLz02Vj5FjFK1h6kJf5cFQON+DVctYa5JR7Q3LSqcMOlwiOQ0H63I1b3hexQH FOiVlPEBOMXW9VDdbX16xY+IC5wnC6zBeij2w0HN8dWKo=; Received: (qmail 19149 invoked by alias); 14 May 2012 11:33:53 -0000 Received: (qmail 19132 invoked by uid 22791); 14 May 2012 11:33:52 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 May 2012 11:33:28 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id DD46F89994 for ; Mon, 14 May 2012 13:33:27 +0200 (CEST) Date: Mon, 14 May 2012 13:33:27 +0200 (CEST) From: Richard Guenther To: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix PR53340 Message-ID: MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Boolean logic is hard ... this fixes a bug in the previous re-org of clean/op_valid_in_sets. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2012-05-14 Richard Guenther PR tree-optimization/53340 * tree-ssa-pre.c (op_valid_in_sets): Fix error in last commit. Index: gcc/tree-ssa-pre.c =================================================================== --- gcc/tree-ssa-pre.c (revision 187449) +++ gcc/tree-ssa-pre.c (working copy) @@ -2007,8 +2007,8 @@ op_valid_in_sets (bitmap_set_t set1, bit if (op && TREE_CODE (op) == SSA_NAME) { unsigned int value_id = VN_INFO (op)->value_id; - if (!bitmap_set_contains_value (set1, value_id) - || (set2 && !bitmap_set_contains_value (set2, value_id))) + if (!(bitmap_set_contains_value (set1, value_id) + || (set2 && bitmap_set_contains_value (set2, value_id)))) return false; } return true;