From patchwork Sun Apr 14 20:27:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Moore, Catherine" X-Patchwork-Id: 236470 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 24FDC2C00A0 for ; Mon, 15 Apr 2013 06:27:26 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; q=dns; s= default; b=r3oES2/5VjWVrDxju+jMuyFKZXbgTo2q5RddVzSRpm4zZwdK4iU5V nTa2Qyh8LGvCfr0qmDPmb3kHPD8j81JpO+KUpO4mpxU76Vw1RorKz00Zip1vW4HV jq1VVNGUKN5tOsRMRJdhlHRZDTYsPL9uImQsASxUGzRJS0wh2SVXQk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s=default; bh=ItS+/eRoHWEuzzpETdEO/zfPYgw=; b=yqFvlCcv2AlKL4puy3b1N7VpC58c ehxBIDRuS6Di2d86KzhpVU56IUtCh4jXXVf+t77pIDULJ5y0KES2Wov0jWHiQ2VQ jKZeji8I5ijl+34y/4Rpl4cMCix8tuQiBmUBCvNsC7M3z65MDlN8Ky/8uIf/DA5a 6jgLwh5gYpMFznM= Received: (qmail 4191 invoked by alias); 14 Apr 2013 20:27:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 4177 invoked by uid 89); 14 Apr 2013 20:27:18 -0000 X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 14 Apr 2013 20:27:11 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1URTW1-0002jE-PK from Catherine_Moore@mentor.com ; Sun, 14 Apr 2013 13:27:09 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 14 Apr 2013 13:27:09 -0700 Received: from NA-MBX-04.mgc.mentorg.com ([169.254.4.74]) by SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.168]) with mapi id 14.01.0289.001; Sun, 14 Apr 2013 13:27:09 -0700 From: "Moore, Catherine" To: David Daney CC: "Rozycki, Maciej" , "gcc-patches@gcc.gnu.org" , Richard Sandiford , "Moore, Catherine" Subject: RE: [Patch] [MIPS] Fix Many warnings in MIPS port (Was: [PATCH] [MIPS] microMIPS gcc support) Date: Sun, 14 Apr 2013 20:27:07 +0000 Message-ID: References: <516898BB.5050903@gmail.com> In-Reply-To: <516898BB.5050903@gmail.com> MIME-Version: 1.0 > -----Original Message----- > From: David Daney [mailto:ddaney.cavm@gmail.com] > Sent: Friday, April 12, 2013 7:29 PM > To: Moore, Catherine > Cc: Rozycki, Maciej; gcc-patches@gcc.gnu.org; Richard Sandiford > Subject: Re: [Patch] [MIPS] Fix Many warnings in MIPS port (Was: [PATCH] > [MIPS] microMIPS gcc support) > > On 04/12/2013 03:07 PM, Moore, Catherine wrote: > > Hi David, > > Please try the attached patch. Is this OK to checkin? > > I don't think it is correct... And you would be right. I attached the wrong patch. Try this one instead: Sorry for the confusion. Catherine > > > > 2013-04-12 Catherine Moore > > > > * configure.ac (.micromips support): Add --fatal-warnings option. > > * configure: Regenerate. > > > > > [...] > > > > Index: configure.ac > > > ========================================================== > ========= > > --- configure.ac (revision 197936) > > +++ configure.ac (working copy) > > @@ -4051,6 +4051,12 @@ LCF0: > > [AC_DEFINE(HAVE_AS_NO_SHARED, 1, > > [Define if the assembler understands -mno-shared.])]) > > > > + gcc_GAS_CHECK_FEATURE([.micromips support], > > + gcc_cv_as_micromips_support,,[--fatal-warnings], > > + [.set micromips],, > > + [AC_DEFINE(HAVE_GAS_MICROMIPS, 1, > > + [Define if your assembler supports the .set micromips > > + directive])]) > > + > > There is already an existing check. Just modify that one instead of adding a > duplicate. Something like the attached (untested) > > > gcc_GAS_CHECK_FEATURE([.gnu_attribute support], > > gcc_cv_as_mips_gnu_attribute, [2,18,0],, > > [.gnu_attribute 4,1],, > > > I didn't have time to test this yet. I may try Monday. > > David Daney Index: configure =================================================================== --- configure (revision 197950) +++ configure (working copy) @@ -17830,7 +17830,7 @@ lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 17831 "configure" +#line 17833 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -17936,7 +17936,7 @@ lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 17937 "configure" +#line 17939 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -25766,7 +25766,7 @@ gcc_cv_as_micromips_support=no if test x$gcc_cv_as != x; then $as_echo '.set micromips' > conftest.s - if { ac_try='$gcc_cv_as $gcc_cv_as_flags -o conftest.o conftest.s >&5' + if { ac_try='$gcc_cv_as $gcc_cv_as_flags --fatal-warnings -o conftest.o conftest.s >&5' { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 (eval $ac_try) 2>&5 ac_status=$? Index: configure.ac =================================================================== --- configure.ac (revision 197950) +++ configure.ac (working copy) @@ -4058,7 +4058,7 @@ [Define if your assembler supports .gnu_attribute.])]) gcc_GAS_CHECK_FEATURE([.micromips support], - gcc_cv_as_micromips_support,,, + gcc_cv_as_micromips_support,,[--fatal-warnings], [.set micromips],, [AC_DEFINE(HAVE_GAS_MICROMIPS, 1, [Define if your assembler supports the .set micromips directive])])