From patchwork Mon Jul 6 20:44:55 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Moore, Catherine" X-Patchwork-Id: 491827 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 2724E1402D2 for ; Tue, 7 Jul 2015 06:45:09 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=vvL61QIZ; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; q=dns; s= default; b=HPYLMM0hMEpNlpS9NQKZQ5a4wfyu7UfRNNI9q05kFUpP6zdprrtmS +U/NvV4+dCICrjRg5Gvua6+j1i9Vhh1yHaTRuz2vzjcopXwr+1zPlTNfj1KoPwQF Xb50uqmS8Mfyfietf+CK9CBK6dEi00LrW9/LA76TpRghNfZVRylT4I= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s=default; bh=N3u6HKqNJuBgEvhnFK1KWMxLFQ4=; b=vvL61QIZMZKB1GjWWYn/WRFWdljq 4PMcYth92gP50wdnaxwCXwmLsCQ0P+bCWRial/pYRLxBJt+XrDgQV8FPjkaH8ji4 36lkS/MHY62slbld35VUw4OjuUHNlAnQEPzsqyDepLRR0PmAIXlif3iAJIJPsdZx 2Neul/Uea+SzXDA= Received: (qmail 108107 invoked by alias); 6 Jul 2015 20:45:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 108075 invoked by uid 89); 6 Jul 2015 20:45:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jul 2015 20:45:01 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1ZCDG4-0006lx-Tt from Catherine_Moore@mentor.com ; Mon, 06 Jul 2015 13:44:56 -0700 Received: from NA-MBX-01.mgc.mentorg.com ([169.254.1.24]) by SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) with mapi id 14.03.0224.002; Mon, 6 Jul 2015 13:44:56 -0700 From: "Moore, Catherine" To: Andrew Bennett , "gcc-patches@gcc.gnu.org" CC: Matthew Fortune Subject: RE: [PATCH] MIPS: Do not generate micromips code for the no-smartmips-lwxs.c testcase Date: Mon, 6 Jul 2015 20:44:55 +0000 Message-ID: References: <0DA23CC379F5F945ACB41CF394B98277210EEB37@LEMAIL01.le.imgtec.org> In-Reply-To: <0DA23CC379F5F945ACB41CF394B98277210EEB37@LEMAIL01.le.imgtec.org> MIME-Version: 1.0 > -----Original Message----- > From: Andrew Bennett [mailto:Andrew.Bennett@imgtec.com] > Sent: Monday, July 06, 2015 9:34 AM > To: gcc-patches@gcc.gnu.org > Cc: Matthew Fortune; Moore, Catherine > Subject: [PATCH] MIPS: Do not generate micromips code for the no- > smartmips-lwxs.c testcase > > Hi, > > The LWXS instruction is part of the micromips ISA which means it is valid to > generate it for the no-smartmips-lwxs.c testcase. I have updated the dg- > options for the test to ensure that it does not generate micromips code. > > I have tested this on the mips-mti-elf target using mips32r2/{-mno- > micromips/-mmicromips} test options and there are no new regressions. > > The patch and ChangeLog are below. > > Ok to commit? > > > > Many thanks, > > > Andrew > > > > testsuite/ > * gcc.target/mips/no-smartmips-lwxs.c: Add -mno-micromips to dg- > options. > > > diff --git a/gcc/testsuite/gcc.target/mips/no-smartmips-lwxs.c > b/gcc/testsuite/gcc.target/mips/no-smartmips-lwxs.c > index ecf856e..6701a1c 100644 > --- a/gcc/testsuite/gcc.target/mips/no-smartmips-lwxs.c > +++ b/gcc/testsuite/gcc.target/mips/no-smartmips-lwxs.c > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-mno-smartmips" } */ > +/* { dg-options "-mno-smartmips -mno-micromips" } */ > > NOMIPS16 int scaled_indexed_word_load (int a[], int b) { > Hi Andrew, Instead of adding the -mno-micromips option to dg-options, please change the MIPS16 attribute to NOCOMPRESSION. OK with that change. Catherine Index: gcc.target/mips/no-smartmips-lwxs.c =================================================================== --- gcc.target/mips/no-smartmips-lwxs.c (revision 452061) +++ gcc.target/mips/no-smartmips-lwxs.c (working copy) @@ -1,7 +1,7 @@ /* { dg-do compile } */ /* { dg-options "-mno-smartmips" } */ -NOMIPS16 int scaled_indexed_word_load (int a[], int b) +NOCOMPRESSION int scaled_indexed_word_load (int a[], int b) { return a[b]; }