From patchwork Wed May 28 10:55:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evgeny Stupachenko X-Patchwork-Id: 353336 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id BEFF71400AA for ; Wed, 28 May 2014 20:56:07 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=qzTjT3n+6/+lRU0XpZ uKXAPu9fTi0ZEyxQxQ60LcZO/Urid4MIB2Pjncl9rZCgkyCZ9DZCFIp3oKX+tw1M IsNIKCSSLV0quWoU0x7QD+putDjLBWFa9GWsh9wStBVMU3RXL76eyVKqMR9lScr3 ZjHfC7ESRQSaM+NHtQNYSfJKI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=1DIJIBMxLhSC3TKW2D/RjwAy jKA=; b=c9CZhnMpUj8YgBr53T8zNRJ2GM85mmFVH14FaS4CkKUJVh8Qobun8wY6 Meie8GMMpdQOP51Q7KoOu04B2HuMHRjyOE9a10cTKhqS3dOFsjOCBv42qo7NcgSX Dp4wIowBYuhdvYAIyFzPOmwqSVAU8ajdJkrbrHBp/WHkzFE8plA= Received: (qmail 7908 invoked by alias); 28 May 2014 10:55:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 7814 invoked by uid 89); 28 May 2014 10:55:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f50.google.com Received: from mail-oa0-f50.google.com (HELO mail-oa0-f50.google.com) (209.85.219.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 28 May 2014 10:55:53 +0000 Received: by mail-oa0-f50.google.com with SMTP id i7so11015217oag.9 for ; Wed, 28 May 2014 03:55:51 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.81.200 with SMTP id c8mr18936024oey.75.1401274551128; Wed, 28 May 2014 03:55:51 -0700 (PDT) Received: by 10.76.18.209 with HTTP; Wed, 28 May 2014 03:55:51 -0700 (PDT) In-Reply-To: References: <20140516132154.GA10386@tucnak.redhat.com> Date: Wed, 28 May 2014 14:55:51 +0400 Message-ID: Subject: Re: [PATCH, PR52252] Vectorization for load/store groups of size 3. From: Evgeny Stupachenko To: Jakub Jelinek Cc: Rainer Orth , Richard Biener , GCC Patches , Uros Bizjak X-IsSubscribed: yes missed some line tails. Correct patch below: /* { dg-final { cleanup-tree-dump "vect" } } */ On Wed, May 28, 2014 at 2:51 PM, Evgeny Stupachenko wrote: > Does the following fix ok? > > 2014-05-28 Evgeny Stupachenko > > * gcc.dg/vect/pr52252-ld.c: Fix target and options for the test. > > diff --git a/gcc/testsuite/gcc.dg/vect/pr52252-ld.c > b/gcc/testsuite/gcc.dg/vect/pr52252-ld.c > index 6e3cb52..57e8468 100644 > --- a/gcc/testsuite/gcc.dg/vect/pr52252-ld.c > +++ b/gcc/testsuite/gcc.dg/vect/pr52252-ld.c > @@ -1,6 +1,6 @@ > /* { dg-do compile } */ > -/* { dg-options "-O2 -g -ftree-vectorize -mssse3 > -fdump-tree-vect-details" { target { i?86-*-* x86_64-* > - > +/* { dg-options "-O2 -g -ftree-vectorize -fdump-tree-vect-details" } */ > +/* { dg-additional-options "-mssse3" { target { i?86-*-* x86_64-*-* } } } */ > #define byte unsigned char > > void > @@ -26,5 +26,5 @@ matrix_mul (byte *in, byte *out, int size) > } > } > > -/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" } } */ > +/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { > target { i?86-*-* x86_64-*-* } } } > /* { dg-final { cleanup-tree-dump "vect" } } */ > > On Fri, May 16, 2014 at 5:21 PM, Jakub Jelinek wrote: >> On Fri, May 16, 2014 at 03:11:05PM +0200, Rainer Orth wrote: >>> Hi Evgeny, >>> >>> > Does the following fix ok? >>> > >>> > 2014-05-16 Evgeny Stupachenko >>> > >>> > * gcc.dg/vect/pr52252-ld.c: Fix target for the test. >>> > >>> > >>> > diff --git a/gcc/testsuite/gcc.dg/vect/pr52252-ld.c >>> > b/gcc/testsuite/gcc.dg/vect/pr52252-ld.c >>> > index 6e3cb52..301433b 100644 >>> > --- a/gcc/testsuite/gcc.dg/vect/pr52252-ld.c >>> > +++ b/gcc/testsuite/gcc.dg/vect/pr52252-ld.c >>> > @@ -1,5 +1,6 @@ >>> > /* { dg-do compile } */ >>> > -/* { dg-options "-O2 -g -ftree-vectorize -mssse3 >>> > -fdump-tree-vect-details" { target { i?86-*-* x86_64-*-* } } } */ >>> > +/* { dg-options "-O2 -g -ftree-vectorize -mssse3 -fdump-tree-vect-details" } */ >>> > +/* { dg-skip-if "why" { ! { x86_64-*-* i?86-*-* } } } */ >>> >>> If the test is really x86 specific, move it to gcc.target/i386 and >>> remove the dg-skip-if. Otherwise, add an explanation for skipping the >>> test on other targets to the first arg of dg-skip-if. This is supposed >>> to be a comment stating why the test is skipped, not "why" literally. >> >> Well, I don't see anything i?86/x86_64 specific on the test. What >> is specific is the -mssse3, which supposedly should be added through >> /* { dg-additional-options "-mssse3" { target { i?86-*-* x86_64-*-* } } } */ >> and then perhaps the test might not necessarily be vectorized (so the >> dg-final line may need target guard as well. >> But, I see no reason not to try to compile this on other targets. >> >> Jakub diff --git a/gcc/testsuite/gcc.dg/vect/pr52252-ld.c b/gcc/testsuite/gcc.dg/vect/pr52252-ld.c index 6e3cb52..57e8468 100644 --- a/gcc/testsuite/gcc.dg/vect/pr52252-ld.c +++ b/gcc/testsuite/gcc.dg/vect/pr52252-ld.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ -/* { dg-options "-O2 -g -ftree-vectorize -mssse3 -fdump-tree-vect-details" { target { i?86-*-* x86_64-*-* } } } */ - +/* { dg-options "-O2 -g -ftree-vectorize -fdump-tree-vect-details" } */ +/* { dg-additional-options "-mssse3" { target { i?86-*-* x86_64-*-* } } } */ #define byte unsigned char void @@ -26,5 +26,5 @@ matrix_mul (byte *in, byte *out, int size) } } -/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" } } */ +/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target { i?86-*-* x86_64-*-* } } } } */