diff mbox

PATCH: Check __GLIBC__ when using __SIGRTMIN in generic-morestack.c

Message ID CAMe9rOpj2VuQMAkp6w4DfQoWzsaS=6LD6dNw7PRWvhsPHiw76w@mail.gmail.com
State New
Headers show

Commit Message

H.J. Lu Dec. 14, 2011, 6:50 p.m. UTC 
On Wed, Dec 14, 2011 at 10:38 AM, Ian Lance Taylor <iant@google.com> wrote:
> "H.J. Lu" <hongjiu.lu@intel.com> writes:
>
>> Since __SIGRTMIN is for the NPTL threading library, should we check
>> __GLIBC__ instead of __linux__?  Otherwise, it fails to build with
>> Bionic library on Android.
>
> This is OK.  But please just fix the existing comment to say glibc
> instead of Linux, or something like that.  No need for the new FIXME
> comment as far as I can see.
>

This is what I checked in.  Also OK for gcc-4_6-branch after a day or 2?

Thanks.

Comments

Ian Lance Taylor Dec. 14, 2011, 7:17 p.m. UTC | #1 
"H.J. Lu" <hjl.tools@gmail.com> writes:

> On Wed, Dec 14, 2011 at 10:38 AM, Ian Lance Taylor <iant@google.com> wrote:
>> "H.J. Lu" <hongjiu.lu@intel.com> writes:
>>
>>> Since __SIGRTMIN is for the NPTL threading library, should we check
>>> __GLIBC__ instead of __linux__?  Otherwise, it fails to build with
>>> Bionic library on Android.
>>
>> This is OK.  But please just fix the existing comment to say glibc
>> instead of Linux, or something like that.  No need for the new FIXME
>> comment as far as I can see.
>>
>
> This is what I checked in.  Also OK for gcc-4_6-branch after a day or 2?

Sure.

Ian
diff mbox

Patch

Index: generic-morestack.c
===================================================================
--- generic-morestack.c	(revision 182341)
+++ generic-morestack.c	(working copy)
@@ -507,8 +507,8 @@  __generic_morestack_set_initial_sp (void
   sigemptyset (&__morestack_initial_sp.mask);

   sigfillset (&__morestack_fullmask);
-#ifdef __linux__
-  /* On Linux, the first two real time signals are used by the NPTL
+#ifdef __GLIBC__
+  /* In glibc, the first two real time signals are used by the NPTL
      threading library.  By taking them out of the set of signals, we
      avoiding copying the signal mask in pthread_sigmask.  More
      importantly, pthread_sigmask uses less stack space on x86_64.  */
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 182341)
+++ ChangeLog	(working copy)
@@ -1,3 +1,8 @@ 
+2011-12-14  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* generic-morestack.c (__generic_morestack_set_initial_sp): Check
+	__GLIBC__ instead of __linux__ when using __SIGRTMIN.
+
 2011-12-14  Georg-Johann Lay  <avr@gjlay.de>

 	PR target/49313