From patchwork Thu Jul 14 03:07:06 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 104625 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 37412B6F68 for ; Thu, 14 Jul 2011 13:07:25 +1000 (EST) Received: (qmail 19603 invoked by alias); 14 Jul 2011 03:07:22 -0000 Received: (qmail 19589 invoked by uid 22791); 14 Jul 2011 03:07:21 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qy0-f182.google.com (HELO mail-qy0-f182.google.com) (209.85.216.182) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Jul 2011 03:07:07 +0000 Received: by qyk38 with SMTP id 38so3906858qyk.20 for ; Wed, 13 Jul 2011 20:07:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.216.148 with SMTP id hi20mr1560900qcb.48.1310612826675; Wed, 13 Jul 2011 20:07:06 -0700 (PDT) Received: by 10.229.71.157 with HTTP; Wed, 13 Jul 2011 20:07:06 -0700 (PDT) In-Reply-To: References: <4E1B37C3.3030607@redhat.com> <4E1DD0D6.3040003@redhat.com> Date: Wed, 13 Jul 2011 20:07:06 -0700 Message-ID: Subject: Re: [build] Move crtfastmath to toplevel libgcc From: "H.J. Lu" To: Rainer Orth Cc: Richard Henderson , gcc-patches@gcc.gnu.org, Paolo Bonzini , Ian Lance Taylor , Uros Bizjak , Steve Ellcey , Richard Sandiford , Eric Botcazou X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Wed, Jul 13, 2011 at 11:50 AM, H.J. Lu wrote: > On Wed, Jul 13, 2011 at 10:12 AM, Rainer Orth > wrote: >> Richard Henderson writes: >> >>> On 07/13/2011 09:57 AM, Rainer Orth wrote: >>>> Do you think the revised crtfastmath patch is safe enough to commit >>>> together to avoid this mess? >>> >>> Probably. >> >> Ok.  I'll will take this on me to get us out of this mess.  It has >> survived i386-pc-solaris2.11, sparc-sun-solaris2.11, >> x86_64-unknown-linux-gnu, and i386-apple-darwin9.8.0 bootstraps, so the >> risk seems acceptable. >> >>>> +# -frandom-seed is necessary to keep the mangled name of the constructor on >>>> +# Tru64 Unix stable, but harmless otherwise. >>> >>> Instead of implying permanent stability, I'd mention bootstrap comparison >>> failures specifically. >> >> Ok, will do. > > I think your patch caused: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49739 > I am checking in this patch from Rainer if it bootstraps on Linux/ia32. Index: config.gcc =================================================================== --- config.gcc (revision 176260) +++ config.gcc (working copy) @@ -1304,6 +1304,9 @@ i[34567]86-*-linux* | i[34567]86-*-kfree esac else tm_file="${tm_file} i386/gnu-user.h i386/linux.h" + # This is a hack to avoid a configuration mismatch + # until the toplevel libgcc move is complete. + extra_parts="${extra_parts} crtprec32.o crtprec64.o crtprec80.o crtfastmath.o" fi ;;