From patchwork Wed Dec 10 19:12:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ilya Enkovich X-Patchwork-Id: 419826 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 98BE11400B7 for ; Thu, 11 Dec 2014 06:12:18 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; q=dns; s= default; b=VZr4Ks74/gpX9IsjAwEkkftxLAvwG/xnQ81YoSFfu12WZwtwBExvW +XQTc4EmMW06HOzb0+Ksz0fdsaCqFtyA1BhhhkO/BchoPwNgQgr5DGFXmXpVAuXt art3RckOXR0hU4gE1f8PIe4cIclK0UfA+J8SxLKvmVYkkhXrfS/m3k= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; s=default; bh=/Px7FZ5LFMFSceSvaSqgiG2qkH8=; b=yQoUHFqArDcRBerd6xY5/hO8GLTB TeygTQd50abEEO25lnmM2rzeYgPEFH6/D1H0QiSzr2sWK7u6WIPjjlOkGAuV+5Bz ofyeYFKoiU5gb3V1oFU3490xS4KmvSL9pMioCwb6DlaE7fWZbMvZZqjN+KHPgxeF HbLL2GbaJXI00bQ= Received: (qmail 11049 invoked by alias); 10 Dec 2014 19:12:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 11033 invoked by uid 89); 10 Dec 2014 19:12:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f179.google.com Received: from mail-ig0-f179.google.com (HELO mail-ig0-f179.google.com) (209.85.213.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 10 Dec 2014 19:12:09 +0000 Received: by mail-ig0-f179.google.com with SMTP id r2so3486507igi.6 for ; Wed, 10 Dec 2014 11:12:07 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.50.82.66 with SMTP id g2mr27330374igy.19.1418238727462; Wed, 10 Dec 2014 11:12:07 -0800 (PST) Received: by 10.64.233.70 with HTTP; Wed, 10 Dec 2014 11:12:07 -0800 (PST) In-Reply-To: <20141210182925.GA10616@arm.com> References: <20141202140151.GF2963@msticlxl57.ims.intel.com> <20141210180730.GA29185@arm.com> <20141210182925.GA10616@arm.com> Date: Wed, 10 Dec 2014 22:12:07 +0300 Message-ID: Subject: Re: [PATCH, CHKP] Fix instrumentation clones privatization From: Ilya Enkovich To: James Greenhalgh Cc: Andreas Schwab , gcc-patches X-IsSubscribed: yes 2014-12-10 21:29 GMT+03:00 James Greenhalgh : > On Wed, Dec 10, 2014 at 06:19:08PM +0000, Ilya Enkovich wrote: >> 2014-12-10 21:07 GMT+03:00 James Greenhalgh : >> > In the interests of breaking us out of this loop... >> > >> > At least: {arm-none-linux-gnueabihf, arm-none-eabi, >> > aarch64-none-linux-gnueabi, aarch64-none-elf, aarch64_be-none-elf} >> > fail for me. >> >> Hello James, >> >> Could you please attach a gcc.log file for one of your runs? > > Sure, see below. > > However, the problem is your dg-require-effective-target line for the test. > > From the documentation: > > { dg-require-effective-target keyword [{ selector }] } > Skip the test if the test target, including current multilib flags, is not > covered by the effective-target keyword. If the directive includes the > optional ‘{ selector }’ then the effective-target test is only performed if > the target system matches the selector. > > So what you've written is really the opposite of what you meant :) Yep, you are right! I wanted to have this target selector in dg-lto-do, but it doesn't support selectors and thus I moved it assuming effect would be the same. Thanks a lot for help! Committed as obvious: 2014-12-10 Ilya Enkovich * gcc.dg/lto/chkp-privatize_0.c: Remove unneeded selector from target check. Thanks, Ilya > > i.e. > > /* { dg-require-effective-target mpx { target { i?86-*-* x86_64-*-* } } } */ > > Should look more like: > > /* { dg-require-effective-target mpx } */ > > Which gets me the UNSUPPORTED I expect to see for this test. > > Cheers, > James > > --- > Executing on host: /work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/xgcc -B/work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/ -fno-diagnostics-show-caret -fdiagnostics-color=never -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx -c -specs=aem-ve.specs -mcmodel=small -o c_lto_chkp-privatize_0.o /work/gcc-clean/src/gcc/gcc/testsuite/gcc.dg/lto/chkp-privatize_0.c (timeout = 300) > spawn /work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/xgcc -B/work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/ -fno-diagnostics-show-caret -fdiagnostics-color=never -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx -c -specs=aem-ve.specs -mcmodel=small -o c_lto_chkp-privatize_0.o /work/gcc-clean/src/gcc/gcc/testsuite/gcc.dg/lto/chkp-privatize_0.c > xgcc: error: unrecognized command line option '-mmpx' > compiler exited with status 1 > output is: > xgcc: error: unrecognized command line option '-mmpx' > > FAIL: gcc.dg/lto/chkp-privatize c_lto_chkp-privatize_0.o assemble, -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx > Executing on host: /work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/xgcc -B/work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/ -fno-diagnostics-show-caret -fdiagnostics-color=never -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx -c -specs=aem-ve.specs -mcmodel=small -o c_lto_chkp-privatize_1.o /work/gcc-clean/src/gcc/gcc/testsuite/gcc.dg/lto/chkp-privatize_1.c (timeout = 300) > spawn /work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/xgcc -B/work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/ -fno-diagnostics-show-caret -fdiagnostics-color=never -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx -c -specs=aem-ve.specs -mcmodel=small -o c_lto_chkp-privatize_1.o /work/gcc-clean/src/gcc/gcc/testsuite/gcc.dg/lto/chkp-privatize_1.c > xgcc: error: unrecognized command line option '-mmpx' > compiler exited with status 1 > output is: > xgcc: error: unrecognized command line option '-mmpx' > > FAIL: gcc.dg/lto/chkp-privatize c_lto_chkp-privatize_1.o assemble, -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx > UNRESOLVED: gcc.dg/lto/chkp-privatize c_lto_chkp-privatize_0.o-c_lto_chkp-privatize_1.o link -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx > UNRESOLVED: gcc.dg/lto/chkp-privatize c_lto_chkp-privatize_0.o-c_lto_chkp-privatize_1.o execute -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx > > > diff --git a/gcc/testsuite/gcc.dg/lto/chkp-privatize_0.c b/gcc/testsuite/gcc.dg/lto/chkp-privatize_0.c index 4c899e8..ad9fdaa 100644 --- a/gcc/testsuite/gcc.dg/lto/chkp-privatize_0.c +++ b/gcc/testsuite/gcc.dg/lto/chkp-privatize_0.c @@ -1,5 +1,5 @@ /* { dg-lto-do link } */ -/* { dg-require-effective-target mpx { target { i?86-*-* x86_64-*-* } } } */ +/* { dg-require-effective-target mpx } */ /* { dg-lto-options { { -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx } } } */ static int