From patchwork Mon Feb 8 21:44:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikael Pettersson X-Patchwork-Id: 1437922 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=glyET1Rw; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DZKLN5scPz9sBJ for ; Tue, 9 Feb 2021 08:44:43 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1F0143896C2D; Mon, 8 Feb 2021 21:44:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F0143896C2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1612820681; bh=r6FSAg64V1HwW+9u/ejwqNNd/8kGI81ZKKipDNrHvoM=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=glyET1RwyLPyxSOdsptZFm27WPDOBhLMIbC4A2mNXcXGgGz786KOkl2q2rOCzsY5u UTETUhZAzQywZDwbC0UyUI1viR0Q5OMAVCTugMlXts2v+YYNBAQ9znD1K5E7lhV4l0 xlOVb/ssn63I4JPTcWlUqogmbG53pXnj5GlsAX5Y= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 91F813894C22 for ; Mon, 8 Feb 2021 21:44:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 91F813894C22 Received: by mail-ot1-x329.google.com with SMTP id l23so3966494otn.10 for ; Mon, 08 Feb 2021 13:44:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=r6FSAg64V1HwW+9u/ejwqNNd/8kGI81ZKKipDNrHvoM=; b=iihRzI3QR/mo/aroNA28wTM+86nDKjKOXs+DxGfK7ym2TekFyBiCFvHiCvQGgPYNHw u9w3PJ73wnQp7iw4foKfwWQ4dxxypDlbluBKpmtN8wx8quXTK8MxqFm/wERT4KazrCJT yrRRDPyVxnglSge024tqT/wnKx7CDiELwi2l1iAup65FyzPBTo6hZHYAr6nGUtZy4iOd O7n6bGaJHs+SatassdiIrwzgC5gjdzv0VegH5c669RNGGo9jGykQoUYk1G1INWruAyMw VfsDXktgnVw7uw9Zg/c02PieRzjZm6+nhS7lkwH9anLeA06TCGhOKw70Q5y/Lqps8k0a Klgg== X-Gm-Message-State: AOAM531zHk3lv8Nxv+Fx9/DrIzAwVEBOyPDYp5ybOHIuZu6T+rLGC2n7 7PAYvBk2oMfVLDJ83MWO3flqolDkumjzzIgjvwnh1vHb2ctL1Q== X-Google-Smtp-Source: ABdhPJynBj1nU2OfdVjxvaBsdoL4wn8WHwuJY/LVzmPZGQoidV1ZxhcmT2fRBQcvIBSGjjVJsB54o4rkiZIzzJKNhKQ= X-Received: by 2002:a05:6830:236b:: with SMTP id r11mr14556605oth.370.1612820677670; Mon, 08 Feb 2021 13:44:37 -0800 (PST) MIME-Version: 1.0 Date: Mon, 8 Feb 2021 22:44:26 +0100 Message-ID: Subject: [PATCH] don't enable DWARF5 by default on Windows (PR98860) To: GCC Patches X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mikael Pettersson via Gcc-patches From: Mikael Pettersson Reply-To: Mikael Pettersson Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" PR98860 is a gcc-11 regression where bootstrap fails on Windows since the switch to enable DWARF5 by default. The symptoms are that executables generated by the stage1 compiler fail to run with "Exec format error", which confuses subsequent configure steps and causes hard errors. This happens even with the very latest binutils master. Fixed by updating SUBTARGET_OVERRIDE_OPTIONS to set dwarf_version to 4 unless the user explicitly requested another version. I see some other targets did the same. Tested on Cygwin64 and mingw-w64. Ok for master? 2021-02-08 Mikael Pettersson PR bootstrap/98860 * config/i386/cygming.h (SUBTARGET_OVERRIDE_OPTIONS): Override dwarf_version to 4. From 9d1b9e26cc77d325fd5574cb422771588d6aa71f Mon Sep 17 00:00:00 2001 From: Mikael Pettersson Date: Sat, 6 Feb 2021 22:59:43 +0100 Subject: [PATCH] cygming: DWARF5 does not work on Windows --- gcc/config/i386/cygming.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gcc/config/i386/cygming.h b/gcc/config/i386/cygming.h index cfbca34f996..071f83cfd2d 100644 --- a/gcc/config/i386/cygming.h +++ b/gcc/config/i386/cygming.h @@ -209,6 +209,9 @@ along with GCC; see the file COPYING3. If not see #define SUBTARGET_OVERRIDE_OPTIONS \ do { \ flag_pic = TARGET_64BIT ? 1 : 0; \ + /* DWARF5 currently does not work on Windows. */ \ + if (!global_options_set.x_dwarf_version) \ + dwarf_version = 4; \ } while (0) /* Define this macro if references to a symbol must be treated -- 2.26.2