From patchwork Mon Oct 29 18:31:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 195106 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 16FA92C008C for ; Tue, 30 Oct 2012 05:31:43 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1352140304; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:In-Reply-To:References:Date: Message-ID:Subject:From:To:Cc:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=IlGQEfiSS6ihvn7zj+q6OsLtKTA=; b=dOqXNq9hPD8MXWjYT3ltd8ZyrvGahBLpwhh6K2UyQIGCUkleGETxc3CtPGV8rh 9dGfsDzalyFdLHJQTXPFTSkF5WmYpxLhf5j34HGT6YEC7ZLN51xWLmd/tVxRxFTf DIjo58suph7idChNk/+Mq8qWN1IwRZZ00nI+3OLsm2lcQ= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:MIME-Version:Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Cc:Content-Type:X-System-Of-Record:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Ffp6QTrIJEKplzC1HM0sxw/7TWqFJg0GRKZf/wnsmcM6+gNhmfWoh+mYmlHEPH pwD9cas3p31RhjHYPbeGIlTX++PYiULhXE1SP8WB1ZQVLfMTLua89/LrbQqGKXcD fQ7IqhKb5iQT7tT9F4BgDN8uaL8TmfuMgz3NiFmV0VvpM=; Received: (qmail 12135 invoked by alias); 29 Oct 2012 18:31:39 -0000 Received: (qmail 12124 invoked by uid 22791); 29 Oct 2012 18:31:38 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-da0-f47.google.com (HELO mail-da0-f47.google.com) (209.85.210.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Oct 2012 18:31:34 +0000 Received: by mail-da0-f47.google.com with SMTP id s35so2373451dak.20 for ; Mon, 29 Oct 2012 11:31:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=iAZx4zN6nzyXAkmiQ3Q+ZHslBBnouUa2P7FkC9UjhYs=; b=gSUMJNBWJaEdbuBUXx3QaQ8fv1IWocjwx/l6MffPkk2enMoBVEIbWyvrC720QWSy// oc6DhSarIeiYGkK7vGhLplJKf7l88HFARmeIns6gBwAyrhICvn7I3YA2SlyGrieibzO5 HvhBsgQ/ZgzXUp8Bp34/Fhu1oYRzkBfUtZfYaFXCDbO9A6CMlqPXq8ZtBUPtJkPFhJoa khJub+E4fGVjed8YzGnWLq7jjNbsKwT25JbwbdZa0vGFKcPqKUzbnHtPXkBW1P/LuH4E DNWOe4ZOTvP4PrOVZCRItA38BWlXcJCIMbb+nudh4oEbAh4DLCE0gJYXUQhDrCjeaeXa ss0A== MIME-Version: 1.0 Received: by 10.66.85.66 with SMTP id f2mr85620751paz.56.1351535493720; Mon, 29 Oct 2012 11:31:33 -0700 (PDT) Received: by 10.68.238.5 with HTTP; Mon, 29 Oct 2012 11:31:33 -0700 (PDT) In-Reply-To: <20121029.141540.166998117582403244.davem@davemloft.net> References: <20121029.140359.2034263434560495401.davem@davemloft.net> <20121029.141540.166998117582403244.davem@davemloft.net> Date: Mon, 29 Oct 2012 11:31:33 -0700 Message-ID: Subject: Re: [PATCH] Fix libbacktrace on 32-bit sparc From: Ian Lance Taylor To: David Miller Cc: gcc-patches@gcc.gnu.org X-System-Of-Record: true X-Gm-Message-State: ALoCoQnxHqH3iQuuRsJu/O51vIqJk7PYfdhY43dWKfjUL6WIicR2EpHAssfPgKn6HR3ZieZye0mA1Ol1Sxij4zui4VcLifTAPySZINtKAyLLfO9RDHydlU8SZ1XI2lO0wajdZg8Fqxwm4V6ruY3SVACAfzk0ZhO8uH473UEYpiEzLUn4oxUOR+/0rRCyFB9C/rXrlEbS7G3w X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Mon, Oct 29, 2012 at 11:15 AM, David Miller wrote: > From: Ian Lance Taylor > Date: Mon, 29 Oct 2012 11:13:19 -0700 > >> I changed it from vec->base + vec->size. Now it is vec->base >> + size, where size is the aligned version of vec->size. > > It is not. > > You don't modify 'size' at all. Ah, yes, sorry. Could you test this patch? Ian Index: mmap.c =================================================================== --- mmap.c (revision 192945) +++ mmap.c (working copy) @@ -240,7 +240,8 @@ backtrace_vector_release (struct backtra aligned = (size + 7) & ~ (size_t) 7; alc -= aligned - size; - backtrace_free (state, (char *) vec->base + size, alc, error_callback, data); + backtrace_free (state, (char *) vec->base + aligned, alc, + error_callback, data); vec->alc = 0; return 1; }