From patchwork Sat Jul 5 22:42:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 367358 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 62A251400BB for ; Sun, 6 Jul 2014 08:42:21 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=bFgFpcgrAWTx1D2W44 T0S1nxJMKZDS13VL/JYKxnCTWYrPOtb/gzhe0+by4BGKrFQD3/W+rSv7M2kJmQzz UaMPS+bVUMsQKgaLwh6xmnm/xKSrsvDQ5o+DX2HRCzXlopThPamUR5nL3ZjqlTxn GnaLhirVuHRLTauF0TfJFqt3k= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=jbD6GtHQp+/fNTyt4p4TN/BR mmY=; b=AmlZPmhgUMJ0gd6wX8qR8mbr+/Y19sB3qc4xWpEKfnflJLFg7Sv2ulL2 0w2ZjUswVj2EF2iTXwj6Ih9jd+I0sP1ggmms6dizpBiYze+2DiNt5pc6BGbSxnPB nS7HlhkfpKKwCOvDaki4v42d/p3/CiBhhW/gcjht+JhH1EPXBWo= Received: (qmail 15471 invoked by alias); 5 Jul 2014 22:42:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 15420 invoked by uid 89); 5 Jul 2014 22:42:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f54.google.com Received: from mail-oa0-f54.google.com (HELO mail-oa0-f54.google.com) (209.85.219.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 05 Jul 2014 22:42:08 +0000 Received: by mail-oa0-f54.google.com with SMTP id eb12so3008323oac.41 for ; Sat, 05 Jul 2014 15:42:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=/NHUSlD6byc5D/qcHhQqyH6y/Ao8o60g8DUz5WQq/lE=; b=H6Z4nuZqaJA3Iva4eCu9oIYmWVWaVzXdSit6ytMcmz1UE32yDHN9S0puOtBtL8yzvM 1341uqRkZ9hIJzmhQUY60p0kbSbcyR38MRAW1bkH0vmgeLnC72E914abVveMIeCy18+A wQcwXdzZmHdDTmk0m3t9TANIAWdrXlcDEhVKTS2/YkfOMkQcTczlGmJ1JkFmBvDgTkJy nP0H/rxMVEZgv+J8awFnOEuFcyXBvVJvIU9NdR2y+MpEIfE1/8i/qqNJMPqZkCUT/a9Q GhT6ONmXTJV2GdnrRtB9INUs5zTPhSfdd32IGi8yYQhb6JVNFUjGzdzuohZHywjvk8oS I9lQ== X-Gm-Message-State: ALoCoQkHYppGkwwEpv5RsGOi0MtGy9MOm2ipOEtAr4rwVIDV/AJdfQqZfOSd7mNqffFv/Z/NEDxA MIME-Version: 1.0 X-Received: by 10.182.94.209 with SMTP id de17mr21389558obb.60.1404600126414; Sat, 05 Jul 2014 15:42:06 -0700 (PDT) Received: by 10.60.39.228 with HTTP; Sat, 5 Jul 2014 15:42:06 -0700 (PDT) In-Reply-To: <53B52391.4030908@suse.de> References: <53B52391.4030908@suse.de> Date: Sat, 5 Jul 2014 15:42:06 -0700 Message-ID: Subject: Re: [PATCH, libbacktrace]: fix pointer from integer without a cast From: Ian Lance Taylor To: "Duncan Mac-Vicar P." Cc: gcc-patches , zawertun@gmail.com X-IsSubscribed: yes On Thu, Jul 3, 2014 at 2:34 AM, Duncan Mac-Vicar P. wrote: > > the following patch fixes some post-build-checks from our distro build > system, better to upstream it: > > [ 4077s] E: rust 64bit-portability-issue > /home/abuild/rpmbuild/BUILD/rust-0.11.0+git.1403898616.aa1163b/src/libbacktrace/dwarf.c:2690, > 2873, 3005 > [ 4077s] E: rust 64bit-portability-issue > /home/abuild/rpmbuild/BUILD/rust-0.11.0+git.1403898616.aa1163b/src/libbacktrace/elf.c:448, > 493, 970 > [ 4077s] E: rust 64bit-portability-issue > /home/abuild/rpmbuild/BUILD/rust-0.11.0+git.1403898616.aa1163b/src/libbacktrace/fileline.c:75 > > libbacktrace/ChangeLog: > > 2014-07-03 Yaroslav Sidlovsky > * dwarf.c, elf.c, fileline.c: fix pointer from integer without a > cast That error doesn't make much sense and I'm not sure the patch is really right. I don't know what program is generating these messages, but does this patch fix the problem? Ian Index: internal.h =================================================================== --- internal.h (revision 211658) +++ internal.h (working copy) @@ -99,7 +99,7 @@ extern void backtrace_atomic_store_int ( /* We have neither the sync nor the atomic functions. These will never be called. */ -#define backtrace_atomic_load_pointer(p) (abort(), 0) +#define backtrace_atomic_load_pointer(p) (abort(), (void *) NULL) #define backtrace_atomic_load_int(p) (abort(), 0) #define backtrace_atomic_store_pointer(p, v) abort() #define backtrace_atomic_store_size_t(p, v) abort()