From patchwork Thu Oct 17 12:41:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Pengcheng X-Patchwork-Id: 1998572 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bytedance.com header.i=@bytedance.com header.a=rsa-sha256 header.s=google header.b=fGXWnJs2; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XTnXZ5YXgz1xth for ; Thu, 17 Oct 2024 23:42:05 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5A8213858414 for ; Thu, 17 Oct 2024 12:42:03 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com [IPv6:2001:4860:4864:20::2a]) by sourceware.org (Postfix) with ESMTPS id 58D2C3858D37 for ; Thu, 17 Oct 2024 12:41:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58D2C3858D37 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=bytedance.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 58D2C3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::2a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729168899; cv=none; b=dZCMxfjQk8AH9dXrkfu4fP8D94TCPI52rgKwPIL4UcfUDQz12kGOW++VMjQmPt2KyJUUv9Ywf6B6X2H5razwE2bHfR2vNNCvAHBRM+eCXKSmQqV2hrKGqiCE6FTYy8KwsvEf7CWHP39didENn3l2HS3aAWqRPtKUPhopuHWgezo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1729168899; c=relaxed/simple; bh=nrZrcMW0Jzo7x1j828it8odTjYoYgT36bltYnS76smo=; h=DKIM-Signature:From:Mime-Version:Date:Message-ID:Subject:To; b=CUOQb3pUD8St2YBN9MEFzEAjAy9kOODX2OuqBfKv3q4yWwj6dX1gDvBdjtxyvykzOn2CoEOUSdos9VB/qw04dZWGKQmFXosSvDPuVRGe4wBliHltm++NVRXCPrufY9LRXaHtKV0sbY3WY2NhZk4EOyn4lN/ql76DcgzXt8q0cNo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-2891055c448so284284fac.0 for ; Thu, 17 Oct 2024 05:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1729168887; x=1729773687; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=+HMkdRrw4CEG00/vcnNXkb4hHj9tw4MdvtgawamOQ5k=; b=fGXWnJs2oOjVdEFAcuU5XrFqo4Y1VFo05Pcj6Yr9ygTiDYcnthVS9QNZEB0z5b7p6N iXA15LZOHk1Sg3LaMyTAdrAOyOH/LsOxpJiHWxuVCSnBjFjC/m1/28wTYCSdimfh5wqS wwWDaeAzk98mghRH6j4jSMqTtr43N9TK885ECg0MMPN4Zen6VwdfOTb/drcx1z3zUT4A 9YmhIYnhTUJAqoUFbsjYMJ4QhVYZHXhkiIdLrM88hixPSTIVKdJYnQt+AjxXGEWCQH61 QYHMCha2YIslXrKbaXyet3orcjzj2Jp/2wVJQFtgaF6gUlcTrNx46Y6B4f4sVPkilzT4 W8Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729168887; x=1729773687; h=cc:to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+HMkdRrw4CEG00/vcnNXkb4hHj9tw4MdvtgawamOQ5k=; b=VcLx1pEaR9OWfsaci6B5kVRZxCu9A84JvvJ3nv+rEaxOwPctxyJpRD8UNLD1h/oSrz SBoFLT9m20s1BSQnEiIIgg1OAn6hvBrNMbH3noKKwzVv3ZhpweeaoIwJe/O0jgnisQep dIAILyx4GRoyO726N2YXMQ2vzrxp1uAZfXYFWsQn5DW2aOqbMeMZz4Aw9hR956obVyAB TuP04mdRr26k5CoDiXW8cW25G9mA+gp7Tt2F0PQFgTyQhpw75Le3RkIpvynxX7vUtnw0 HYTzjmL+yI7rDnDweQODqhGPz7LJCS033e0BEZGwFbIIHcm30wTodiZlNLM8A+5IN7CD 16EQ== X-Gm-Message-State: AOJu0YxVP9Ukr6i8LBRiIB0vJf9jgft+d4Us8dplRmsUXnWY/eQW//hH wNSpOLvl/pe8OkrqJu/dczeY6AJehNTlrBm/n9XPuTllOwG1T0Nl2a0KqNlTbNlbZRKLsteukjz 9L4+etqkMcCqoqLmburBuTTLsuHHirvtXeXnxam7Y/kwytRNduf0bqg== X-Google-Smtp-Source: AGHT+IE5tW4Dh30I9daC14y4vfEOVAr4/HLfFVqP+1l6uvoMtCiuWFjSv6DAt8fwddfgjFsOfY+Eqn6g1rtnJltIekM= X-Received: by 2002:a05:6870:3749:b0:260:fb11:3e49 with SMTP id 586e51a60fabf-288874db215mr10293141fac.45.1729168886823; Thu, 17 Oct 2024 05:41:26 -0700 (PDT) Received: from 44278815321 named unknown by gmailapi.google.com with HTTPREST; Thu, 17 Oct 2024 12:41:26 +0000 From: Wang Pengcheng X-Original-From: Wang Pengcheng X-Mailer: git-send-email 2.45.2.windows.1 Mime-Version: 1.0 Date: Thu, 17 Oct 2024 12:41:26 +0000 Message-ID: Subject: [PATCH] RISC-V: override alignment of function/jump/loop To: gcc-patches@gcc.gnu.org Cc: Wang Pengcheng X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Just like what AArch64 has done. Signed-off-by: Wang Pengcheng gcc/ChangeLog: * config/riscv/riscv.cc (struct riscv_tune_param): Add new tune options. (riscv_override_options_internal): Override the default alignment when not optimizing for size. --- gcc/config/riscv/riscv.cc | 15 +++++++++++++++ 1 file changed, 15 insertions(+) the performance cost is too great, even for -Os. Similarly, if diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index 3ac40234345..7d6fc1429b5 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -295,6 +295,9 @@ struct riscv_tune_param bool overlap_op_by_pieces; unsigned int fusible_ops; const struct cpu_vector_cost *vec_costs; + const char *function_align = nullptr; + const char *jump_align = nullptr; + const char *loop_align = nullptr; }; @@ -10283,6 +10286,18 @@ riscv_override_options_internal (struct gcc_options *opts) ? &optimize_size_tune_info : cpu->tune_param; + /* If not optimizing for size, set the default + alignment to what the target wants. */ + if (!opts->x_optimize_size) + { + if (opts->x_flag_align_loops && !opts->x_str_align_loops) + opts->x_str_align_loops = tune_param->loop_align; + if (opts->x_flag_align_jumps && !opts->x_str_align_jumps) + opts->x_str_align_jumps = tune_param->jump_align; + if (opts->x_flag_align_functions && !opts->x_str_align_functions) + opts->x_str_align_functions = tune_param->function_align; + } + /* Use -mtune's setting for slow_unaligned_access, even when optimizing for size. For architectures that trap and emulate unaligned accesses,