From patchwork Tue Nov 7 18:36:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 1861228 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Ig+lR0LS; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SPxl23Ytwz1yQK for ; Wed, 8 Nov 2023 05:36:46 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4C1623858425 for ; Tue, 7 Nov 2023 18:36:44 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 3A0AF3858D33 for ; Tue, 7 Nov 2023 18:36:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A0AF3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A0AF3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699382193; cv=none; b=V3t2fMyN/Y5/90RONskcJUwNY7ql9b/aqdcPIQiA86hb2fOVkCVic6rfQWzGbj5C4wFuUVMSOQKfzs4RyIfNkg+XtKRkqkM9plRcRpiQnh2xdIRBW2mxNtCoY7w22VJuotZWxEFdzVoqHNbTGUzlO3RIoWQbuvAFVotFNdXXETY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699382193; c=relaxed/simple; bh=hXUXqFLN73lZvmen8UMcttyP0b+WoBOmhicDAezKueA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=QOm5YikMwBiCF5x9zOJG4B095wmXntnw9ooF/70dgSjWQdpmbbDKVUc6WZO2+phb+Pw26U29Y9ad2gYWmo2Y2OM9AGyAo5Q1Q2P2f7Iv0iDu1r5OKd93aDbq8zetAvlg1zn9pjpHrL1i49+ezCf4ZAUgbGwSjTtpTBgDuCutRWA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-9c3aec5f326so1409039166b.1 for ; Tue, 07 Nov 2023 10:36:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699382191; x=1699986991; darn=gcc.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=WGSII9/uDKF8AEwo+rMdkdDRgku2O+QfXATKGUN4hHg=; b=Ig+lR0LSs+NpQlwZci8a3AfjVpfG+2H4AkLBeixFuiaLobcDxlXHxMYIpG7QnYxoLb og3xwhIdLFQDTzU7xNRg0XNI8xCfsjB23KZxFe0jEb3eahNnaWF5UepO0gGVnOcOydTq bMjknB3W+b69gkfyxjyD+FBKEmw+COlx9vvDInpduUQCEiqBga7iG0/dBCP8xmfA8tqC Yh0gWWz6Bosp9lmOSwwGChtGyZW/8Ig6Qf1kLhl44qoV/iHFMdWiZL1Qq4IJ7BhK8yF9 dIRgdGOqsvbcCEStL4ABApBRYC4qVGKfKuNgAUxPDpccrWDoiTZrYYV8hduAStk7ZbPM PKDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699382191; x=1699986991; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WGSII9/uDKF8AEwo+rMdkdDRgku2O+QfXATKGUN4hHg=; b=ithQ4wWMOCJ2Hqya9lxg1JaBCgxl+5H407whZzQe3dH2GPhV5QIyAlclWd22Mpc8sW +jMF7JXtEg+8NqVFbHfC6lJWGJS+YDzR4XE+/TPni5DfCV5pt6nSJ3Hm13P+YGOLFufo Z5HpJGGl+NTA9Q/2GZ9zaCkvAI9d5XTV0qE7CcUXSVu5CrkLMkE50PKFODHKulh/dM9N I+hgTvkG1Un552vvM3S9MDCOmj2OAcmf1nTfvftHDYHdjmtVh8JvOejlnBz8k/wDNR7J w808rc2c47W0S+luIQBJbuRtEXJdguVzdI3AsE36GtgpoutPqyF12xktOEmo4gI1uNCs N4DA== X-Gm-Message-State: AOJu0YwnQ59SPFNmj0ZIfJMzAFs6yb6netAaq7Ik9vRPknBGGQsqndKm Iuak8VcUkXoM/XIUD5akvB8M4jQgxmrzAQPk8+nrP5AreHDuLg== X-Google-Smtp-Source: AGHT+IF3d51eUeD23nn3eA5qyLN9WhfXeURLkCx77VD3HM4FJZ9S4208kmNnyma8RGiidF+xmRifYbMDNa3CE+VWE2w= X-Received: by 2002:a17:906:cd0e:b0:9c7:59ff:b7fd with SMTP id oz14-20020a170906cd0e00b009c759ffb7fdmr2711355ejb.28.1699382190490; Tue, 07 Nov 2023 10:36:30 -0800 (PST) MIME-Version: 1.0 From: Uros Bizjak Date: Tue, 7 Nov 2023 19:36:19 +0100 Message-ID: Subject: [committed] i386: Make flags_reg_operand a special predicate To: "gcc-patches@gcc.gnu.org" X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org There is no need to check the mode in flags_reg_operand predicate. The mode in flags setting instructions is checked with ix86_match_ccmode. The patch avoids "warning: operand X missing mode?" warnings with VOIDmode flags_reg_operand predicate. gcc/ChangeLog: * config/i386/predicates.md ("flags_reg_operand"): Make predicate special to avoid automatic mode checks. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Uros. diff --git a/gcc/config/i386/predicates.md b/gcc/config/i386/predicates.md index a63b8cd7be5..b5a86257c9e 100644 --- a/gcc/config/i386/predicates.md +++ b/gcc/config/i386/predicates.md @@ -88,7 +88,7 @@ (define_predicate "ax_reg_operand" (match_test "REGNO (op) == AX_REG"))) ;; Return true if op is the flags register. -(define_predicate "flags_reg_operand" +(define_special_predicate "flags_reg_operand" (and (match_code "reg") (match_test "REGNO (op) == FLAGS_REG")))