From patchwork Tue Jun 9 23:46:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carrot Wei X-Patchwork-Id: 482406 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 2591014032F for ; Wed, 10 Jun 2015 09:46:16 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=PXfXHbed; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:date:message-id:subject:from:to:content-type; q= dns; s=default; b=L7f7++8h6uBVg/QHLfjwaw4krlPgVkTTq7R1bKioHap7Mw 47GRZfDs5tK5E4rfd1O0jQxxk64oKl1/0RjY7WVLYvwpdbbnDQfzy2sNivmCdp1W zngm9k/h5pJFZOyDi0080EhaAFryt81PKgm/+kIccnZ6bekRpmD3xp6MQcVb0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:date:message-id:subject:from:to:content-type; s= default; bh=jPWliPXhZYuSd2bGZIStYLFYfvw=; b=PXfXHbedexOXwHWd+3FK G0ceRk8LV9kxtwqTPS5akd3XIBRc89otPrLdOR9TDKfJCWWmOf4krq2XUhXlO7NU t6V8HxDhDVwQ+b5v2cQN88QJ1XU/Rul2nEgI3iNdAka/YqQq48xNTaYvcbSex8xc YJCUBfX7nqDy0v4b5AOT6gs= Received: (qmail 100184 invoked by alias); 9 Jun 2015 23:46:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 100167 invoked by uid 89); 9 Jun 2015 23:46:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ie0-f182.google.com Received: from mail-ie0-f182.google.com (HELO mail-ie0-f182.google.com) (209.85.223.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 09 Jun 2015 23:46:06 +0000 Received: by iebgx4 with SMTP id gx4so23835116ieb.0 for ; Tue, 09 Jun 2015 16:46:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=47ItzHOWM9S/HI1MlCf/kwgbszRF3qWqmW5WXM3viUY=; b=KdtZZlNtGqQo1S1F1FX8PY74WbduVhdkTkGR0EisT/Hsi+udxnH2icmgD820dT/1gm 86xAxnuFWrOu3OpmkF5imrlaMR4mIwzpUIFcpeTmvVKs7g8rRqa5qBessSY6srMVMNhE 92nfET4BxubYdiRAUUnG5M718hGSjcHFfuxdUAsKF3ZKjNYVNiZ/35qkeZtCL6+ZW8qI F2OjunuGH73FIbsXHNVd2TdDpv7TD634E91SDcnw/OYhSw1VvSrbKV3e/MqbCoqM5Uv9 lZDd2U3VK9SOQ27GFnaJwzLtg2zTHhFuVBscz0jfv826zPftOJrdKzfXGqsewTpPjVGk Nqxw== X-Gm-Message-State: ALoCoQmBrnXssN7MTAFN0VFgZImpGMDgAHa6oMRlcetK/KgRDtJ7fqcBvymy1fw3w5yWkLVQt8hb MIME-Version: 1.0 X-Received: by 10.50.57.39 with SMTP id f7mr1847321igq.35.1433893564647; Tue, 09 Jun 2015 16:46:04 -0700 (PDT) Received: by 10.64.19.44 with HTTP; Tue, 9 Jun 2015 16:46:04 -0700 (PDT) Date: Tue, 9 Jun 2015 16:46:04 -0700 Message-ID: Subject: [PATCH, Google] Notify df framework when removing an insn in simplify-got From: Carrot Wei To: David Li , "gcc-patches@gcc.gnu.org" Hi I forgot to notify df framework when I removed an insn, it caused df verification failure described in google bug b/16155462. The following patch passed regression test on arm qemu in both thumb and arm modes. OK for google 4.9 branch? Index: simplify-got.c =================================================================== --- simplify-got.c (revision 224174) +++ simplify-got.c (working copy) @@ -169,7 +169,10 @@ /* Since there is no usage of pic_reg now, we can remove it. */ if (use) - remove_insn (use); + { + df_insn_delete (use); + remove_insn (use); + } targetm.got_access.clear_pic_reg (); free (got_accesses); htab_delete (var_table);