From patchwork Thu Oct 10 01:55:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kugan Vivekanandarajah X-Patchwork-Id: 1174223 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-510592-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="QWzkUBHe"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="IFoAC/T9"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46pZ1q3hstz9sDQ for ; Thu, 10 Oct 2019 12:56:13 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=decHaazRS1rVe+FQC7aMh7cfhkZnDReuQW+gvFQwiRgxrv QIRalW8Y/oeEzy8owvOIauZYmVFdzuid01+Ct3FLLv3ehaj6TCozXALDkTBTqJeN S05NRY/DdOee9iFRUXO3Hj5XZ2htfhWJDsgS4I5YErma2G42/9d5NV+M9DQ7U= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=tt9W7Qv0tVSZfYkEYYQ2LMTJJeg=; b=QWzkUBHegaStXkhss4yg H1PKrL312Fy/+UEycptMq9KGmQXHxUMkVQCIhr2GE9wKK4o5r+y5TF3RgNSZF3ju GV/zBVUo91R7QQWRU3p2vR3NhntDYLnvItEItm2fkeu1DD+ShfAxFR9a0y5Rm7o4 IIexExabg+ZjJv0i7UZ4AkE= Received: (qmail 112600 invoked by alias); 10 Oct 2019 01:56:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 112592 invoked by uid 89); 10 Oct 2019 01:56:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2612, linaro X-HELO: mail-lj1-f171.google.com Received: from mail-lj1-f171.google.com (HELO mail-lj1-f171.google.com) (209.85.208.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2019 01:56:02 +0000 Received: by mail-lj1-f171.google.com with SMTP id q64so4430433ljb.12 for ; Wed, 09 Oct 2019 18:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=aEFQ9p4mqm69twUZjFWKFDtKZ6kT1zcr3mpsHC4iZq0=; b=IFoAC/T9m9z+QkDw/yMO7Z9Bi1P+eKyBhgRCshFwRvwOH7RGTL5CfcdTqnAG8HDyX9 hwD8mfDQe5totvgoNUYHUzMTYB7LQoPK5+1QEM/UDAoDBKWL+7w0vwZqehOtKIfNbc6h zsde3Dv8Dxyq5iuNnxCOue+77ig5MOtB8Oi2M04oKPtJQdZCCZwhWmFiKXPJCZteE8Y3 2f+TEg5OS6dAJzk0LclEqXvFvwWcHwzLr1eEyAHNORbnmOXzSLy97bKqGJAjaUe0/ncA XQOTq9EupHnH6IFiJGTUZYFoi3TfVX301sPD38CLGqLzBehwSQUn/S5fr0CWJr4uSLuG zr5w== MIME-Version: 1.0 From: Kugan Vivekanandarajah Date: Thu, 10 Oct 2019 12:55:23 +1100 Message-ID: Subject: [ARM] Enable DF only when TARGET_VFP_DOUBLE To: GCC Patches , Kyrill Tkachov X-IsSubscribed: yes As reported in Linaro bug report (https://bugs.linaro.org/show_bug.cgi?id=4636 ; there is no reproducible testcase provided), for some applications, we see (insn 126 125 127 9 (set (reg:DF 189) (fma:DF (reg:DF 126 [ _74 ]) (reg:DF 190) (reg:DF 191))) "ops.c":30 -1 (nil)) This looks like due to a typo in the md patterns. Attached patch fixes this. Bootsrapped and regression tested on arm-linux-gnueabihf without any regressions. Is this OK for trunk? Thanks, Kugan gcc/ChangeLog: 2019-10-10 kugan.vivekanandarajah * config/arm/vfp.md (fma4): Enable DF only when TARGET_VFP_DOUBLE. (*fmsub4): Likewise. (*fnmsub4): Likewise. (*fnmadd4): Likewise. diff --git a/gcc/config/arm/vfp.md b/gcc/config/arm/vfp.md index 661919e2357..1979aa6fdb4 100644 --- a/gcc/config/arm/vfp.md +++ b/gcc/config/arm/vfp.md @@ -1321,7 +1321,7 @@ (fma:SDF (match_operand:SDF 1 "register_operand" "") (match_operand:SDF 2 "register_operand" "") (match_operand:SDF 3 "register_operand" "0")))] - "TARGET_32BIT && TARGET_HARD_FLOAT && TARGET_FMA" + "TARGET_32BIT && TARGET_HARD_FLOAT && TARGET_FMA " "vfma%?.\\t%0, %1, %2" [(set_attr "predicable" "yes") (set_attr "type" "ffma")] @@ -1357,7 +1357,7 @@ "")) (match_operand:SDF 2 "register_operand" "") (match_operand:SDF 3 "register_operand" "0")))] - "TARGET_32BIT && TARGET_HARD_FLOAT && TARGET_FMA" + "TARGET_32BIT && TARGET_HARD_FLOAT && TARGET_FMA " "vfms%?.\\t%0, %1, %2" [(set_attr "predicable" "yes") (set_attr "type" "ffma")] @@ -1379,7 +1379,7 @@ (fma:SDF (match_operand:SDF 1 "register_operand" "") (match_operand:SDF 2 "register_operand" "") (neg:SDF (match_operand:SDF 3 "register_operand" "0"))))] - "TARGET_32BIT && TARGET_HARD_FLOAT && TARGET_FMA" + "TARGET_32BIT && TARGET_HARD_FLOAT && TARGET_FMA " "vfnms%?.\\t%0, %1, %2" [(set_attr "predicable" "yes") (set_attr "type" "ffma")] @@ -1402,7 +1402,7 @@ "")) (match_operand:SDF 2 "register_operand" "") (neg:SDF (match_operand:SDF 3 "register_operand" "0"))))] - "TARGET_32BIT && TARGET_HARD_FLOAT && TARGET_FMA" + "TARGET_32BIT && TARGET_HARD_FLOAT && TARGET_FMA " "vfnma%?.\\t%0, %1, %2" [(set_attr "predicable" "yes") (set_attr "type" "ffma")]