From patchwork Mon Sep 16 13:39:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diego Novillo X-Patchwork-Id: 275217 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 466F82C00E1 for ; Mon, 16 Sep 2013 23:39:37 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=SrN/X2Y2CdfM60Ru9R 29+Zdq7ob9lmgOxlUMxFf1pVPCQD5zorPuk10tK9xRtno/Lxpvf7dxj+nRhEA1mx Szbfkb8SbROIHQinvcq3nGYVX+KgsNUCR974GSCwti+UkpG4jQaYFIYPF1Av6r2S 4EPbeRx/O9x4AuO54/4WcpayE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=mghqlj1Nd6bzSwnsP/3Mgb0X FvM=; b=OhFwvon9l0TIlWdZL2thbrulBahxdlX9Dol6hV9QU48E8i0wCSN26tDL fJ/ly6F7GggKQ2mysTk3Foby6qlGIHGey6Q4L12G6zFN0bkCiIPSN6b+Y7lotX3N Fvq3HlM31A67RPCfPRxjYBF57/K5KV+dlqi5dAqZUW5mFM6pMME= Received: (qmail 27722 invoked by alias); 16 Sep 2013 13:39:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 27713 invoked by uid 89); 16 Sep 2013 13:39:29 -0000 Received: from mail-ie0-f169.google.com (HELO mail-ie0-f169.google.com) (209.85.223.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 16 Sep 2013 13:39:29 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL, BAYES_00, KHOP_THREADED, NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f169.google.com Received: by mail-ie0-f169.google.com with SMTP id tp5so7630347ieb.28 for ; Mon, 16 Sep 2013 06:39:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=9Ciuxai35D5/hRW5MnLOP0zhQYNz6eScWDD3Fmye9f4=; b=XKH6tAsyA+7jOd44SLttS9UBg5v23diCOGXWFetHDcGFj/2bZbqLEVMpJmtugpUX+W iwLU3b0wU4rj75n07kCjH3Eg824wstD8LKod03U0e4C77pqiZvGmpT0NTjuPozpZ0VLT RMcqqeW3v/lmGM7qtlF25PTOMgFdj00OwTbuH6UPA4c8cytyYuHyT7C0tfolDPeaeFvq /z2RNGQYSXfJ0JTkh8RS1jyqlCX9P6JCIz0RsE3niAxjubuec3GFkWCCQnV35w9F2X78 oe0Z4Yw90B3o59J2lihs3Rnf4A+kJLKVHN3Pw5r9pvEcq2+CGvOSSnCNyXJR8P/aLdrk G8gA== X-Gm-Message-State: ALoCoQn267DFOqGAiQmNGp1GUEHGDNueamdGivNj4ZawAmefOc5cc3dtWeILdicg1Yz47ALaB4ODSBGlMUA68MsCMIDi0wNz/9nCjSv03tEH1VHoElNvil9n36//N0jonC464qpiME0NNJW4G1aEAJ229DuKqa0XbgKpqAKOOSH0xPKdga/D3e3uQkWM65tvuCj/s97jam+iOr5Q0nWbtiZfOGMDpESVgA== MIME-Version: 1.0 X-Received: by 10.50.20.137 with SMTP id n9mr6335120ige.13.1379338767283; Mon, 16 Sep 2013 06:39:27 -0700 (PDT) Received: by 10.64.145.102 with HTTP; Mon, 16 Sep 2013 06:39:27 -0700 (PDT) In-Reply-To: References: <20130809223645.GA22559@google.com> <48A1A20B-1DF2-45A5-9CB6-13CDC6A89A4F@comcast.net> <5214F775.60702@redhat.com> <52161471.6040408@redhat.com> <6A000F64-A10C-4E37-81C5-FF4DEFBF7939@comcast.net> <20130913150701.GE1817@tucnak.redhat.com> Date: Mon, 16 Sep 2013 09:39:27 -0400 Message-ID: Subject: Re: RFC - Refactor tree.h From: Diego Novillo To: Jakub Jelinek Cc: Andrew MacLeod , gcc-patches X-IsSubscribed: yes On Fri, Sep 13, 2013 at 11:25 AM, Diego Novillo wrote: > On Fri, Sep 13, 2013 at 11:07 AM, Jakub Jelinek wrote: > >> E.g. today I've noticed you've lost OMP_CLAUSE_LINEAR_NO_COPYIN >> comment that has been added to tree.h recently, but you haven't >> actually moved it into tree-core.h. > > Sorry about that. I remember an update conflict, but I thought I had > incorporated it all. I will double check and fix. Done. gcc/ChangeLog | 5 +++++ gcc/tree-core.h | 19 +++++++++++++++++-- 2 files changed, 22 insertions(+), 2 deletions(-) --- 1.8.4 diff --git a/gcc/ChangeLog b/gcc/ChangeLog index b9a335a..906d01b 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2013-09-16 Diego Novillo + + * tree-core.h: Add missing comment lines from refactoring + of tree.h. + 2013-09-16 Jan Hubicka * gimple-fold.c (can_refer_decl_in_current_unit_p): Do not accept diff --git a/gcc/tree-core.h b/gcc/tree-core.h index b1bc56a..69777dc 100644 --- a/gcc/tree-core.h +++ b/gcc/tree-core.h @@ -780,6 +780,9 @@ struct GTY(()) tree_base { OMP_CLAUSE_PRIVATE_DEBUG in OMP_CLAUSE_PRIVATE + OMP_CLAUSE_LINEAR_NO_COPYIN in + OMP_CLAUSE_LINEAR + TRANSACTION_EXPR_RELAXED in TRANSACTION_EXPR @@ -800,6 +803,9 @@ struct GTY(()) tree_base { OMP_CLAUSE_PRIVATE_OUTER_REF in OMP_CLAUSE_PRIVATE + OMP_CLAUSE_LINEAR_NO_COPYOUT in + OMP_CLAUSE_LINEAR + TYPE_REF_IS_RVALUE in REFERENCE_TYPE @@ -935,6 +941,9 @@ struct GTY(()) tree_base { DECL_NONLOCAL_FRAME in VAR_DECL + + TYPE_FINAL_P in + RECORD_TYPE, UNION_TYPE and QUAL_UNION_TYPE */ struct GTY(()) tree_typed { @@ -1197,8 +1206,7 @@ struct GTY(()) tree_decl_common { unsigned lang_flag_7 : 1; unsigned lang_flag_8 : 1; - /* In LABEL_DECL, this is DECL_ERROR_ISSUED. - In VAR_DECL and PARM_DECL, this is DECL_REGISTER. */ + /* In VAR_DECL and PARM_DECL, this is DECL_REGISTER. */ unsigned decl_flag_0 : 1; /* In FIELD_DECL, this is DECL_BIT_FIELD In VAR_DECL and FUNCTION_DECL, this is DECL_EXTERNAL. @@ -1403,6 +1411,9 @@ struct GTY(()) tree_statement_list struct tree_statement_list_node *tail; }; + +/* Optimization options used by a function. */ + struct GTY(()) tree_optimization_option { struct tree_common common; @@ -1418,6 +1429,8 @@ struct GTY(()) tree_optimization_option { struct target_optabs *GTY ((skip)) base_optabs; }; +/* Target options used by a function. */ + struct GTY(()) tree_target_option { struct tree_common common; @@ -1563,6 +1576,8 @@ struct GTY(()) tree_map_base { tree from; }; +/* Map from a tree to another tree. */ + struct GTY(()) tree_map { struct tree_map_base base; unsigned int hash;