From patchwork Fri Sep 16 18:06:36 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Diego Novillo X-Patchwork-Id: 115019 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 7D2A8B71AD for ; Sat, 17 Sep 2011 04:07:01 +1000 (EST) Received: (qmail 9455 invoked by alias); 16 Sep 2011 18:06:54 -0000 Received: (qmail 9437 invoked by uid 22791); 16 Sep 2011 18:06:53 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Sep 2011 18:06:38 +0000 Received: from wpaz33.hot.corp.google.com (wpaz33.hot.corp.google.com [172.24.198.97]) by smtp-out.google.com with ESMTP id p8GI6cQv030548 for ; Fri, 16 Sep 2011 11:06:38 -0700 Received: from ywm21 (ywm21.prod.google.com [10.192.13.21]) by wpaz33.hot.corp.google.com with ESMTP id p8GI5b2u028535 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 16 Sep 2011 11:06:37 -0700 Received: by ywm21 with SMTP id 21so3994574ywm.2 for ; Fri, 16 Sep 2011 11:06:36 -0700 (PDT) Received: by 10.151.27.12 with SMTP id e12mr2531352ybj.241.1316196396844; Fri, 16 Sep 2011 11:06:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.27.12 with SMTP id e12mr2531334ybj.241.1316196396325; Fri, 16 Sep 2011 11:06:36 -0700 (PDT) Received: by 10.151.142.15 with HTTP; Fri, 16 Sep 2011 11:06:36 -0700 (PDT) In-Reply-To: References: <20110127140000.872841C6CDC@hpgntab-ubiq73.eem.corp.google.com> <4D42A634.9090802@net-b.de> Date: Fri, 16 Sep 2011 14:06:36 -0400 Message-ID: Subject: Re: [Trunk/GCC 4.6] Re: [google] Omit date from Fortran .mod files for reproducible builds From: Diego Novillo To: Tobias Burnus Cc: Simon Baldwin , gfortran , gcc-patches@gcc.gnu.org X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Fri, Jan 28, 2011 at 13:00, Diego Novillo wrote: > On Fri, Jan 28, 2011 at 06:19, Tobias Burnus wrote: >> We (Janne and I) think this patch can also be applied to the GCC 4.6 trunk; >> as the date is never read there is also no .mod ABI issue. >> >> I assume that there are no copyright issues. > > There aren't.  Google has signed a blanket copyright assignment with > the FSF.  Any patch coming from a google.com address is covered. > > I'll mark this patch for trunk.  Thanks. Tobias, I'm planning to apply this (old) patch to trunk. Still OK? I've re-bootstrapped on x86_64. No new failures. Thanks. Diego. 2011-09-16 Simon Baldwin * module.c (gfc_dump_module): Omit timestamp from output. diff --git a/gcc/fortran/module.c b/gcc/fortran/module.c index 4250a17..b29ba4b 100644 --- a/gcc/fortran/module.c +++ b/gcc/fortran/module.c @@ -5178,8 +5178,7 @@ void gfc_dump_module (const char *name, int dump_flag) { int n; - char *filename, *filename_tmp, *p; - time_t now; + char *filename, *filename_tmp; fpos_t md5_pos; unsigned char md5_new[16], md5_old[16]; @@ -5221,13 +5220,8 @@ gfc_dump_module (const char *name, int dump_flag) filename_tmp, xstrerror (errno)); /* Write the header, including space reserved for the MD5 sum. */ - now = time (NULL); - p = ctime (&now); - - *strchr (p, '\n') = '\0'; - - fprintf (module_fp, "GFORTRAN module version '%s' created from %s on %s\n" - "MD5:", MOD_VERSION, gfc_source_file, p); + fprintf (module_fp, "GFORTRAN module version '%s' created from %s\n" + "MD5:", MOD_VERSION, gfc_source_file); fgetpos (module_fp, &md5_pos); fputs ("00000000000000000000000000000000 -- " "If you edit this, you'll get what you deserve.\n\n", module_fp);